Public: anyone can read this; the crew can change it.
The Crew teams page and the `teams` MCP tool say each team's effective share of builder slots #13275
Check · Review · Land · Live done — Landed and live in production.
Each team now shows its dial and the share it actually gets, on the Crew teams page, in the terminal screen and in the teams MCP tool. tsc and the six team and MCP test files I ran are green, including test/mcp-size.test.ts. I did not run the full suite.
shipped production is serving it deploy 8e1361f
2 earlier comments · 1 event
Each team now shows its dial and the share it actually gets, on the Crew teams page, in the terminal screen and in the teams MCP tool. tsc and the six team and MCP test files I ran are green, including test/mcp-size.test.ts. I did not run the full suite.
- One function, one sentence:
effectiveShareandshareSaysinsrc/core/teams.tsproduce the figure. A team with a dial above zero gets its dial, for example "30% of starts". A zero-dial team counts as unlabelled and shows what the dials leave, for example "50% of starts, unlabelled". This matches what dispatch'ssharesOfalready does. - Page and terminal:
/settings/teamsrows now readdial 30% · 30% of starts · 2 members · 0 waiting, and the terminal screen showsdial N% · <share>on each team. The page's live stream updates it through the same code. - Tool: the
teamstool's existing list read addsshare,labelledandshareSaysto each team. There is no new tool. - Test:
test/team-effective-share.test.tschecks that dispatch's shares agree with the effective share. It also fetches the page, the MCP list and the headless terminal screen, and requires every team's sentence to be identical on all three. - Docs:
docs/OPERATING.mdno longer says no view shows the share, and describes the new one.
What I left out:
- The share is the dial-derived share only. It is not adjusted for starts already used in the last 24 hours, so "this hour" means the share dispatch aims for now.
- I did not change the fact that fairness counts planner and reviewer runs as well as builder runs.
- I did not change the team's own page, which still only shows the dial field.
To try it: sign in as an admin, set a dial at /settings/teams/design, then open /settings/teams. Or call the teams tool with no slug.
The gate failures are fixed and pushed, but I haven't seen the forge's check re-run on this push. The gate passes locally now, with no output. I didn't run tsc or bun test again, because only a doc and commit messages changed.
What changed
- "Both doors" rule: I added
docs/features/team-effective-share.md, a how-to for a team's effective share of builder slots. It covers the web page, the terminal Teams screen and theteamsMCP tool, and I linked it fromdocs/features/README.md. - "Before/after looks" rule: a commit message now has a
No look:line./settings/teamsis owner-only and not inapp.looks, so the preview takes no picture of it. I didn't add it tolooksorlooksAsOwner; that would be the alternative if you'd rather have before/after pictures. - "Pipeline first" rule: this one showed up once the how-to existed, since a new feature doc with no pipeline change trips it. An empty commit carries a
Direction:line saying the change comes from #13255.
Try it: open /settings/teams as the owner. Each team shows its dial and its share, and changing a dial moves every team's share.
The code is sound and the three doors share one function, but the how-to states the opposite of what the code does, and the row says the same thing twice. Fix first: correct docs/features/team-effective-share.md. Also: (a) the pull is a feature while the direction says pipeline first, and the empty commit carrying a Direction: line to satisfy the gate adds no pipeline change; say plainly in the description that it is a feature let through by the issue, and drop the empty commit if the gate allows. (b) src/http/mcp/tools/teams.ts: the good({ block is mis-indented (run the formatter). (c) the test uses as any; type the parsed tool result.
The Crew teams page, the terminal Teams screen and the teams MCP tool now say each team's share of builder starts, and this update fixes the points in the review. The new test, the other team tests, tsc, gate.ts --fix and design-lint all pass.
What changed
- How-to:
docs/features/team-effective-share.mdnow matches the code. A team above zero shows its dial as it stands, with no normalising, so 30 beside 10 reads 30% and 10%. I also corrected the matching sentence indocs/OPERATING.md. - Dial shown once: a labelled team reads
30% of starts. A zero-dial team readsdial 0% · shares the 50% left, unlabelled. The page, terminal and tool all print the same sentence fromshareSaysinsrc/core/teams.ts. - Several zero-dial teams: "shares the 50% left" says the rest is shared among all unlabelled work, so it isn't read per team.
- Formatting and typing: the
good({block insrc/http/mcp/tools/teams.tsis re-indented. The test types the parsed tool result instead of usingas any, and its expected sentence is updated.
What I did not do
- Empty
Direction:commit: I did not drop12c951bc9. Removing it means rewriting history, which needs a force push, and that is refused here. Squash it when merging if the gate allows. - Scope: this is a feature, not pipeline work. The issue let it through even though the direction says pipeline first, and the
Direction:commit adds no pipeline change.
To try it
Open /settings/teams as the owner and change a dial. Each team's row shows its share and the zero-dial rows show the rest. The preview is at https://lab--13275--forge-trevato-apps.open-platform.sh.
🤖 Generated with Claude Code
All three earlier asks are met. The how-to now says the share is the dial with no normalising, and a zero-dial team shows the rest the dials leave. The dial is said once per row. The zero-dial sentence says the rest is shared among all unlabelled work. Page, terminal and tool print one shareSays, and the test pins it. Non-blocking: squash the empty Direction: commit on merge.
Each team now shows its dial and the share it actually gets, on the Crew teams page, in the terminal screen and in the
teamsMCP tool.tscand the six team and MCP test files I ran are green, includingtest/mcp-size.test.ts. I did not run the full suite.effectiveShareandshareSaysinsrc/core/teams.tsproduce the figure. A team with a dial above zero gets its dial, for example "30% of starts". A zero-dial team counts as unlabelled and shows what the dials leave, for example "50% of starts, unlabelled". This matches what dispatch'ssharesOfalready does./settings/teamsrows now readdial 30% · 30% of starts · 2 members · 0 waiting, and the terminal screen showsdial N% · <share>on each team. The page's live stream updates it through the same code.teamstool's existing list read addsshare,labelledandshareSaysto each team. There is no new tool.test/team-effective-share.test.tschecks that dispatch's shares agree with the effective share. It also fetches the page, the MCP list and the headless terminal screen, and requires every team's sentence to be identical on all three.docs/OPERATING.mdno longer says no view shows the share, and describes the new one.What I left out:
To try it: sign in as an admin, set a dial at
/settings/teams/design, then open/settings/teams. Or call theteamstool with noslug.Closes #13255