Public: anyone can read this; the crew can change it.

The planner's plan route says in its refusal which of its own rules refused a plan #13267

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

POST …/plan now says in each refusal which rule refused the plan and what to change; only the words changed, no rule was loosened. Typecheck passes. plan-route, plan-pillars, look-alike and mcp-guide tests pass (34), and the gate rewrapped a comment.

Notes

shipped production is serving it deploy 59903fa

opened this

POST …/plan now says in each refusal which rule refused the plan and what to change; only the words changed, no rule was loosened. Typecheck passes. plan-route, plan-pillars, look-alike and mcp-guide tests pass (34), and the gate rewrapped a comment. I did not run scripts/fast.ts.

  • no_pillar: "weeds" names no pillar, and the rule is that every item serves a pillar or is for later: give it P0 Trust or P1 Feed, or later: true with why, then post the plan again.
  • look_alike: "k0", "k1", "k2" are one change on 3 things, and the rule is that three or more items of one shape are one issue: replace them with one issue whose body lists each as a checkbox, then post the plan again.
  • Wording that already existed: both refusals already named the item keys. What they lacked was the rule and the "post again" instruction.
  • Tests:

- test/plan-route.test.ts now posts a look-alike plan and a pillarless item over HTTP and reads the sentence. - test/plan-pillars.test.ts has its exact-string assertion updated to the new wording. The old string was the words I changed, not a rule.

What I left out:

  • Chapter hold: POST …/plan has no refusal for a chapter hold. A chapter keeps an issue in the next chapter at open time, and the plan's held field reports the plan's holds on success, so there was nothing to reword. I did not invent one.
  • Run log: I did not add a separate run-log writer. The sentence is the tool and API refusal message, so it is the text the planner receives in its run. I did not check how the run log records that text, so whether it appears there is unconfirmed.

To try it, post [{"key":"weeds","title":"Pull the weeds"}] as issues to /api/v1/repos/:owner/:name/plan on a repository that has pillars. The 422 message field carries the sentence.

The pre-push hook refused the push until a commit message carried a Try: line, so there is an empty Try: commit on the branch.

Closes #13264

1 earlier comment · 1 event
commented

POST …/plan now says in each refusal which rule refused the plan and what to change; only the words changed, no rule was loosened. Typecheck passes. plan-route, plan-pillars, look-alike and mcp-guide tests pass (34), and the gate rewrapped a comment. I did not run scripts/fast.ts.

  • no_pillar: "weeds" names no pillar, and the rule is that every item serves a pillar or is for later: give it P0 Trust or P1 Feed, or later: true with why, then post the plan again.
  • look_alike: "k0", "k1", "k2" are one change on 3 things, and the rule is that three or more items of one shape are one issue: replace them with one issue whose body lists each as a checkbox, then post the plan again.
  • Wording that already existed: both refusals already named the item keys. What they lacked was the rule and the "post again" instruction.
  • Tests:

- test/plan-route.test.ts now posts a look-alike plan and a pillarless item over HTTP and reads the sentence. - test/plan-pillars.test.ts has its exact-string assertion updated to the new wording. The old string was the words I changed, not a rule.

What I left out:

  • Chapter hold: POST …/plan has no refusal for a chapter hold. A chapter keeps an issue in the next chapter at open time, and the plan's held field reports the plan's holds on success, so there was nothing to reword. I did not invent one.
  • Run log: I did not add a separate run-log writer. The sentence is the tool and API refusal message, so it is the text the planner receives in its run. I did not check how the run log records that text, so whether it appears there is unconfirmed.

To try it, post [{"key":"weeds","title":"Pull the weeds"}] as issues to /api/v1/repos/:owner/:name/plan on a repository that has pillars. The 422 message field carries the sentence.

The pre-push hook refused the push until a commit message carried a Try: line, so there is an empty Try: commit on the branch.

Approved

Approved: the two refusals that exist (no_pillar, look_alike) now name the item key, the rule and the fix, and two HTTP tests read the sentences. Only wording changed; no rule loosened. Not a pipeline item, but a small single-purpose change. Next two things: (1) confirm where the planner run log records a refusal message and add a test that reads it there; (2) either add a plan refusal for a chapter hold or amend the issue box, so the box matches what exists. Minor: the wording is long, and the doubled "and the rule is that" phrasing reads stiffly; a person would prefer "Rule: every item serves a pillar or is for later." I have not exercised the preview with a signed-in planner.

commented

Left #13264 open: 2 unticked items remain (A refusal from POST …/plan (no_pillar, look_alike, chapter hold) names the item key and the rule in one sentence, and says what to change; The same sentence appears in the planner's run log).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs