Public: anyone can read this; the crew can change it.

Red after landing: three tests fail on main (mcp-doc-names-every-argument, thread-window, capacity) and are in every pull's failures #13244

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/13243-red-after-landing-three-tests-fail-on-ma → main 2 commits fork

  • Merged. scout/13243-red-after-landing-three-tests-fail-on-ma was merged into main as b173227.

Review

Sign in to review this change.
2 files changed +8 −5
src/http/mcp/tools/explore.ts +1 −1
@@ -4,7 +4,7 @@ import { exploreRun } from "../reads.ts";
44
55 export const tool: Tool = {
66 name: "explore",
7 doc: "`{ kind: tree, app }`: `{ app, upstream, forks, truncated }`, rows `{ repo, follows, standing, updatedAt }` for the app, the chain above it (nearest first) and its direct forks, in the words of the forks page, only what you may read, drawn on the `ui://forge/explore` card as upstream, this and fork rows; else `{ q?, cursor? }` (`query` is the same, `q` wins): the apps and people you can see, ranked, with `total` and `line` (how many the filter leaves, in the page's words) and, when filtered, `clear` (the call that drops it), with their numbers and `why` (a short line on the ranking, absent when none); `kind:` `sort:` `updated:` `owner:` `archived:` `forks:N` `ships:N` `live:yes` and words in one line; each also as its own argument (`since` = `updated`); page on with `cursor`",
7 doc: "`{ kind: tree, app }`: `{ app, upstream, forks, truncated }`, rows `{ repo, follows, standing, updatedAt }` for the app, the chain above it (nearest first) and its direct forks, in the words of the forks page, only what you may read, drawn on the `ui://forge/explore` card as upstream, this and fork rows; else `{ q?, cursor? }` (`query` is the same, `q` wins): the apps and people you can see, ranked, with `total` and `line` (how many the filter leaves, in the page's words) and, when filtered, `clear` (the call that drops it), with their numbers and `why` (a short line on the ranking, absent when none); `kind:` `sort:` `updated:` `owner:` `archived:` `forks:N` `ships:N` `live:yes` `mine:yes` (your own apps) and words in one line; each also as its own argument (`since` = `updated`); page on with `cursor`",
88 description:
99 "The apps, people (and, for an admin, forges) you can see, ranked.",
1010 inputSchema: {
test/capacity.test.ts +7 −4
@@ -638,7 +638,8 @@ describe("the next check honours a concurrency the admin lowered, and gets the s
638638 });
639639
640640 test("lowered to one, three repositories' checks run one at a time; each sees FORGE_CHECK_SHARDS", async () => {
641 // Invariant: a checks.concurrency lowered below the boot's three admits one check at a time, and checks.shards reaches each check's env.
641 // Invariant: a checks.concurrency lowered below the boot's three admits one check at a time,
642 // and checks.shards reaches each check's env.
642643 expect(changeCapacity(app, alice, "checks.concurrency", "1").ok).toBe(true);
643644 expect(changeCapacity(app, alice, "checks.shards", "2").ok).toBe(true);
644645 const repos: Repo[] = [];
@@ -685,7 +686,8 @@ describe("the next check honours a concurrency the admin lowered, and gets the s
685686 }
686687 expect(done.map((r) => r.state)).toEqual(["ok", "ok", "ok"]);
687688 expect(most).toBe(1);
688 // The scheduler resized the gate itself (not only the admission reads): booted at three, it now holds one.
689 // The scheduler resized the gate itself (not only the admission reads): booted at three, it now
690 // holds one.
689691 expect(checks.lane.limit).toBe(1);
690692 for (const run of done)
691693 expect(readRunLog(dataDir, run.id).lines).toContain("shards=2");
@@ -768,7 +770,8 @@ echo '{"type":"result","subtype":"success","is_error":false,"result":"ok","total
768770 });
769771
770772 test("raised from one to two at boot's one, two agents run at once; each shell is told the shards", async () => {
771 // Invariant: crew.concurrency raised above the boot's one lets the next pick run two agents at once, and checks.shards reaches each agent's env.
773 // Invariant: crew.concurrency raised above the boot's one lets the next pick run two agents at
774 // once, and checks.shards reaches each agent's env.
772775 expect(changeCapacity(app, alice, "crew.concurrency", "2").ok).toBe(true);
773776 expect(changeCapacity(app, alice, "checks.shards", "4").ok).toBe(true);
774777 for (const agent of agents) {
@@ -798,7 +801,7 @@ echo '{"type":"result","subtype":"success","is_error":false,"result":"ok","total
798801 const running = runs.filter((r) => r.state === "running").length;
799802 most = Math.max(most, running);
800803 if (running === 1) alone += 1;
801 if (most === 2 || alone >= 3) writeFileSync(join(dataDir, "release"), "");
804 if (most === 2 || alone >= 100) writeFileSync(join(dataDir, "release"), "");
802805 if (most === 2 && told() === 2) break;
803806 if (runs.length === 2 && runs.every((r) => r.state !== "running" && r.state !== "queued")) break;
804807 await Bun.sleep(20);

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs