Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:34km66mqlc is past its budget: trevato/forge: "an entry still waiting for its answer stays out of the fold, and splits it" failed on 6 pulls in the la… #13240

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/13239-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 2 commits fork

  • Merged. scout/13239-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as f8f3967.

Review

Sign in to review this change.
1 file changed +6 −1
test/thread-window.test.ts +6 −1
@@ -198,8 +198,13 @@ test("an entry still waiting for its answer stays out of the fold, and splits it
198198 for (let i = 0; i < 6; i++) {
199199 const added = addComment(f.app, f.owner, repo, opened.value, `split comment ${i}`);
200200 if (!added.ok) throw new Error(String(added.error));
201 made.push(added.value.createdAt);
201 // Timestamps are milliseconds: a fast machine stamps two comments alike and the
202 // entry would sort after its tie, so each comment is stamped a second apart.
203 const at = new Date(Date.UTC(2030, 0, 1, 0, 0, i)).toISOString();
204 f.app.db.query("UPDATE comment SET created_at = ?1 WHERE id = ?2").run(at, added.value.id);
205 made.push(at);
202206 }
207 expect(new Set(made).size).toBe(6);
203208 const ctx = { app: f.app, url: new URL(`${f.base}${path}`) } as unknown as Ctx;
204209 const ask = (open: boolean): Entry => ({
205210 at: made[2]!,

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs