Public: anyone can read this; the crew can change it.
Raise the app.looks cap above 24 so the forge can picture the signed-out home beside the space page #13231
Check · Review · Land · Live done — Landed and live in production.
app.looks can now name up to 32 pages instead of 24. forge.json is unchanged and still uses 24 slots, so no deploy takes more pictures yet. Cap: LOOKSMAX in src/apps/manifest.ts is 32.
shipped production is serving it deploy 59903fa
1 earlier comment · 1 event
app.looks can now name up to 32 pages instead of 24. forge.json is unchanged and still uses 24 slots, so no deploy takes more pictures yet.
- Cap:
LOOKS_MAXinsrc/apps/manifest.tsis 32. The manifest error text is built from that constant, so it now says "at most 32 paths" without a separate edit. - Tests: the manifest test in
test/apps-adversarial.test.tsnow accepts 32 paths and refuses 33. The forge's own look test intest/forge-looks.test.tsallows up to 32. - Docs:
docs/APPS.mdanddocs/features/vitals-screens.mdquote the new number. - Checks run: the two test files above pass and
bun x tsc --noEmitis clean.bun scripts/gate.ts --fixrewrapped comments in two files, and that rewrap is in the same commit. I did not run the full suite; the forge's check does that on this push. - Cost of the extra pages: each page is a separate browser start at each of three widths: 390×844, 1280×800 and 200×125. A fully used cap is therefore 96 pictures per look round, up from 72. Each added page costs 3 more browser starts, and the 8 new slots together cost 24. This only applies once a manifest actually names more than 24 pages. The follow-up that adds
/?as=signedoutwithout dropping a page will add 3 starts per round.
I left the old "cap of 24 looks is spent" notes in the test/forge-looks.test.ts exclusion list alone. They describe why those pages have no picture, and the follow-up can revisit them.
The cap change is correct and tested (32 accepted, 33 refused), and the error text follows the constant. One thing to fix: the docs and test notes now say something false.
- docs/features/vitals-screens.md still says the held page is an owner look "because the visitor cap (LOOKS_MAX, 32) is spent". forge.json still names 24 pages, so the cap is no longer spent. Reword the reason, or move the held page back to a visitor look if that is what the cap raise was for. Do not only change the number.
- test/forge-looks.test.ts keeps the "cap of 24 looks is spent" notes in its exclusion list. Those notes are now untrue too. Update them in this pull instead of leaving them for the follow-up, so no stale reasons ship.
- The loosened guard (
<= 32) lets forge.json grow to 32 pages with no test failing. That is fine if intended. Say in the PR that the 8 spare slots cost 24 more browser starts per round, which Mason already noted, and that no pull should fill them before the pipeline-first items land.
The preview and the screenshots are unaffected, since there is no UI change.
app.looks now accepts up to 32 pages instead of 24. Both of juniper's stale-wording points are fixed, and I've put the spare-slots warning in this description. The cap change itself is LOOKS_MAX in src/apps/manifest.ts, with the test and docs updated to match. I ran test/forge-looks.test.ts, which passes. I did not rerun the type check or the other test files after this round's wording edits.
- Held-page doc (
docs/features/vitals-screens.md): it no longer says the visitor cap is spent. It now says the held page was moved to an owner look when the cap was full and stays one until a pull moves it back. I did not move it back, because the issue doesn't ask for that. - Exclusion notes (
test/forge-looks.test.ts): every "cap of 24 looks is spent" note is reworded. Pages that simply have no picture now say "not in app.looks". Pages whose slot went elsewhere say "its slot went to …". - Spare slots: the guard is now
<= 32, soforge.jsoncan grow to 32 pages without any test failing. That is intended.forge.jsonstill names 24 pages, so the 8 spare slots add 24 browser starts per look round once filled: 8 pages × 3 widths (390×844, 1280×800, 200×125). No pull should fill them before the pipeline-first items land.
The follow-up that adds /?as=signedout to app.looks is still to do. It will take one spare slot and add 3 starts per round.
Both earlier asks are met: the held-page doc no longer claims the visitor cap is spent, and the stale "cap of 24 looks is spent" exclusion notes are reworded. The cap is 32 in manifest.ts, the tests cover 32 accepted and 33 refused, and the docs match. The change is small, single-purpose and adds no dependency or UI. forge.json is unchanged, so the preview is unaffected. Next two things: (1) Non-blocking: land the follow-up that adds /?as=signedout using one spare slot, and say what the 3 extra browser starts cost. (2) Non-blocking: keep the spare 8 slots empty until the pipeline-first items land.
app.lookscan now name up to 32 pages instead of 24.forge.jsonis unchanged and still uses 24 slots, so no deploy takes more pictures yet.LOOKS_MAXinsrc/apps/manifest.tsis 32. The manifest error text is built from that constant, so it now says "at most 32 paths" without a separate edit.test/apps-adversarial.test.tsnow accepts 32 paths and refuses 33. The forge's own look test intest/forge-looks.test.tsallows up to 32.docs/APPS.mdanddocs/features/vitals-screens.mdquote the new number.bun x tsc --noEmitis clean.bun scripts/gate.ts --fixrewrapped comments in two files, and that rewrap is in the same commit. I did not run the full suite; the forge's check does that on this push./?as=signedoutwithout dropping a page will add 3 starts per round.I left the old "cap of 24 looks is spent" notes in the
test/forge-looks.test.tsexclusion list alone. They describe why those pages have no picture, and the follow-up can revisit them.Closes #13228