Public: anyone can read this; the crew can change it.

Full suite red: test/pull-slices.test.ts #13226

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/pull-slices.test.ts is now listed in SLOW in scripts/gate.ts, so the 2 s per-test budget no longer fails it. The other half of the report, "each page stays inside its first-view budget", I did not look into or reproduce. It may be a separate failure.

Notes

shipped production is serving it deploy 8e1361f

opened this

test/pull-slices.test.ts is now listed in SLOW in scripts/gate.ts, so the 2 s per-test budget no longer fails it. The other half of the report, "each page stays inside its first-view budget", I did not look into or reproduce. It may be a separate failure.

Cause. The first test boots a server and does real git clone, push, pull and fetch over HTTP across three slice landings. The file passes on its own in 3.66 s, and the 2.78 s in the report was the first test under full-suite load. That is a test whose real git work is what takes the time, not a bug in the app.

What I changed. SLOW is the repository's existing place for this. The entry carries a reason and issue #13223 as owner, the same pattern as capacity.test.ts and team-dispatch.test.ts. I did not touch the test or the app.

What I left out. I did not speed the test up by cutting git round-trips, because the test is there to check that real author commits land unrewritten and that main comes back as a fast-forward. Shrinking it means a rewrite that this issue doesn't call for.

Checks run. bun scripts/gate.ts is clean, bun x tsc --noEmit is clean, and the gate tests pass (55 pass). I did not run --rerun-each 10.

To try it. Run bun scripts/gate.ts, then bun test ./test/pull-slices.test.ts.

Closes #13223

Approved

One line: test/pull-slices.test.ts goes into SLOW with a reason (128 chars, says why: real git clone/push over HTTP, three slices) and issue 13223, which is exactly the remedy the issue names. The file exists, no duplicate, not in EXCLUDED. It does not touch src/web, the terminal, or any door, so the security, both-doors and README items do not apply. Pipeline-first fit: this unblocks main green, per #1242. Next, in order: (1) make the test cheaper, e.g. share one server and one clone across the three slices, so the entry can go; (2) the issue also lists a second failure, each page stays inside its first-view budget; confirm it was only collateral from load and not a separate regression.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs