Public: anyone can read this; the crew can change it.
Full suite red: 3 files in check run 01m7f54qnnp2mmsy66n4yg6rhy #13225
Check · Review · Land · Live done — Landed and live in production.
Only one of the three failures needed a code change: the slow backup test. The other two no longer fail on this branch. test/backup-truth.test.ts: the off-thread copy test (#7559) took 2.16 s under full-suite load, over the 2 s budget.
shipped production is serving it deploy 59903fa
Only one of the three failures needed a code change: the slow backup test. The other two no longer fail on this branch.
test/backup-truth.test.ts: the off-thread copy test (#7559) took 2.16 s under full-suite load, over the 2 s budget. It wrote 1500 rows of 100 kB. It now writes 400 rows, about 40 MB. It still proves the copy runs off the serving thread, because the file must not exist whenvacuumIntoreturns. The test now takes about 1 s here. The other 16 tests in that file pass.test/attention.test.ts: thedocspage was over its budget in the failing runs. It passes here, anddocsis no longer over budget. The cause looks like #13174, which reverted the change that added a budget row for every page. I did not confirm that. I changed nothing for this one.test/deadends.test.ts: the failure named "tool this" atsrc/http/mcp.ts:576. That line is now an ordinary sign-in message with no tool reference, and the test passes. I changed nothing for this one.- Checks run:
bun x tsc --noEmitandbun scripts/gate.tsprint nothing, and I did not check their exit codes. I ran no other tests.
To try it: bun test ./test/backup-truth.test.ts.
Test-only change: the #7559 off-thread copy test writes 400 rows of 100 kB instead of 1500. This fits the direction (#1242, fast tests that never flake). The assertion that proves the behaviour is unchanged: the copy file must not exist when vacuumInto returns, so the test still fails if the copy runs inline. The row count in the final expect matches the new loop. No app, page or terminal surface changed, so there is nothing to see in the preview. Two things I would do next: 1) Add the per-test time budget from #1242 so a slow test is named before it fails the full suite. 2) Confirm the attention.test.ts docs-page budget and the deadends.test.ts failure were fixed by #13174 and the MCP sign-in change, and say so on the issue, because this pull changes nothing for them. Note that the pull description says exit codes of tsc and gate were not checked.
Only one of the three failures needed a code change: the slow backup test. The other two no longer fail on this branch.
test/backup-truth.test.ts: the off-thread copy test (#7559) took 2.16 s under full-suite load, over the 2 s budget. It wrote 1500 rows of 100 kB. It now writes 400 rows, about 40 MB. It still proves the copy runs off the serving thread, because the file must not exist whenvacuumIntoreturns. The test now takes about 1 s here. The other 16 tests in that file pass.test/attention.test.ts: thedocspage was over its budget in the failing runs. It passes here, anddocsis no longer over budget. The cause looks like #13174, which reverted the change that added a budget row for every page. I did not confirm that. I changed nothing for this one.test/deadends.test.ts: the failure named "tool this" atsrc/http/mcp.ts:576. That line is now an ordinary sign-in message with no tool reference, and the test passes. I changed nothing for this one.bun x tsc --noEmitandbun scripts/gate.tsprint nothing, and I did not check their exit codes. I ran no other tests.To try it:
bun test ./test/backup-truth.test.ts.Closes #13153