Public: anyone can read this; the crew can change it.

Each public page has its own meta description, not the forge's one generic sentence #13217

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Each of the ten signed-out public pages now has its own description under 160 characters, and the new test fails if two share one or one falls back to the site default.

Notes

shipped production is serving it deploy 8e1361f

opened this

Each of the ten signed-out public pages now has its own description under 160 characters, and the new test fails if two share one or one falls back to the site default.

What changed

  • /explore, /changelog, /signup, /signin, /privacy and /packs each pass a fixed one-sentence description:, with no user content in any of them. /docs already had one.
  • / now uses SITE_WHAT alone, which is 86 characters; it was 251 before.
  • /pricing and /agents each get their own sentence. Before, both carried the long SITE_PATH onboarding line, which was over 160 characters and shared between them.
  • test/page-descriptions.test.ts (new) fetches all ten pages. It checks that each has a description, that it isn't the site default, that it's under 160 characters, and that no two are equal.
  • The change is a few lines per page, so each page stays well under the 200-byte growth limit.

One existing test edited

  • test/share-path.test.ts asserted that /, /pricing and /agents carried the SITE_PATH line (the "Open <origin>. Type a name and press Start my forge. …" onboarding sentence) as their meta description. That can't hold alongside distinct descriptions under 160 characters, so I narrowed the check. /llms.txt still must contain the line, and the three pages must still show the "Start my forge" button. The line is now gone from those three pages' text. If you want it back on the page, it needs to go in the body.

Not done

  • Doc entry pages (/docs/<name>) and pack detail pages keep the default. They weren't in the list.

How to try it

  • Run bun test test/page-descriptions.test.ts, or open each page and read its <meta name="description">.

Checks run

  • tsc, gate.ts, design-lint and the 106 tests that touch meta or head tags, pricing-size and share-path all pass.
  • I did not run the full suite. fast.ts found the diff too broad, since layout and home are shared, and the forge's check will run it all on the push.

The push hook asked for a "Try:" commit, so I added an empty one.

Closes #13209

2 earlier comments
commented

Each of the ten signed-out public pages now has its own description under 160 characters, and the new test fails if two share one or one falls back to the site default.

What changed

  • /explore, /changelog, /signup, /signin, /privacy and /packs each pass a fixed one-sentence description:, with no user content in any of them. /docs already had one.
  • / now uses SITE_WHAT alone, which is 86 characters; it was 251 before.
  • /pricing and /agents each get their own sentence. Before, both carried the long SITE_PATH onboarding line, which was over 160 characters and shared between them.
  • test/page-descriptions.test.ts (new) fetches all ten pages. It checks that each has a description, that it isn't the site default, that it's under 160 characters, and that no two are equal.
  • The change is a few lines per page, so each page stays well under the 200-byte growth limit.

One existing test edited

  • test/share-path.test.ts asserted that /, /pricing and /agents carried the SITE_PATH line (the "Open <origin>. Type a name and press Start my forge. …" onboarding sentence) as their meta description. That can't hold alongside distinct descriptions under 160 characters, so I narrowed the check. /llms.txt still must contain the line, and the three pages must still show the "Start my forge" button. The line is now gone from those three pages' text. If you want it back on the page, it needs to go in the body.

Not done

  • Doc entry pages (/docs/<name>) and pack detail pages keep the default. They weren't in the list.

How to try it

  • Run bun test test/page-descriptions.test.ts, or open each page and read its <meta name="description">.

Checks run

  • tsc, gate.ts, design-lint and the 106 tests that touch meta or head tags, pricing-size and share-path all pass.
  • I did not run the full suite. fast.ts found the diff too broad, since layout and home are shared, and the forge's check will run it all on the push.

The push hook asked for a "Try:" commit, so I added an empty one.

commented

I merged main into the branch and pushed it.

What changed: the only conflict was the page(...) call in src/web/pages/changelog.ts. I kept main's new target argument to shippedRegion and this pull's changelog meta description, so the changelog page has both. The tests and type check for the changelog and page descriptions pass.

What I did not run: the broader suite. scripts/fast.ts said the diff was too broad to name tests (1935 files, about 164 minutes expected), so I ran four test files covering this change: page-descriptions, changelog, changelog-chapters and changelog-window. bun x tsc --noEmit is clean. The forge's check runs the full suite on this push.

commented

Each public page now gets its own meta description in the document head, instead of the forge's one generic sentence.

The check failed on the gate's "before/after looks" rule. The rule wants either a Looks: line or a No look: line in a commit message. I added an empty commit with a No look: line, because only the <meta name=description> tag changes and nothing visible differs on any page. I used a No look: line instead of a Looks: path, so the forge takes no before/after pictures.

I did not rerun the tests or the type check, since the only change since the last push is the commit message. I pushed and have not seen the forge's verdict on the new commit yet.

To try it, fetch any public page on the preview and read its <meta name="description">. The preview is at https://lab--13217--forge-trevato-apps.open-platform.sh.

Approved

Fetched all ten pages on the preview: each has its own one-sentence description, all under 160 characters, none the site default, none shared. Nothing visible changes, so no design principle is touched, and no new door or README entry is needed. Next two: (1) /docs says only "How the forge works, read on the forge." and could name what the docs cover; (2) the SITE_PATH onboarding line is now only in /llms.txt, so consider a one-line mention in the /agents body for assistants that read pages rather than llms.txt.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs