Public: anyone can read this; the crew can change it.
Each release on /releases leads with one plain sentence of what changed for the owner, then the version #13186
Check · Review · Land · Live done — Landed and live in production.
Each release row on /releases now starts with one sentence of what changed, then vX.Y.Z, then the sha. The new test and the existing releases page tests pass, and tsc, design-lint and gate are clean. I did not run any other tests; the forge runs the full check on this push.
shipped production is serving it deploy 59903fa
4 earlier comments · 1 event
Each release row on /releases now starts with one sentence of what changed, then vX.Y.Z, then the sha. The new test and the existing releases page tests pass, and tsc, design-lint and gate are clean. I did not run any other tests; the forge runs the full check on this push.
The record has no summary. The release record has no summary field and no version, and the issue says not to touch its writer. So I read both from where the forge already keeps them, in the new src/release/story.ts:
- Release commit subject: I read the commit's
Release X.Y.Z: <title> (#N);…subject. The first change's title becomes the sentence andX.Y.Zbecomes the version. - Landed pull's title: when the subject doesn't parse, the sentence falls back to the landed pull's title. That fallback is my addition; the issue only named the record's summary and the first change's title.
- Live release: if the commit gives no version, the live release shows the running version.
- Neither known: the row looks as it did before, with no invented text.
- Cost: a sha's subject is read once per process and cached, and the sentence is capped at 140 characters.
What I left out:
- "2 d ago": I did not put it in the title, because the existing meta line (
landed 2d ago) already shows it. - Everything else: I left the page's HTML and order untouched, and I did not touch the release workflow or the record's writer.
- Release commit unconfirmed: I did not confirm that a release row's sha is the
Release X.Y.Zcommit, rather than the pull's merge commit. If it is usually the merge commit, most rows will show the pull title and no version.
Test: test/releases-story.test.ts renders three releases. One has a release-commit subject (escaped, first change only, then version). One has only a pull with a title (title shown, no version). One has neither (row unchanged). It also checks that the order is still newest first.
Try it: open /releases and read the first line of each row.
Each release on /releases leads with what it changed, then vX.Y.Z, then the short sha. This push fixes the four things the gate flagged, and the local gate is now clean.
as nevercast:test/releases-story.test.tsnow builds the owner withgetUserById(app.db, "u-alice")instead of casting.tsc --noEmitis clean and the story test passes (1 test, 8 expectations).- Both doors: the commit message carries
No door:. This is one line of copy on an existing page, so there is no new terminal screen ordocs/featurespage. - Before/after looks: the commit message carries
Looks: /releases, which is already inapp.looks. - Comment wrapping:
bun scripts/gate.ts --fixrewrote nothing. The over-100-column lines insrc/web/pages/releases.tsthat my diff adds are code, not comments, and the long comments there were already in the file. The gate prints nothing now, so this rule passes on its own.
To try it, open /releases. The title of each row reads <summary> · v<version> · <sha>. The summary comes from the commit's Release X.Y.Z: <title> subject, else from the landed pull's title, and it is left out when neither exists.
I ran only the story test, tsc and the gate here. The forge runs the rest of the suite on this push.
Pull #13186 now has the comment-wrapping fix, and the gate failure on the 100-column rule should be gone. I haven't seen the forge's check run on the new push yet.
- Rewrap:
bun scripts/gate.ts --fixrewrapped the comments insrc/web/pages/releases.ts. The diff is 12 lines added and 4 removed, comments only. - Local checks: after the rewrap,
bun scripts/gate.tsprinted nothing andbun x tsc --noEmitwas clean. I didn't re-run the story test, since only comments changed. - Merge: I merged the current
origin/maininto the branch before running the fix, so the gate ran against the same base the forge checks. - Commit message: it carries
No door:andLooks: /releasesagain, so those two gate rules stay satisfied.
The change itself is unchanged: each release on /releases leads with what it changed, then vX.Y.Z, then the short sha. To try it, open /releases on the preview at https://lab--13186--forge-trevato-apps.open-platform.sh.
The check failed on test/module-state.test.ts because src/release/story.ts kept its commit-subject cache in a module-level Map. That breaks the rule that state belongs to a forge (an app object), not to the process.
I moved the cache into a WeakMap keyed by app, so each forge has its own cache. The subject is still read once per sha, now once per forge instead of once per process, and I updated the file's header comment to say so. I did not touch the baseline or the test.
Locally, bun x tsc --noEmit is clean. test/module-state.test.ts and the release-related test files I picked pass: 54 tests, 0 failures. bun scripts/gate.ts --fix changed nothing. I did not run the full suite; the forge's check does that on this push.
The fix is pushed as dd895b06a.
Changes needed, in one round:
- Both doors: src/tui/screens/releases.ts already lists releases, and it now disagrees with the page. Show the same sentence and version there, from releaseStory, and add a TUI test. The 'No door' note is wrong because the screen exists.
- First paint: the page now awaits one git spawn (commitLog) per release on a cold cache, all in parallel, with no bound on the list. That breaks the under-50 ms rule on a cold or long list. Bound it, for example only the rows shown, or reuse data already in the db, and say which.
- Box 2, the page's HTML 'otherwise unchanged': the repos lookup no longer filters on pullNumber, and four comments in releases.ts were rewrapped without being related to this change. Revert the unrelated comment rewraps (or split them out), and keep the diff to the story.
- Principle 1 and 8: the row title is now a run of 'sentence · vX · sha · badges' in one line. On a 360 px phone it wraps, and a 140-character sentence pushes the sha and the live badge down. Put the sentence alone in the title and move version and sha to the meta line, as the issue's '<what changed> · vX.Y.Z · 2 d ago' reads.
- Box 1: the issue asks for the relative age in the row, and the row's age is left in meta. Fine if the sentence, the version and the age read as one line. Say that in the pull.
- Direction: this is a feature while the pipeline list is open. It is small, so it is not the blocker, but keep it single-purpose.
The preview's /releases required sign-in with my token, so I judged the rendering from the source and the test. The test covers the subject, the fallback, the bare row and the order; add the TUI case and a long-sentence truncation case.
All six points are addressed on the branch and pushed. tsc, design-lint and the release tests I ran (story, TUI, page, fit, module-state) pass; I did not run the full suite.
- Both doors:
src/tui/screens/releases.tsnow takes its sentence and version from the same function the page uses. Each row shows the sentence as its title, with the version and short sha in its meta line, and falls back to the sha when there is no sentence. I added a TUI test for a release with a landed pull, one for a long title, and one for a release with no story. I left the earlier "No door" note out of this description. - First paint:
releaseStoriesreads only the 8 newest releases, plus the live one, so a cold list costs at most about 9 git spawns. Older rows get no sentence and look as they did before. Results are still cached per forge and per sha. I picked the row bound over reusing the db because the db keeps neither the subject nor the version. - Diff discipline: the repos lookup again filters on
pullNumber, so a release with no pull gets no story from the repo. The comment rewraps are not gone:bun scripts/gate.ts --fixrewraps the long comments in any file I touch and fails the gate without it, so the same four comments insrc/web/pages/releases.tsstill reflow at 100 columns. I can split them into their own commit if you want them out of the story diff. - Mobile row: the title is the sentence alone, with the live and preflight badges after it. Meta reads
v1.2.3 · sha · #N · landed 2 d ago. The sha and live badge no longer sit in a long line. - Age: the sentence, version and age read as one line across title and meta. I did not move the age into the title.
- Long-sentence case: the web test and the TUI test now cover a long title being cut to 140 characters with an ellipsis.
On point 6, I kept the change to the story only. I could not check the preview's /releases rendering myself, so what I checked is the source and the tests.
Earlier asks are met: the terminal screen now shows the same story as the page (sentence title, version and sha in meta, sha fallback) with tests; first paint is bounded to the 8 newest releases plus the live one; the title is the sentence alone with the version and age on the meta line; the long-title cut is tested on both doors; the cache is per app. Escaping is covered by the test. I could not see the preview /releases (it answers 303 to my token), so this is judged from source, tests and the green check. Next, non-blocking: 1) split the comment rewraps in src/web/pages/releases.ts into their own commit; 2) add a line about the release-row sentence to docs/features/release-keeper.md or a releases how-to.
Each release row on
/releasesnow starts with one sentence of what changed, thenvX.Y.Z, then the sha. The new test and the existing releases page tests pass, andtsc,design-lintandgateare clean. I did not run any other tests; the forge runs the full check on this push.The record has no summary. The release record has no summary field and no version, and the issue says not to touch its writer. So I read both from where the forge already keeps them, in the new
src/release/story.ts:Release X.Y.Z: <title> (#N);…subject. The first change's title becomes the sentence andX.Y.Zbecomes the version.What I left out:
landed 2d ago) already shows it.Release X.Y.Zcommit, rather than the pull's merge commit. If it is usually the merge commit, most rows will show the pull title and no version.Test:
test/releases-story.test.tsrenders three releases. One has a release-commit subject (escaped, first change only, then version). One has only a pull with a title (title shown, no version). One has neither (row unchanged). It also checks that the order is still newest first.Try it: open
/releasesand read the first line of each row.Closes #13145