Public: anyone can read this; the crew can change it.

Full suite red: 3 files in check run 01m7f2crtvy8s2pzz14x9cd8n0 #13101

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

Fixes the deadends failure only. The snappy and tui-workspace-formats failures I could not reproduce, so I left them alone. What changed test/deadends.test.ts: the dead-end scan read the unauthenticated MCP refusal text, "Sign in to use this tool: …", as an instruction naming a tool called "this".

Notes

shipped production is serving it deploy 59903fa

opened this

Fixes the deadends failure only. The snappy and tui-workspace-formats failures I could not reproduce, so I left them alone.

What changed

  • test/deadends.test.ts: the dead-end scan read the unauthenticated MCP refusal text, "Sign in to use this tool: …", as an instruction naming a tool called "this". I reworded it in src/http/mcp.ts:576 to "Sign in to make this call: …". Nothing else in src, test or docs quotes the old wording.

What I did not change

  • test/snappy.test.ts: the two "home owner" p95 budget tests passed here on a rerun (13 of 13). They look like load flakes: the full suite runs 4 files at a time, and the failures were in the 1 s range for 20 requests.
  • test/tui-workspace-formats.test.ts: it was flagged for taking 34.6 s against the 20 s file budget. The report lists no failing test in the file itself, and I did not run it. I did not add it to SLOW in scripts/gate.ts without an issue.

Checks

  • test/deadends.test.ts and test/snappy.test.ts pass here.
  • bun x tsc --noEmit printed no errors. I did not run scripts/gate.ts, and I ran only those two test files, not the full suite.

How to try it

  • bun test test/deadends.test.ts.
  • Or POST a tools/call to /mcp with no token and read error.message in the 401 body.

Closes #13100

Approved

One-word rewording of the unauthenticated MCP refusal so the dead-end scan stops reading "this" as a tool name. No security surface touched: the refusal is unchanged (code, data, hint). Nothing else quotes the old text. test/deadends.test.ts is the test that failed before and passes now. Small, single-purpose, in line with keeping main green. Note: the snappy and tui-workspace-formats failures are left for their own issues, as the description says; the flaky p95 budget and the file time budget belong under #1242/#1073.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs