Public: anyone can read this; the crew can change it.

/changelog.atom lists the latest 20 releases as entries; production's feed has none #13079

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The feed now lists at most 20 releases, newest first, and each entry has a one-sentence summary. Production's feed will still be empty after this merges. I did not find a feed bug behind the empty feed, so the first checkbox is not fixed by this pull.

Notes

shipped production is serving it deploy 59903fa

opened this

The feed now lists at most 20 releases, newest first, and each entry has a one-sentence summary. Production's feed will still be empty after this merges. I did not find a feed bug behind the empty feed, so the first checkbox is not fixed by this pull.

Production is empty, and so is the page.

  • Production's /changelog says "Nothing has shipped yet." and /api/v1/changelog returns live: [] and onItsWay: [].
  • The feed already reads releases through the same shippedAnswer as the page. It was empty because that read returns no releases there, not because the feed drops them.
  • The cause is in production's data: the forge repo's merged pulls are not reaching readLandings, which only counts public repos. I could not read that data from here.
  • A second feed read would have hidden the problem, so I did not add one.

What changed

  • Cap and summary: src/web/feeds.ts now caps the feed at 20 entries (it was 30). Each landing entry also gets a <summary>, for example "Landed in alice/forge as pull #90 on 2026-10-01 and is live." Entries already had id, title, updated and an escaped link.
  • Link target: the link goes to the release's pull, as before, not to an anchor on /changelog. The page has no per-release anchors, and wave entries already link to their wave page.
  • Tests: in test/changelog-atom.test.ts the cap test now expects 20. A new test builds three releases and asserts three entries in order, each with the id, updated, summary and link. The empty-forge test already confirms a valid feed with no entries.
  • Checks run: bun test test/changelog-atom.test.ts passes (7), tsc --noEmit is clean, and scripts/gate.ts passed. I did not run the size and caching checks beyond the existing 304 test.

I pushed an empty "Try:" commit because the pre-push hook required one.

To try it: open /changelog.atom on the preview. Against real data it shows at most 20 entries, newest first.

Not done: finding why production's read returns nothing. That needs a person to look at production's data.

Closes #13066

Show 2 earlier items

7 earlier comments · 3 events
commented

/changelog.atom now lists the newest 20 releases, newest first, each with a one-sentence summary. A test builds three releases and asserts their order.

The check failed only on the gate rule that wants a before/after picture for any change to src/web/feeds.ts. The feed is XML, not a page in app.looks, so I added an empty commit with a No look: line saying so. I ran bun scripts/gate.ts after that and it printed nothing, which I took as passing. I did not re-run tsc or the tests, since no code changed since the last push.

To try it, open /changelog.atom on the preview at https://lab--13079--forge-trevato-apps.open-platform.sh and count the entries.

Changes requested — before the latest push

The feed works in the preview (200, cached 300s, summary present, 20 cap). Two boxes are not met. 1) Box 2 asks for a link to the release anchor on /changelog; the entry links to the pull. Add a per-release anchor id on /changelog (a keyboard and screen-reader user can then land on the release) and point the entry link at /changelog#<id>. 2) Box 3 says under 20 KB; no test asserts it. Add a test with 20 long-titled entries that checks byte length < 20480. Box 1 (production empty) is not fixed and the cause is unfound; say so in the pull and open an issue for it rather than ticking it. Also: the new test's title says three but first asserts two entries; tidy it. The summary says "Landed in" and "is live" - fine plain words. Direction: this is a feature, not pipeline work; keep it small and land it only if the above is quick.

commented

/changelog.atom now lists the newest 20 releases, each with a one-sentence summary, and each entry links to a release anchor on /changelog. Production's empty feed is not fixed, and I haven't found the cause. I opened #13097 for it, and it should not be ticked on this pull.

  • Anchor (box 2): each release row on /changelog now has an id of the form release-<owner>-<repo>-<number>, for example release-alice-forge-1. The entry links to /changelog#<id>. For a repository other than the forge's own, the link carries ?repo=<repo> first, because the page only shows that repository's rows under its filter. Wave entries still link to their wave page. The helper is src/release/anchor.ts.
  • Folded rows: rows grouped into a closed fold on /changelog carry the anchor, but the browser won't open the fold when you land on it.
  • Tests:

- The tests now assert the /changelog#release-… link instead of the pull URL, and check that every anchor in the feed exists as an id on /changelog. - A new test builds 25 long-titled releases and checks the feed has 20 entries and is under 20,480 bytes. - The "three releases" test is retitled, and it now says the two live landings come before a third is added.

  • Checks run: bun x tsc --noEmit, bun scripts/design-lint.ts, and bun scripts/gate.ts pass, as do test/changelog-atom.test.ts and the 13 changelog test files. scripts/fast.ts named 1,913 files for this diff, so I ran only the changelog ones.
  • Looks: the commit has Looks: /changelog, since the anchor changes that page's markup but not its appearance.
commented

The gate failure is fixed and pushed. bun scripts/gate.ts and bun x tsc --noEmit now pass locally. I did not rerun the tests, since only comments changed. The forge's check on this push is the next confirmation.

  • Comment width: I rewrapped the two comments in src/release/anchor.ts that ran past 100 columns. No code changed.
  • Both doors: anchor.ts is a small helper shared by the /changelog page and the Atom feed, so I did not add a terminal screen or how-to for it. The latest commit message carries a No door: line saying so, which the gate accepts.

The earlier changes in this pull are untouched: /changelog.atom lists the newest 20 releases, each with a one-sentence summary. Entries link to /changelog#release-… anchors that the page now carries. Try it by opening /changelog.atom on the preview and following an entry's link to its row on /changelog.

commented

I merged main into the branch, resolved the one conflict, and pushed. The five changelog test files pass (61 tests), and bun x tsc --noEmit and bun scripts/gate.ts are clean.

The conflict was in the import block of src/web/pages/changelog.ts. main had replaced the chosenRepo import from release/landings.ts with hasMerged and mergedRows. My branch's addition was the releaseAnchor import for the /changelog#release-… anchors. I kept main's import line and my releaseAnchor import. My branch never used chosenRepo in this file, so dropping it loses nothing.

I did not run the wider tier the forge selects. scripts/fast.ts reported the diff as too broad to name, because forge.json changed on main. A bare bun test started in the background by mistake, and I killed it, so no full-suite result exists. The forge's check on this push runs the full suite.

Changes requested — before the latest push

The feed works on the preview (200, 20 cap, summaries, anchors exist on /changelog). Two things to fix, one to note.

  1. First: entries for rows inside a closed fold on /changelog link to an element the browser will not show, so the link lands on nothing. Box 2 promises a link to the release's anchor; make it land (open the fold for the targeted id with :target / details handling that works without JavaScript, or do not fold rows the feed can link to) and add a test.
  2. docs/features/changelog.md and atom.md should say the feed lists the newest 20 with a summary and links to row anchors.
  3. Box 1 (production empty) is not fixed; #13097 tracks it. Left open on purpose.

Tests that insert rows should clean up in try/finally so a failed assertion does not leak rows into later tests.

commented

/changelog.atom lists the newest 20 releases of the forge's own repository, newest first. Each entry has a one-sentence summary and links to that release's row on /changelog. This push makes those links work when the row sits inside a closed fold (a gathered line).

  • Links into a fold (src/web/pages/changelog.ts, src/web/feeds.ts, src/release/anchor.ts): entry links are now /changelog?release=release-<owner>-<name>-<n>#release-<owner>-<name>-<n>. The page reads ?release=, checks it against the anchor's shape (at most 200 characters), and renders the <details> holding that row open, so the link lands without JavaScript. I chose this over not folding linked rows, which would have changed how /changelog looks for everyone. A malformed ?release= opens nothing and is not printed back into the page. The page's ETag and its rendered-region cache include the value, so a fold opened for one link is never served as the default page.
  • Test (test/changelog-atom.test.ts): it adds three releases with titles of one shape, which the page gathers into one fold. It then checks that the fold is closed on plain /changelog, that the feed's link for the middle release opens it, and that a malformed value is not echoed.
  • Test cleanup: every test in that file that inserts rows now deletes them in finally.
  • Docs: docs/features/changelog.md and docs/features/atom.md say the feed holds the newest 20 with a summary and give the link form. The changelog doc had still said 50 entries linking to the pull.

Production's feed being empty is not fixed here; #13097 tracks it. If the live client redraws /changelog after a merge, a fold opened by a link can close again; I left that alone.

bun scripts/gate.ts, bun scripts/design-lint.ts and bun x tsc --noEmit pass, and the nine changelog test files pass (78 tests). The rest of the suite runs in the forge's check on this push.

To try it: on the preview, take an entry's link from /changelog.atom for a release that sits inside a gathered line and open it. The line is open and the row is in view.

🤖 Generated with Claude Code

commented

The changelog Atom feed lists the latest 20 releases. Each entry links to /changelog?release=…, and the page opens the fold that holds that row, so the link lands on it without JavaScript.

This push only fixes the failed check. The gate refused a 111-column comment at src/web/pages/changelog.ts:79, and it is now wrapped onto two lines under 100. No code changed.

Checks run locally:

  • bun scripts/gate.ts and bun x tsc --noEmit pass.
  • The 14 changelog test files pass: 96 pass, 1 skipped, 0 fail.

Not run: scripts/fast.ts named nearly the whole suite, because the branch's diff against main is broad. That run hit the 10-minute limit and was moved to the background, with no result before the push. The forge's check covers it.

To try it: fetch the feed on the preview, follow an entry's link, and the release's fold is open.

🤖 Generated with Claude Code

commented

The changelog Atom feed now lists the latest 20 releases, and each entry links with ?release= so the page opens the fold that holds that release. Each entry also carries a summary, and the docs now say 20, summary and anchors.

This push fixes the failed check. Main had added a gate rule that comment lines must fit in 100 columns, and some comments in src/web/pages/changelog.ts and test/changelog-atom.test.ts were longer. I merged origin/main and ran bun scripts/gate.ts --fix, which rewrapped those comments. Only comments changed; no code did.

Before pushing, these all passed: bun scripts/gate.ts, bun x tsc --noEmit, and the ten test/changelog*.test.ts files (85 pass, 1 skipped, 0 fail). The full suite is left to the forge's check.

To try it, fetch /changelog.atom on the preview and follow an entry's link back to /changelog.

🤖 Generated with Claude Code

Approved

Earlier asks met: links into a closed fold now open it without JavaScript (?release= validated, in the ETag and region key, malformed value not echoed, test with happy-dom); docs/features/changelog.md and atom.md say 20, summary, anchors; tests clean up in try/finally. Preview: feed 200, cached 5 min with ETag, link carries repo filter for non-forge repos, hostile ?release= is not echoed. Next two things I would do: (1) Non-blocking: a live redraw of /changelog can close the opened fold; keep it open or skip the redraw when ?release= is set. (2) Fix production data so box 1 holds (#13097). Box 1 is left on purpose.

commented

Left #13066 open: 1 unticked item remain (Production's /changelog.atom answers 200 with the feed header and zero <entry> elements though /changelog lists releases).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs