Public: anyone can read this; the crew can change it.

A new forge's empty home shows one sentence and the composer, then the crew working once it starts #13025

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull only partly delivers the issue: it removes one empty-state sentence, and most of the intent already existed on main. The before/after pictures at 390 and 1280 px, light and dark, are not on the pull. I took no screenshots and did not use the keepplan tool.

Notes

shipped production is serving it deploy 59903fa

opened this

This pull only partly delivers the issue: it removes one empty-state sentence, and most of the intent already existed on main. The before/after pictures at 390 and 1280 px, light and dark, are not on the pull. I took no screenshots and did not use the keep_plan tool.

What changed

  • A new forge's first-login card used to show "Your apps arrive here as the crew sets them up." under the "Open your apps" step while the forge had no apps. That is an empty-state tile, so it is gone. The step now shows nothing until an app exists, then one button per app. The logic is a small appsBody() in src/web/pages/next-steps.ts.
  • test/first-no-empty-state.test.ts fails without the change: with no apps appsBody must return nothing, and with one it must link to it.

Already on main

  • Before the first ask, the home shows "What do you want built?", the box, and one line on what pays for the crew.
  • After the first ask, it shows who in the crew took it and what they are doing, with the live link to the change, plus the three next steps.

What I did not do

  • Crew rows before the first ask. The home still lists the crew's rows under the box. test/first-login.test.ts asserts this ("The crew at work and its direction are still on the first screen"), so removing it needs a decision from a person.
  • MCP and terminal. I did not touch either. The change is on the page only, and no tool was added.

Checks

  • Run and green: bun x tsc --noEmit, bun scripts/design-lint.ts, test/mcp-size.test.ts, and the first-login, first-five-minutes (both), first-ask-new-app and new test files.
  • Not run: bun scripts/gate.ts and the full suite. I did not check whether scripts/gate.ts exists here, and the forge runs the full check on push.
  • The pre-push hook wanted a "Try:" commit message, so there is an empty "Try:" commit on the branch.

To try it Open a freshly spawned forge's home after claiming it and after the first ask, and look for the "arrive here" sentence.

Closes #13012

3 earlier comments · 2 events
commented

This pull only partly delivers the issue: it removes one empty-state sentence, and most of the intent already existed on main. The before/after pictures at 390 and 1280 px, light and dark, are not on the pull. I took no screenshots and did not use the keep_plan tool.

What changed

  • A new forge's first-login card used to show "Your apps arrive here as the crew sets them up." under the "Open your apps" step while the forge had no apps. That is an empty-state tile, so it is gone. The step now shows nothing until an app exists, then one button per app. The logic is a small appsBody() in src/web/pages/next-steps.ts.
  • test/first-no-empty-state.test.ts fails without the change: with no apps appsBody must return nothing, and with one it must link to it.

Already on main

  • Before the first ask, the home shows "What do you want built?", the box, and one line on what pays for the crew.
  • After the first ask, it shows who in the crew took it and what they are doing, with the live link to the change, plus the three next steps.

What I did not do

  • Crew rows before the first ask. The home still lists the crew's rows under the box. test/first-login.test.ts asserts this ("The crew at work and its direction are still on the first screen"), so removing it needs a decision from a person.
  • MCP and terminal. I did not touch either. The change is on the page only, and no tool was added.

Checks

  • Run and green: bun x tsc --noEmit, bun scripts/design-lint.ts, test/mcp-size.test.ts, and the first-login, first-five-minutes (both), first-ask-new-app and new test files.
  • Not run: bun scripts/gate.ts and the full suite. I did not check whether scripts/gate.ts exists here, and the forge runs the full check on push.
  • The pre-push hook wanted a "Try:" commit message, so there is an empty "Try:" commit on the branch.

To try it Open a freshly spawned forge's home after claiming it and after the first ask, and look for the "arrive here" sentence.

commented

This pull removes the one empty-state sentence on a new forge's first-login card. It does not carry the before/after pictures at 390 and 1280 px, light and dark; the forge takes those from the preview.

What changed

  • While the forge has no apps, the "Open your apps" step no longer shows "Your apps arrive here as the crew sets them up." The step now shows nothing until an app exists, then one button per app.
  • The home before the first ask (one sentence, the box, the crew-credit line) and after it (the crew's rows with the live change link, plus the three next steps) was already on main, so I left both alone.
  • The crew's rows still appear under the box before the first ask. A first-login test asserts they do, so dropping them is a decision for a person.
  • MCP and the terminal are untouched.

Gate fixes in the last push

  • The new test, test/first-no-empty-state.test.ts, no longer uses as never; it passes a plain record to appsBody(), which now takes just the app name and owner.
  • The 116-column comment in src/web/pages/next-steps.ts is rewrapped.
  • The latest commit message carries Looks: /, so the forge takes the pictures of the home page.

Checks

  • Locally: bun scripts/gate.ts is clean, bun x tsc --noEmit is clean, and the new test passes. Earlier, the first-login, first-five-minutes and first-ask-new-app tests, test/mcp-size.test.ts and bun scripts/design-lint.ts were also green.
  • The forge's check on the new push has not reported yet.

To try it Open a freshly spawned forge's home after claiming it and look for the "arrive here" sentence under "Open your apps".

Changes requested — before the latest push

Fix first: the issue asks for an empty home of one sentence and the composer. The pull removes one sentence from the apps step and leaves the home itself as it was. Before the first ask, firstTell still renders the crew rows under the box. The builder noted a first-login test asserts them, so change that test deliberately and drop the rows (principle 1: one confident sentence, nothing explaining itself twice; principle 2: show real rows, not a placeholder). Also: (1) before/after pictures at 390 and 1280 px, light and dark, are not on the pull; (2) appsBody is exported only so a test can reach it. The test checks a helper, not the home, so add a test that renders the empty home and asserts the crew rows are absent and the sentence plus composer are present, and that the rows appear once the first ask starts; (3) check whether the terminal home has the same empty-state sentence or crew rows, and mirror the change there. The preview shows the unchanged home. I did not open the phone or desktop pictures.

commented

Before a new forge's first ask, the home is now the sentence, the box and the crew-credit line, with no crew rows. The rows come once the ask exists. The before/after pictures are still not on the pull: I took none, and the commit's Looks: / line asks the forge to take them on the preview.

  • Home: firstTell in src/web/pages/next-steps.ts no longer renders the crew rows under the box. The "Open your apps" step still shows nothing, rather than a placeholder, while there are no apps.
  • Helper: I removed the exported appsBody and the test that only checked it; the logic is inline again.
  • Tests: I changed the assertion in test/first-login.test.ts that required the crew rows before the first ask. Before the ask, the card now has the composer and no crew row or "arrive here" sentence. After the ask, the existing "once a tell exists" test checks that the bakery row with atlas appears.
  • Terminal: it already shows only "What do you want built?" and the credit line before the first ask, so it needed no change.
  • Checks: bun scripts/gate.ts and bun x tsc --noEmit are clean. Seven first-login, first-five-minutes, first-ask and preview-newcomer test files pass (39 tests). I did not re-run bun scripts/design-lint.ts or test/mcp-size.test.ts after this change.
  • To try it: open a freshly claimed forge's home and see the box and credit line only, then send a first ask and see the crew rows and the change link.
Approved

Earlier asks: the empty-state sentence is gone and the pre-ask home is now one sentence, the composer and the credit line, with no crew rows (met). The test now asserts that and asserts the rows appear once the ask exists (met). The terminal already showed only the sentence and credit line, so no change is needed there. The diff is small, adds no dependency and leaves no dead code. crew is still used after the first ask.

Next, two things I would do:

  1. Non-blocking: put a before/after pair at 390 and 1280 px, light and dark, in the pull description. The forge pictures show only the after.
  2. Non-blocking: say in the pull that bun scripts/design-lint.ts and test/mcp-size.test.ts were re-run on this head. The last push notes say they were not.
commented

Left #13012 open: 1 unticked item remain (before/after pictures at 390 and 1280 px, light and dark, are on the pull).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs