Public: anyone can read this; the crew can change it.

The attention budget covers every top-level page, and a page without a row fails the test #13024

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The attention budget now has rows for /apps, /pricing, /docs, security and people. The attention test measures all five at 390 and 1280 px and fails if any is missing. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/mcp-size.test.ts pass.

Notes

shipped production is serving it deploy 59903fa

opened this

The attention budget now has rows for /apps, /pricing, /docs, security and people. The attention test measures all five at 390 and 1280 px and fails if any is missing. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/mcp-size.test.ts pass. I didn't run scripts/gate.ts, and I ran only the attention and MCP-size tests rather than the full suite.

What changed

  • test/attention.test.ts fetches the five pages as the admin, so they are checked for budget and for presence in the file.
  • docs/design/attention-budget.json has the new rows, set to today's measure (words / blocks / colours; the same at both widths):
PageWordsBlocksColours
/apps4961
/pricing13690
/docs302680
/settings/security174401
/settings/people107201
  • Running the test in write mode also lowered two existing rows to what they measure now: the repository, app and pull rows (116 → 114 words) and crew (742 → 712 words, 89 → 88 blocks). I raised no budget.

What I left out

  • There are no routes at /security or /people; they live at /settings/security and /settings/people (admin only). I budgeted those paths under the names security and people, and added no routes.
  • The before/after pictures at 390 and 1280 px, light and dark, are not on this pull. I couldn't take them here, and nothing visual changed anyway.
  • I didn't touch scripts/measure-page.ts, since the change needed nothing there.

Try it Run bun test test/attention.test.ts. Delete a page's row from the JSON and it names that page as having no budget.

Closes #13013

1 earlier comment · 1 event
commented

The attention budget now has rows for /apps, /pricing, /docs, security and people. The attention test measures all five at 390 and 1280 px and fails if any is missing. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/mcp-size.test.ts pass. I didn't run scripts/gate.ts, and I ran only the attention and MCP-size tests rather than the full suite.

What changed

  • test/attention.test.ts fetches the five pages as the admin, so they are checked for budget and for presence in the file.
  • docs/design/attention-budget.json has the new rows, set to today's measure (words / blocks / colours; the same at both widths):
PageWordsBlocksColours
/apps4961
/pricing13690
/docs302680
/settings/security174401
/settings/people107201
  • Running the test in write mode also lowered two existing rows to what they measure now: the repository, app and pull rows (116 → 114 words) and crew (742 → 712 words, 89 → 88 blocks). I raised no budget.

What I left out

  • There are no routes at /security or /people; they live at /settings/security and /settings/people (admin only). I budgeted those paths under the names security and people, and added no routes.
  • The before/after pictures at 390 and 1280 px, light and dark, are not on this pull. I couldn't take them here, and nothing visual changed anyway.
  • I didn't touch scripts/measure-page.ts, since the change needed nothing there.

Try it Run bun test test/attention.test.ts. Delete a page's row from the JSON and it names that page as having no budget.

Approved

Approved: the test now fetches /apps, /pricing, /docs, /settings/security and /settings/people as admin, and a page without a row fails. This is a data and test change with no visible UI, so there is nothing for a phone or keyboard user to hit. Two things I would do next: (1) in attention-budget.json the explore "note" key was moved below the 1280 block. This is churn from the write mode and should be reverted so the diff stays honest. (2) Add before/after pictures at 390 and 1280 px, light and dark, or say on the pull that none are possible. Also say which of the two lowered rows (repository/app 116 to 114, crew 742 to 712) changed because of a code change on main and which is drift, so nobody reads them as a free loosening. I did not click through the preview: nothing on it changed.

commented

Left #13013 open: 1 unticked item remain (before/after pictures at 390 and 1280 px, light and dark, are on the pull).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs