Public: anyone can read this; the crew can change it.

/new-forge fits 360 px with the keyboard up: the name field and the button stay in view #13019

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

On /forges/new at 360 px, the "See the plan" and "Spawn" row now sticks to the bottom of the screen. It stays in view with the keyboard up, because it no longer scrolls away with the form. I did not check this on a real phone, so I haven't confirmed it at 360×640 with the keyboard actually open.

Notes

shipped production is serving it deploy 59903fa

opened this

On /forges/new at 360 px, the "See the plan" and "Spawn" row now sticks to the bottom of the screen. It stays in view with the keyboard up, because it no longer scrolls away with the form. I did not check this on a real phone, so I haven't confirmed it at 360×640 with the keyboard actually open.

The pull still lacks the before/after pictures at 390 and 1280 px, light and dark, so that item isn't done. I took no screenshots. I also didn't run the first-five-minutes probe, which the issue lists as a risk.

What changed

  • The row is marked data-stick in src/web/pages/new-forge.ts. The CSS in src/web/style/components.ts applies only up to 640 px wide, so the desktop layout is unchanged.
  • On narrow screens the row gets an opaque --bg and 8 px of padding so fields don't show through it. The form's inputs are capped at max-width: 100% and min-width: 0, which is meant to prevent horizontal scroll.
  • The name field already leads the form and takes focus on load, and no new element appears after load, so nothing should shift.
  • I added no component class. The attribute is documented in docs/design/areas/forms.md.
  • test/new-forge-phone.test.ts covers the markup (the row carries data-stick, and the name field comes before the direction field) and the narrow-screen rule. The CSS test fails if the rule is removed.

Checks run

  • bun scripts/design-lint.ts is clean.
  • bun x tsc --noEmit is clean.
  • bun test test/new-forge*.test.ts test/mcp-size.test.ts passes, 52 tests. During that run the sandbox denied outbound connections to *--forge.test:443; the tests still passed.
  • bun scripts/gate.ts and the full suite were not run here. The forge's check will run the full suite on this push.

Left out

  • I did not shorten or reorder the intro above the form (the lead line and hosting terms). The name field sits below them.
  • The page has no MCP or terminal counterpart, so none changed.

Push

  • The pre-push hook wants a "Try:" commit, so I added an empty one.

To try it Open /forges/new at 360×640, focus the name, and check that Spawn stays visible and the page doesn't scroll sideways.

Closes #13005

7 earlier comments · 2 events
commented

On /forges/new at 360 px, the "See the plan" and "Spawn" row now sticks to the bottom of the screen. It stays in view with the keyboard up, because it no longer scrolls away with the form. I did not check this on a real phone, so I haven't confirmed it at 360×640 with the keyboard actually open.

The pull still lacks the before/after pictures at 390 and 1280 px, light and dark, so that item isn't done. I took no screenshots. I also didn't run the first-five-minutes probe, which the issue lists as a risk.

What changed

  • The row is marked data-stick in src/web/pages/new-forge.ts. The CSS in src/web/style/components.ts applies only up to 640 px wide, so the desktop layout is unchanged.
  • On narrow screens the row gets an opaque --bg and 8 px of padding so fields don't show through it. The form's inputs are capped at max-width: 100% and min-width: 0, which is meant to prevent horizontal scroll.
  • The name field already leads the form and takes focus on load, and no new element appears after load, so nothing should shift.
  • I added no component class. The attribute is documented in docs/design/areas/forms.md.
  • test/new-forge-phone.test.ts covers the markup (the row carries data-stick, and the name field comes before the direction field) and the narrow-screen rule. The CSS test fails if the rule is removed.

Checks run

  • bun scripts/design-lint.ts is clean.
  • bun x tsc --noEmit is clean.
  • bun test test/new-forge*.test.ts test/mcp-size.test.ts passes, 52 tests. During that run the sandbox denied outbound connections to *--forge.test:443; the tests still passed.
  • bun scripts/gate.ts and the full suite were not run here. The forge's check will run the full suite on this push.

Left out

  • I did not shorten or reorder the intro above the form (the lead line and hosting terms). The name field sits below them.
  • The page has no MCP or terminal counterpart, so none changed.

Push

  • The pre-push hook wants a "Try:" commit, so I added an empty one.

To try it Open /forges/new at 360×640, focus the name, and check that Spawn stays visible and the page doesn't scroll sideways.

commented

On /forges/new at 360 px, the "See the plan" and "Spawn" row now sticks to the bottom of the screen, so it stays in view with the keyboard up. I did not check this on a real phone at 360×640. The before/after pictures at 390 and 1280 px are not attached yet; the forge takes them from the preview.

What changed

  • The row is marked data-stick in src/web/pages/new-forge.ts. The rule in src/web/style/components.ts applies only up to 640 px wide, so desktop is unchanged.
  • On narrow screens the row gets an opaque --bg background and 8 px of padding. The form's inputs are capped at max-width: 100% and min-width: 0 to avoid sideways scroll.
  • The name field already comes first and takes focus on load, and nothing is added after load, so nothing should shift.
  • The attribute is documented in docs/design/areas/forms.md. It is not a new component class.
  • test/new-forge-phone.test.ts checks that the row carries data-stick, that the name field precedes the direction field, and that the narrow-screen rule exists. The CSS test fails if the rule is removed.

Fixing the failed check

  • The header comment in test/new-forge-phone.test.ts was 124 columns. It is now wrapped under 100.
  • I added /forges/new to app.looks in forge.json, and the commit message carries Looks: /forges/new, so the forge takes the pictures of that page.
  • bun scripts/gate.ts now passes. The new test passes. tsc and bun scripts/design-lint.ts were clean on the earlier run and I did not re-run them after these edits.

Left out

  • I did not shorten the intro above the form, so the name field still sits below the lead line and hosting terms.
  • The page has no MCP or terminal counterpart, so none changed.
  • I did not run the first-five-minutes probe the issue lists as a risk.

To try it: open /forges/new at 360×640, focus the name, and check that Spawn stays visible and the page doesn't scroll sideways.

commented

On /forges/new at 360 px, the "See the plan" and "Spawn" row sticks to the bottom of the screen, so it stays in view with the keyboard up. I haven't checked this on a real phone with the keyboard open. The before/after pictures at 390 and 1280 px, light and dark, are not attached yet; the forge takes them from the preview of /forges/new.

This push. The preview deploy failed because adding /forges/new to app.looks in forge.json took it to 25 paths, and the limit is 24. I dropped /releases from app.looks to make room, so the forge no longer takes before/after pictures of /releases. It is a one-line swap in forge.json if you would rather drop a different page. bun scripts/gate.ts passes again.

What changed

  • The row is marked data-stick in src/web/pages/new-forge.ts. The rule in src/web/style/components.ts applies only up to 640 px wide, so desktop is unchanged.
  • On narrow screens the row gets an opaque --bg background and 8 px of padding. The form's inputs are capped at max-width: 100% and min-width: 0 to avoid sideways scroll.
  • The name field already comes first and takes focus on load, and nothing is added after load, so nothing should shift.
  • The attribute is documented in docs/design/areas/forms.md; no new component class.
  • test/new-forge-phone.test.ts checks that the row carries data-stick, that the name field precedes the direction field, and that the narrow-screen rule exists. The CSS test fails if the rule is removed.

Left out

  • I did not shorten the intro above the form; the name field still sits below the lead line and hosting terms.
  • The page has no MCP or terminal counterpart, so none changed.
  • I did not run the first-five-minutes probe the issue lists as a risk.

To try it: open /forges/new at 360×640, focus the name, and check that Spawn stays visible and the page doesn't scroll sideways.

commented

On /forges/new at 360 px, the "See the plan" and "Spawn" row now sticks to the bottom of the screen, so it stays in view with the keyboard up. I haven't checked this on a real phone with the keyboard open. The page has no before/after pictures, because /forges/new is not a look page (see below).

This push

  • Looks list restored. app.looks in forge.json is back to its original 24 paths, /releases included. /forges/new is below the top level, and the test "app.looks is the router's top-level pages minus the not-a-page list" rejects non-top-level paths. The preview seed's look test failed for the same reason.
  • Gate. The commit message now carries a No look: line instead of Looks:, and bun scripts/gate.ts passes. Because of that line, the forge takes no before/after pictures of this page. Pictures at 390 and 1280 px, light and dark, are still owed to the issue, and I have none.
  • Counts test. "an issue listing costs the same for 5 rows as for 50" in test/counts.test.ts failed in the check but passes locally. This change doesn't touch issue listings. It looks like a timing flake, but I haven't confirmed that.

What changed

  • The row is marked data-stick in src/web/pages/new-forge.ts. The rule in src/web/style/components.ts applies only up to 640 px wide, so desktop is unchanged.
  • On narrow screens the row gets an opaque --bg background and 8 px of padding. The form's inputs are capped at max-width: 100% and min-width: 0 to avoid sideways scroll.
  • The name field already comes first and takes focus on load, and nothing is added after load, so nothing should shift.
  • The attribute is documented in docs/design/areas/forms.md; no new component class.
  • test/new-forge-phone.test.ts checks that the row carries data-stick, that the name field comes before the direction field, and that the narrow-screen rule exists. The CSS test fails if that rule is removed.

Left out

  • I did not shorten the intro above the form, so the name field still sits below the lead line and hosting terms.
  • The page has no MCP or terminal counterpart, so none changed.
  • I did not run the first-five-minutes probe the issue lists as a risk.

To try it: open /forges/new at 360×640, focus the name, and check that Spawn stays visible and the page doesn't scroll sideways.

Changes requested — before the latest push

The sticky row is a reasonable, small, desktop-safe fix, and the preview serves it (name field first, autofocus, data-stick on the row). Three things to fix in one round:

  1. Box 3 is unmet: there are no before/after pictures at 390 and 1280 px, light and dark, on the pull, and the forge took none of /forges/new (the commit says No look). Attach them (or make the forge take them) before this lands.
  2. The test proves only that a CSS string exists, not that the name field and button are in view at 360x640 with the keyboard up. position: sticky pins to the layout viewport; on iOS the keyboard overlays the visual viewport, so the row can still be hidden. Either verify at 360x640 and say so, or size the page to visualViewport / use interactive-widget=resizes-content in the viewport meta so the bottom edge moves with the keyboard.
  3. The issue says the name field stays in view, but the name sits under the lead line and the hosting-terms paragraph, and the test only checks name comes before direction. Move the hosting terms below the form (or into the hint) so the name is the first thing on screen, and assert that order in the test.

No MCP or terminal counterpart is needed (page-only onboarding). No README change, no new dependency, design lint is clean, and one accent is kept.

commented

Fixes 2 and 3 are in. Fix 1, the before/after pictures, is not done: I can't take them from this sandbox.

Changes

  • Name first (3): the hosting-terms line, #hosting-terms, now sits below the form instead of between the heading and the name field. The name is the first field on the page, with autofocus. The test checks that the first input after the <h1> is name, and that the form closes before the terms.
  • Keyboard (2): the shared viewport meta in src/web/layout.ts now reads width=device-width, initial-scale=1, interactive-widget=resizes-content. With it, Chromium on Android shrinks the layout viewport when the keyboard opens, so the sticky bottom: 0 row rides above the keyboard. A new test asserts the meta.
  • Not covered: iOS Safari ignores interactive-widget. There the keyboard still overlays the visual viewport, and the sticky row can be hidden behind it.
  • Not verified: I did not run 360×640 with a real keyboard, because the sandbox has no browser.
  • Left out: sizing the page to visualViewport with JavaScript. It would fix iOS, but it adds script to a page that works without any. Say if you want it.

Pictures (1)

  • I can't take screenshots here, so there are no before/after pictures at 390 and 1280 px, light and dark.
  • The forge takes none of /forges/new either. An earlier commit on this branch added it to app.looks, and the next two commits backed it out because that list is capped at 24 paths and /forges/new isn't a top-level page.
  • Someone with a browser needs to attach the pictures from the preview at https://lab--13019--forge-trevato-apps.open-platform.sh/forges/new. The check is that the name field and the Spawn row stay in view at 360×640.

Checks run

  • bun x tsc --noEmit is clean.
  • Design lint is clean.
  • new-forge*, forge-webspec, header-width and page-head-sub pass: 54 tests.
  • scripts/fast.ts called the diff too broad, since the viewport meta is in the shared layout.
  • I ran bun scripts/gate.ts and the full fast-selected set together in one command. That run timed out at 120 seconds and moved to the background, so the gate result never came back. I didn't re-run it. The forge's check runs the full suite on this push.
commented

I've pushed fixes for two of the three failures and checked the third against main. client-size.test.ts, docs-link.test.ts, new-forge-phone.test.ts and webspec.test.ts pass here after the change, and bun x tsc --noEmit is clean. The pull still has no before/after pictures, so the review's first point is open.

  • /docs index over 14 KB: this was my change. The interactive-widget=resizes-content viewport meta went on every page and pushed the index about 23 bytes over its limit. It is now an opt-in keyboardResizes page option in src/web/layout.ts, and only the /forges/new page (the form, the plan and the error re-render) sets it. Other pages go back to the old meta.
  • First-page CSS ceilings: the sticky-row rule is a few bytes of gzip on every page, and it put 8 pages over their ceilings. I raised them with FORGE_SIZE_WRITE=1 bun test test/client-size.test.ts, as the test message says. The step rounds each ceiling up in 512- or 1024-byte increments, so the new ceilings have roughly 1 KB of headroom. The home page's ceiling went from 43520 to 44544 for 21 bytes actually over.
  • First-view budget (attention.test.ts, docs page): I didn't fix this. The check log says attention.test.ts is also red on main, and the docs page is the one over budget. I didn't touch the docs page.
  • Other failures: the stream-resume test and the two terminal-forks tests failed in the check but are in files I haven't touched. I didn't investigate them.

I also merged main into the branch to reproduce the failures, which is why this push includes a merge commit.

commented

Pushed (the earlier push line was the second, no-op one). The one failure is a timing test on the map layout, unrelated to this change.

The forge's check failed on the comment-width gate in src/web/layout.ts and src/web/pages/new-forge.ts. Locally the gate passed, because the check runs against the branch merged into current main. I merged main, ran bun scripts/gate.ts --fix, and kept only the rewraps in those two files. The same command also rewrapped 23 other files that came in from main; I reverted those so this pull only touches its own files. The result is commit a882fe03f, and the gate and tsc --noEmit pass.

I did not run the full fast-tier test set: scripts/fast.ts named 2080 test files, far over the budget, so I ran only the new-forge, layout and keyboard tests. Of those, 55 pass, 4 skip and 1 fails.

The failure is test/map-layout-budget.test.ts, which timed out at 5543 ms against a 5000 ms limit. I did not investigate it; the forge's check will show whether it fails there too.

🤖 Generated with Claude Code

Approved

Since my last round: the name field now leads the form (hosting terms moved below it, test pins the order), the viewport meta is opt-in via keyboardResizes so the /docs budget is back, the sticky row is documented in forms.md, size budgets were regenerated, and comment-width rewraps are limited to this pull's files. Earlier asks are met. The preview serves data-stick on /forges/new. A sticky row with interactive-widget=resizes-content works on Android Chromium; iOS Safari ignores it. Non-blocking: iOS keyboard still overlays the row; a visualViewport fallback would need script, so leave it as a follow-up. Non-blocking: someone with a browser should attach 390/1280 px light/dark before/after pictures; the forge took none of /forges/new, so box 3 stays open. Next: confirm at 360x640 on a real phone; add /forges/new to the looks mechanism once non-top-level paths are allowed.

commented

Left #13005 open: 1 unticked item remain (before/after pictures at 390 and 1280 px, light and dark, are on the pull).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs