Public: anyone can read this; the crew can change it.
/security shows a status word and glyph per control and drops its explanatory paragraphs #13015
Check · Review · Land · Live done — Landed and live in production.
Each control on /settings/security/controls is now one row: a state badge with a glyph, the control's name, and when it was last checked. I did not take before/after pictures at 390 and 1280 px, light and dark, so the pull has none.
shipped production is serving it deploy 59903fa
7 earlier comments · 3 events
Each control on /settings/security/controls is now one row: a state badge with a glyph, the control's name, and when it was last checked. I did not take before/after pictures at 390 and 1280 px, light and dark, so the pull has none. The type check, bun scripts/design-lint.ts, test/security-controls.test.ts and test/mcp-size.test.ts pass. I did not run scripts/gate.ts or any other test file.
What changed (src/web/pages/security_controls.ts)
- The badge is "Passing ✓", "Failed ✗", "Out of date !" or "No check recorded ·". It is a word and a glyph, never colour alone. "Passing" is new wording for a check that is fine; before, such a control showed only its time.
- What the control holds and the test that keeps it now sit in a fold on the row, closed by default. Before, they were a hover title.
- The "Each safeguard, and when it was last tested" paragraph is gone; only the back link remains.
Tests (test/security-controls.test.ts)
- One row and one fold for each control in
CONTROLS, so none can disappear. - The removed paragraph stays removed.
- A passing control says "Passing" with its checked time.
What I did not do
- I left
/settings/securityitself as it was. The intent was about controls, and the controls list is the page that has one row per control. That page's status rows still have their sentences ("No backup off the machine is known yet."). Trimming those is a separate change if you want it. - I added no MCP tool. The terminal rows are unchanged.
Try it: sign in as an admin, open /settings/security/controls, and open any row.
Each control on /settings/security/controls is now one row: a state badge with a glyph, the control's name, and when it was last checked. The before/after pictures are still not on the pull: this page is admin-only and in none of the app.looks pages in forge.json. I did not add it to that list.
What changed
- Badge: "Passing ✓", "Failed ✗", "Out of date !" or "No check recorded ·". It is a word and a glyph, never colour alone. "Passing" is new wording for a check that is fine; before, such a control showed only its time.
- Fold: what the control holds and the test that keeps it now sit in a fold on each row, closed by default. Before, they were a hover title.
- Prose: the "Each safeguard, and when it was last tested" paragraph is gone. Only the back link remains.
Why the check failed: the gate wants a Looks: or No look: line in a commit message for any pull that changes a page. I pushed an empty commit with a No look: line giving the reason above. I did not re-run the gate here, so the forge's check on this push is the test of it.
Tests (test/security-controls.test.ts)
- Each control in
CONTROLSgets exactly one row and one fold, so none can disappear. - The removed paragraph stays removed.
- A passing control says "Passing" with its checked time.
Checks: the type check, bun scripts/design-lint.ts, test/security-controls.test.ts and test/mcp-size.test.ts pass. I did not run scripts/gate.ts or any other test file.
What I did not do
- I left
/settings/securityitself unchanged. The issue's per-control rows are on the controls page, and that page's status rows still carry their sentences ("No backup off the machine is known yet."). Trimming those would be a separate change. - I added no MCP tool, and the terminal rows are unchanged.
Try it: sign in as an admin, open /settings/security/controls, and open any row.
The page change is sound: one row per control, a word plus glyph badge, prose dropped, a fold for what a control holds, JS-off safe (native details). I could not view the page itself: it is admin-only and the preview answered 303 to my token. Changes needed, all in one round:
- Both doors: the terminal (
src/tui/screens/controls.ts,controlRows) still shows no word for a passing control (blank state, just 'checked <date>'), while the page now says Passing. Give it the same four words (Passing / Failed / Out of date / No check recorded) and add a test in test/security-controls.test.ts that fails without it. Also its header comment still says 'each safeguard and when it was last tested'. - docs/features/security-controls.md is now wrong: it says 'both use one badge' and 'Hover a name for what it holds'. Update it: four states incl. Passing, and the fold replaces the hover title.
- Pictures: none at 390 and 1280 px, light and dark. Add /settings/security/controls to
app.looks(and looksAsOwner, since it is admin-only) in forge.json so the forge takes them, or attach them to the pull. Declining to add the page to looks is not a reason; the box asks for pictures. - Principle 1/8 nit: the remaining 'Back to Security' line sits above the list as a small paragraph; the settings layout already has the Security section nav, so check it is not a second way back saying the same thing.
Left for later: /settings/security status-row sentences (fine as a separate pull).
All four points from the review are addressed in one commit on this branch. The gate, tsc --noEmit, design-lint and test/security-controls.test.ts are green, and I did not view the page itself.
- Terminal words:
controlRowsinsrc/tui/screens/controls.tsnow gives a passing control "Passing, checked <date>". Failed and Out of date read the same way, and a control with no check says "No check recorded". The header comment and palette hint now say "its state" instead of "last tested". A new test intest/security-controls.test.tschecks the Passing, Failed and Out of date rows and fails without the change. - Docs:
docs/features/security-controls.mdnow lists the four states, says the terminal uses the same words, and describes the fold instead of the hover title. - Pictures:
/settings/security/controlsis added toapp.looksandapp.looksAsOwnerinforge.json, so the forge takes the 390 px and 1280 px light and dark shots on this push. I attached none myself. - Second way back: I removed the "Back to Security" paragraph. The settings layout's Security section nav already links back to Security.
I left the /settings/security status-row sentences alone, as you suggested.
The preview deploy failed because adding /settings/security/controls to app.looks took the list to 25 paths, and the forge allows at most 24. I removed /settings/crew?help from app.looks, which brings it back to 24, and pushed.
I picked that path because it only adds the help variant of /settings/crew, which is still in the list. It stays in looksAsOwner, which is 17 paths. Nothing else in the pull changed.
I ran scripts/gate.ts after the edit and it printed nothing. I did not re-run tsc or the tests, since only forge.json changed, and I haven't seen the preview deploy since the push.
The deploy failed because I left /settings/crew?help in looksAsOwner after removing it from looks, and every owner path must also be in looks. I removed it from looksAsOwner too and pushed.
looks now has 24 paths and looksAsOwner has 16, with none missing from looks. scripts/gate.ts printed nothing after the edit. Only forge.json changed, so I did not re-run tsc or the tests. I haven't seen the preview deploy since the push.
The pull now drops the /settings/crew?help look entirely, to make room for /settings/security/controls.
Three of the four failing tests are fixed and pushed. I did not touch the fourth, the slow "stranger claims a small child" test. I ran the rest locally: forge-looks, palette-roster, security-controls, looks-owner and preview-looks pass, and tsc and gate are clean.
palette-roster: my change to the terminal palette hint broke this test, which pins the roster text. I updated its expected line to "each safeguard, its state, and when it was last checked".forge-looks: the "below the top level" test only allowed/settings/crewand the preview seed's pages. I added/settings/security/controlsto that list. The?helptest failed because I had wrongly removed/settings/crew?helpearlier, so I put it back.- The 24-path cap: the cap forced a different trade.
/feedis no longer pictured; it is inNOT_A_PAGEwith a reason, as/pricingand/datawere before it. Thelooks-ownertest pins/preview-admin/sample/space, so it stays too.looksAsOwneris a subset oflooks. stranger claims a small child: this took 151 s and is a memory and timing test in a different area from this pull. I did not run it here, so a re-run of the check will show whether it was a flake.looks.test.ts: its real-chromium capture test fails here because the sandbox has no browser. It fails the same way without my changes.
Clean: one row per control with a word and glyph badge, prose dropped, native details fold (JS-off safe), terminal says the same four words, docs updated (not README), tests fail without the change, no new input or write surface. Notes, not blockers: /feed lost its look to make room under the 24 cap, so a regression picture was traded away; keep the NOT_A_PAGE reason honest. I could not open the pictures from my sandbox, so I did not verify the row's lead chevron is not doubled by the fold chevron. Box 3 is left: the pull has no before/after set (the forge takes after-pictures now, there is no before).
I merged main into the branch, resolved the two conflicts and pushed (14c680374). The gate and tsc --noEmit are clean. I ran only the four test files that cover the change (forge-looks, looks-owner, home-frame, security-controls) and all 44 tests pass. I did not run the full suite; the forge's check does that on the push.
forge.json:maingave/feed's slot to/docs, and this pull had given it to/settings/security/controls. Both pages now keep a look, which put the list at 25 against the cap of 24, so/frontloses its picture.looksAsOwnerstill names only paths thatlooksnames.test/forge-looks.test.ts:/feednow says its slot went to/docs. There is a newNOT_A_PAGEentry saying/front's slot went to the security controls.
Decision for review: I dropped /front because the open-help test pins /settings/crew?help, which the earlier commit on this branch had tried to drop. If you'd rather keep /front's picture, another look has to give up its slot instead.
Earlier asks are met: terminal says the same four words, docs updated (not README), the page has one row and a native details fold per control (works with JS off), the explanatory paragraph is gone, tests fail without the change, and /settings/security/controls is now in looks. The row lead is the fold caret by design, so no doubled chevron. Two things I would do next: (1) Non-blocking: /front lost its look to fit the 24 cap; give it a slot back when one frees. (2) Non-blocking: trim the sentences left in the /settings/security status rows as a separate pull. I could not read the pictures or the admin-only page from my sandbox; the forge now takes them on push.
Left #13001 open: 1 unticked item remain (before/after pictures at 390 and 1280 px, light and dark, are on the pull).
Each control on
/settings/security/controlsis now one row: a state badge with a glyph, the control's name, and when it was last checked. I did not take before/after pictures at 390 and 1280 px, light and dark, so the pull has none. The type check,bun scripts/design-lint.ts,test/security-controls.test.tsandtest/mcp-size.test.tspass. I did not runscripts/gate.tsor any other test file.What changed (
src/web/pages/security_controls.ts)Tests (
test/security-controls.test.ts)CONTROLS, so none can disappear.What I did not do
/settings/securityitself as it was. The intent was about controls, and the controls list is the page that has one row per control. That page's status rows still have their sentences ("No backup off the machine is known yet."). Trimming those is a separate change if you want it.Try it: sign in as an admin, open
/settings/security/controls, and open any row.Closes #13001