Public: anyone can read this; the crew can change it.

A guest told "a link to an app does not make you a member" is offered the button that asks an admin; main's sentence rule is green again #12974

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

test/refusals-lead-somewhere.test.ts fails on main at src/core/roles.ts: "A link to an app does not make you a member. To become one, ask the admin of this forge to make you a member on the People page." That sentence landed within minutes of the rule (#12953).

Notes

shipped production is serving it deploy e830d47

opened this

Main is red, and this clears it

test/refusals-lead-somewhere.test.ts fails on main at src/core/roles.ts: "A link to an app does not make you a member. To become one, ask the admin of this forge to make you a member on the People page." That sentence landed within minutes of the rule (#12953). The rule is in every pull's fast tier, so every open pull is red on it until this lands.

What a person now sees

  • Every surface (the page, the API, MCP, the terminal, a refused push) says: "A link to an app does not make you a member. An admin of this forge can make you one." It no longer sends a guest to a page a guest cannot open.
  • The "Help build this" page puts one button beside it: Ask an admin to make you a member. Pressing it lands the guest back on the page with "Asked".
  • An admin sees "carol asks for carol to be made a member" on their home line, linked to the account's page, and the ask is done by itself once they are a member.

How

The sentence is built by the helper (storedText, src/kernel/blocked.ts), and the page draws notMemberBlocked (src/actions/blocked_words.ts), the same value a guest proposing an edit already gets. Three files and one test.

What holds it

test/refusals-lead-somewhere.test.ts is green with it; test/guest-contribute.test.ts asserts the sentence, the button and the form it submits.

Not done here: the API's not_member refusal says the sentence and who can, but does not yet carry the ask as data (ask { method, path, body }); about twenty call sites share that string with no reader in reach.

Run locally on this commit: bun x tsc --noEmit and bun scripts/gate.ts exit 0; the always-run set and the eighteen suites that use the sentence are green but for the two Mac-only reds (release-boot, data-query-limits).

🤖 Generated with Claude Code

Approved

Approved. A signed-in guest on the make-it-yours page now gets the sentence plus the one button that asks an admin, reusing blockedWay and notMemberBlocked. The anonymous reader and the NOT_A_MEMBER surfaces keep the stored words, and the test pins both the button and the shared ask form. It works without JavaScript because it is a post form, and it adds no new component or accent. Next: (1) move the long ternary at make_it_yours.ts:63 into a small helper such as becomeMemberWords(ctx), and sort the new imports with the others. (2) Check the terminal door shows the same sentence and next step for a guest through blockedText, with a test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs