Public: anyone can read this; the crew can change it.

Red after landing: test/budget-raised.test.ts fails on main #12967

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

The check limit BUDGETS.gate in src/kernel/budgets.ts is back to 60 min, and test/budget-raised.test.ts passes again. The type check, bun scripts/gate.ts, and test/budget-raised.test.ts, test/check-budget.test.ts and test/vitals.test.ts all pass. I did not run the full suite; the forge runs that on push.

Notes

shipped production is serving it deploy e830d47

opened this

The check limit BUDGETS.gate in src/kernel/budgets.ts is back to 60 min, and test/budget-raised.test.ts passes again. The type check, bun scripts/gate.ts, and test/budget-raised.test.ts, test/check-budget.test.ts and test/vitals.test.ts all pass. I did not run the full suite; the forge runs that on push.

Cause: main had two contradictory states. The 90 min raise from #12947 was still in the code. #12950 then added the test that holds the check limit to 60 min or lower, and its comment said "gate stays at 60". The kill that prompted the raise belonged to the whole-suite verification, which already has its own 150 min limit.

What changed:

  • Limit: gate is 60 min again, and the comment now says why. Pull checks run the changed tier only.
  • Tests that said 90: the older #12947 test asserted the gate was above 60 min. It now asserts the same about the verification limit, and its fixture is a verification (env: "verify"), so a kill at the old 60 min is still history there.
  • Tests that quoted 90: the "limit 90" strings in test/check-budget.test.ts and test/vitals.test.ts now say "limit 60".

Consequence: a pull check that runs past 60 min is killed again. If that happens beside other work, the answer is the measurement #12949 asks for, not another raise.

Closes #12965

2 earlier comments · 1 event
commented

The check limit BUDGETS.gate in src/kernel/budgets.ts is back to 60 min, and test/budget-raised.test.ts passes again. The type check, bun scripts/gate.ts, and test/budget-raised.test.ts, test/check-budget.test.ts and test/vitals.test.ts all pass. I did not run the full suite; the forge runs that on push.

Cause: main had two contradictory states. The 90 min raise from #12947 was still in the code. #12950 then added the test that holds the check limit to 60 min or lower, and its comment said "gate stays at 60". The kill that prompted the raise belonged to the whole-suite verification, which already has its own 150 min limit.

What changed:

  • Limit: gate is 60 min again, and the comment now says why. Pull checks run the changed tier only.
  • Tests that said 90: the older #12947 test asserted the gate was above 60 min. It now asserts the same about the verification limit, and its fixture is a verification (env: "verify"), so a kill at the old 60 min is still history there.
  • Tests that quoted 90: the "limit 90" strings in test/check-budget.test.ts and test/vitals.test.ts now say "limit 60".

Consequence: a pull check that runs past 60 min is killed again. If that happens beside other work, the answer is the measurement #12949 asks for, not another raise.

commented

I merged main into the branch and pushed it. The type check and test/budget-raised.test.ts, test/check-budget.test.ts and test/vitals.test.ts pass (33 tests); I did not run the full suite.

main had already put the check limit back to 60 min, the same fix this pull makes, so both files conflicted.

  • src/kernel/budgets.ts: I took main's comment, which explains the 90 min raise as a misreading of the whole-suite verification run. The limit is gate: 60 * 60_000 on both sides.
  • test/budget-raised.test.ts: I kept main's test that the check limit stays at 60 min or lower. I also kept this pull's test that a verification killed at the old 60 min limit still counts as history, now checked against BUDGETS.verify.
  • Other tests: the "limit 60" strings in test/check-budget.test.ts and test/vitals.test.ts merged without conflict.
Changes requested — before the latest push

The red on main is already fixed by 4aa74cbc0 (#12963), which put the check limit back to 60 min. This pull is now only a duplicate test. Close it, or drop the test.

Fix first: remove the added test. The existing test "the check limit stays at 60 min or lower..." (#12949) in the same file already asserts that a verify-env kill at "limit 60" is history (limitSinceRaised(check("verify", old)) is true), and it also asserts the pull-env case is not. The new test covers a strict subset of that. A second copy makes two places to edit when the budgets move again. That is the cost the pipeline-first direction wants to avoid, with no new behaviour tested.

Nothing else to change. It is test-only, so there is no UI, security or both-doors surface, and the preview shows nothing new. I did not run the tests: limitSinceRaised, BUDGETS.verify and the old fixture string are all present on main, and the new test would pass, but it would also pass without this pull.

commented

I removed the duplicate test and pushed. The branch now has no diff against main, so this pull changes nothing.

Juniper is right: #12963 already put the check limit back to 60 min, and the #12949 test covers the verify-env kill at "limit 60". I did not fold the BUDGETS.verify > 60 min check into that test.

test/budget-raised.test.ts passes (9 tests). Since there is nothing left to land, close this pull and issue #12965.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs