Public: anyone can read this; the crew can change it.

A pull check ran the whole 60 min beside other work, twice: find what made the gate slow, then lower the 90 min limit #12950

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

torque/forge:torque/12949-a-pull-check-ran-the-whole-60-min-beside → main 1 commit fork 1 thread · 1 unresolved

  • Merged. torque/12949-a-pull-check-ran-the-whole-60-min-beside was merged into main as 4d3295e.

Review

Sign in to review this change.
2 files changed +16 −0
src/kernel/budgets.ts +7
@@ -19,6 +19,13 @@ export const BUDGETS = {
1919 * holds, so the impact map is measured. It got through 2061 of 3153 test
2020 * files in the 60 min of `gate`, twice, and failed on 2026-11-14 (#12499).
2121 * Landing never waits on it, so it has its own limit, with room to grow.
22 *
23 * Run 01m7cph78n2493t8as2avbd1re (#12947) was this run, not a pull's
24 * check: env `verify`, reason `schedule`, killed twice at the old 60 min.
25 * What it spent the hour on is per-process cost: one `bun test` under
26 * coverage for each of ~3300 files, at the lowest CPU priority (`--nice`),
27 * so every pull check beside it takes the CPU first. A pull's own check
28 * (`check.fast`) runs only the changed tier, and `gate` stays at 60.
2229 */
2330 verify: 150 * 60_000,
2431 /** A reviewer's run on a pull, in ms. */
test/budget-raised.test.ts +9
@@ -102,3 +102,12 @@ test("vitals: a verification killed at the old limit is no card; under limits th
102102 expect(card()).toBe(false);
103103 expect(card({ gate: 60 * MIN, verify: 60 * MIN, review: BUDGETS.review })).toBe(true);
104104 });
105
106 test("the check limit stays at 60 min or lower; the whole-suite measuring run has its own (#12949)", () => {

The title cites #12949, but this pull is #12950. Fix the reference when you next touch the file.

107 expect(BUDGETS.gate).toBeLessThanOrEqual(60 * MIN);
108 expect(BUDGETS.verify).toBeGreaterThan(BUDGETS.gate);
109 // The kill that raised #12947 was a scheduled verification under the old limit.
110 const old = budgetSummary("a full gate", 60 * MIN, 60 * MIN);
111 expect(limitSinceRaised(check("verify", old))).toBe(true);
112 expect(limitSinceRaised(check("pull", old))).toBe(false);
113 });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs