Public: anyone can read this; the crew can change it.
Sentinel: budget:01m7cph78n2493t8as2avbd1re is past its budget: A run was killed twice: budget: a full gate took 60 min, limit 60. #12948
Check · Review · Land · Live done — Landed and live in production.
mason/forge:mason/12947-sentinel-budget-01m7cph78n2493t8as2avbd1 → main 2 commits fork
4 files
changed +22
−7
src/kernel/budgets.ts +7 −2
| @@ -9,10 +9,15 @@ export const BUDGETS = { | ||
| 9 | 9 | * A check run, in ms. Set from measurement, not from the 15 min the plan |
| 10 | 10 | * wants: this repository's own gate takes 18–25 min alone and 45 min |
| 11 | 11 | * beside another check, so 15 would fail every check it has. Lower it |
| 12 | * when the gate is sharded under it. There is no fast-tier budget until a | |
| 12 | * when the gate is sharded under it. Raised from 60 to 90 min on 2026-11-15 | |
| 13 | * (#12947): a gate beside other work took the whole 60, twice, and the kill | |
| 14 | * is history under a raised limit (`limitSinceRaised`). 90 is a ceiling, not | |
| 15 | * a target: #12949 finds what made the gate slow (with #1242, the time per | |
| 16 | * test and per file), and the limit goes back to 60 or lower when a gate | |
| 17 | * beside other work finishes under it. There is no fast-tier budget until a | |
| 13 | 18 | * fast tier exists to measure. |
| 14 | 19 | */ |
| 15 | gate: 60 * 60_000, | |
| 20 | gate: 90 * 60_000, | |
| 16 | 21 | /** |
| 17 | 22 | * A verification of the default branch, in ms: the full gate run one file |
| 18 | 23 | * to a process, at the lowest priority, beside whatever else the lane |
test/budget-raised.test.ts +10
| @@ -102,3 +102,13 @@ test("vitals: a verification killed at the old limit is no card; under limits th | ||
| 102 | 102 | expect(card()).toBe(false); |
| 103 | 103 | expect(card({ gate: 60 * MIN, verify: 60 * MIN, review: BUDGETS.review })).toBe(true); |
| 104 | 104 | }); |
| 105 | ||
| 106 | test("a gate killed at the old 60 min limit is history under the live limit (#12947)", () => { | |
| 107 | const killed = { | |
| 108 | kind: "check", | |
| 109 | env: "preview", | |
| 110 | summary: "budget: a full gate took 60 min, limit 60", | |
| 111 | }; | |
| 112 | expect(BUDGETS.gate).toBeGreaterThan(60 * 60_000); | |
| 113 | expect(limitSinceRaised(killed)).toBe(true); | |
| 114 | }); |
test/check-budget.test.ts +1 −1
| @@ -40,7 +40,7 @@ afterAll(async () => { | ||
| 40 | 40 | |
| 41 | 41 | test("the summary names the thing, the time and the limit", () => { |
| 42 | 42 | expect(budgetSummary("a full gate", 18 * 60_000, BUDGETS.gate)).toBe( |
| 43 | "budget: a full gate took 18 min, limit 60", | |
| 43 | "budget: a full gate took 18 min, limit 90", | |
| 44 | 44 | ); |
| 45 | 45 | }); |
| 46 | 46 |
test/vitals.test.ts +4 −4
| @@ -469,7 +469,7 @@ test("a lane older than its budget is degraded with its cause; a silent run is s | ||
| 469 | 469 | const v = vitals({ db: app.db, signals: app.signals, dataDir, disk: roomy, now }); |
| 470 | 470 | const lane = v.degraded.find((d) => d.cause === "queue:check"); |
| 471 | 471 | expect(lane?.sentence).toMatch( |
| 472 | /^3 checks wait behind one lane; the oldest since \d\d:\d\d; the lane runs a check for 31 min \(limit 60\)\.$/, | |
| 472 | /^3 checks wait behind one lane; the oldest since \d\d:\d\d; the lane runs a check for 31 min \(limit 90\)\.$/, | |
| 473 | 473 | ); |
| 474 | 474 | expect(v.todo).toContain(lane!.sentence); |
| 475 | 475 | expect(v.ok).toBe(true); |
| @@ -500,13 +500,13 @@ test("laneSentence says one lane for one slot and names the slots in force for s | ||
| 500 | 500 | { pull: 4700, since: iso(2) }, |
| 501 | 501 | ]; |
| 502 | 502 | expect(laneSentence(3, oldest, [runs[0]!], 1, now)).toBe( |
| 503 | "3 checks wait behind one lane; the oldest since 01:04; the lane runs #4656 for 5 min (limit 60).", | |
| 503 | "3 checks wait behind one lane; the oldest since 01:04; the lane runs #4656 for 5 min (limit 90).", | |
| 504 | 504 | ); |
| 505 | 505 | expect(laneSentence(11, oldest, runs, 2, now)).toBe( |
| 506 | "11 checks wait for 2 slots, all busy; the oldest since 01:04; the longest running is #4656 at 5 min (limit 60).", | |
| 506 | "11 checks wait for 2 slots, all busy; the oldest since 01:04; the longest running is #4656 at 5 min (limit 90).", | |
| 507 | 507 | ); |
| 508 | 508 | expect(laneSentence(1, oldest, [runs[1]!], 7, now, 2)).toBe( |
| 509 | "1 check waits for 7 slots, 1 busy; the oldest since 01:04; the longest running is #4700 at 2 min (limit 60); 2 more held by a red main.", | |
| 509 | "1 check waits for 7 slots, 1 busy; the oldest since 01:04; the longest running is #4700 at 2 min (limit 90); 2 more held by a red main.", | |
| 510 | 510 | ); |
| 511 | 511 | expect(laneSentence(4, oldest, [], 3, now)).toBe( |
| 512 | 512 | "4 checks wait for 3 slots, none busy; the oldest since 01:04; nothing runs.", |
new above
offline