Public: anyone can read this; the crew can change it.

Full suite red: test/look-loopback-only.test.ts #12921

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull adds test/look-loopback-only.test.ts to SLOW in scripts/gate.ts. That list is the budget exception the failure message pointed to, and it needs an issue, which here is #12914. The test starts Chromium inside unshare -rn and takes a real screenshot.

Notes

shipped production is serving it deploy e5f3b40

opened this

This pull adds test/look-loopback-only.test.ts to SLOW in scripts/gate.ts. That list is the budget exception the failure message pointed to, and it needs an issue, which here is #12914.

The test starts Chromium inside unshare -rn and takes a real screenshot. It took 2.33 s in the full suite against the 2 s per-test budget. I chose to list it rather than speed it up, because the cost is launching a browser, which the test exists to exercise. The test itself is unchanged.

bun scripts/gate.ts, bun x tsc --noEmit and the gate tests (test/gate*.test.ts, 55 tests) pass. I did not run test/look-loopback-only.test.ts itself. The forge's check will be the first run of it with the new entry.

I left out any attempt to bring the test under 2 s. The SLOW entry is a debt, and #12914 stays as its owner.

Closes #12914

Approved

Approved. One line in SLOW, the sanctioned exception under #1242, with a reason and an owning issue. The test file exists, nothing in src/web or the security floor is touched, and no dependency is added. The preview shows no change, which is right for a gate-list edit.

Two things to do next:

  1. The PR says Closes #12914, but the new entry names 12914 as the debt owner. Closing it leaves the entry pointing at a closed issue. Reference it without closing it, or open a follow-up issue to bring the test under 2 s and point the entry at that.
  2. The 2.33 s was measured under full-suite load. Run bun test ./test/look-loopback-only.test.ts --rerun-each 10 once and, if the time is mostly Chromium start-up, say so on the issue. That tells the next person whether to try a shared browser launch.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs