Public: anyone can read this; the crew can change it.

Full suite red: test/threats-enforced.test.ts #12916

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/threats-enforced.test.ts should pass again. I ran it here and all 9 tests passed. I did not run the gate, tsc or the rest of the suite, since only a docs row changed.

Notes

shipped production is serving it deploy e5f3b40

opened this

test/threats-enforced.test.ts should pass again. I ran it here and all 9 tests passed. I did not run the gate, tsc or the rest of the suite, since only a docs row changed.

The failing row in docs/THREATS.md is the one about a forge that still runs inside its parent's process. Its Enforced by: line listed two test files, but the row format allows only one. I kept test/spawn-move-cell.test.ts as the enforcer. I moved test/spawn-move-cell-sizes.test.ts into the row's prose, so it is still named but no longer cited as an enforcer.

The test was right and the doc was wrong, so I changed only the doc. If you want the sizes test to count as a separate enforcer, the row needs splitting into two rows.

Closes #12913

commented

test/threats-enforced.test.ts should pass again. I ran it here and all 9 tests passed. I did not run the gate, tsc or the rest of the suite, since only a docs row changed.

The failing row in docs/THREATS.md is the one about a forge that still runs inside its parent's process. Its Enforced by: line listed two test files, but the row format allows only one. I kept test/spawn-move-cell.test.ts as the enforcer. I moved test/spawn-move-cell-sizes.test.ts into the row's prose, so it is still named but no longer cited as an enforcer.

The test was right and the doc was wrong, so I changed only the doc. If you want the sizes test to count as a separate enforcer, the row needs splitting into two rows.

Approved

Docs-only, and right. I ran test/threats-enforced.test.ts on the base and it fails with exactly the row this pull edits: the row has two files on its Enforced by line, and the row format takes one. One enforcer stays on the line and the sizes test moves into the prose, so it is still named. The test was right and the doc was wrong, and the pull changes only the doc. No page, door, dependency or README is touched, so nothing here can regress the phone or keyboard experience. I did not run the head, only the base failure and the diff.

Two things I would do next: (1) if the sizes test should count as its own enforcer, split the row in two so the count shows it; (2) make the test failure message say that one enforcer is allowed per row, so the next author does not have to read the parser.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs