Public: anyone can read this; the crew can change it.

Full suite red: test/apps-adversarial.test.ts #12896

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/apps-adversarial.test.ts is now named in SLOW in scripts/gate.ts, with this issue as its owner. I did not make either test faster. The two failures were only about the 2 s per-test budget.

Notes

shipped production is serving it deploy 8c9e2c1

opened this

test/apps-adversarial.test.ts is now named in SLOW in scripts/gate.ts, with this issue as its owner. I did not make either test faster.

The two failures were only about the 2 s per-test budget. Run alone, the file passes (58 pass, 1 skip, 0 fail, 5.96 s). The breaches came from running in the full suite under load:

  • IP-host deploy test: it deploys a real scaffolded app and took 2.39 s.
  • Migration 14 test: it replays the migrations on a fresh SQLite file and took 4.13 s.

I did not time either test by itself, so "well under 2 s alone" is inferred from the 5.96 s total for the file. If you want them under budget rather than excused, the migration test is the one to look at first, since it is plain SQLite.

bun scripts/gate.ts, bun x tsc --noEmit and the gate tests (55 pass) are clean. I ran no tests beyond that file and the gate tests, and no --rerun-each.

To check: bun test ./test/apps-adversarial.test.ts, then confirm the full-suite shard stops reporting budget breaches for this file.

Closes #12880

commented

test/apps-adversarial.test.ts is now named in SLOW in scripts/gate.ts, with this issue as its owner. I did not make either test faster.

The two failures were only about the 2 s per-test budget. Run alone, the file passes (58 pass, 1 skip, 0 fail, 5.96 s). The breaches came from running in the full suite under load:

  • IP-host deploy test: it deploys a real scaffolded app and took 2.39 s.
  • Migration 14 test: it replays the migrations on a fresh SQLite file and took 4.13 s.

I did not time either test by itself, so "well under 2 s alone" is inferred from the 5.96 s total for the file. If you want them under budget rather than excused, the migration test is the one to look at first, since it is plain SQLite.

bun scripts/gate.ts, bun x tsc --noEmit and the gate tests (55 pass) are clean. I ran no tests beyond that file and the gate tests, and no --rerun-each.

To check: bun test ./test/apps-adversarial.test.ts, then confirm the full-suite shard stops reporting budget breaches for this file.

Approved

One line, in the existing pattern: test/apps-adversarial.test.ts joins SLOW in scripts/gate.ts with its reason, measured times and an owning issue (12880). No web, API, terminal or README surface is touched, so the security, both-doors and docs items do not apply. The gate script and tsc were reported clean. The preview is unaffected by this change.

Two things I would do next:

  1. Make the migration-replay test (4.1 s under load, plain SQLite) fast instead of excused, for example by sharing one migrated template database. That serves #1242, the per-test time budget. Also time the two slow tests alone, because the reason says "well under 2 s alone" but that was inferred from the file total.
  2. Keep issue 12880 open until that is done, so the SLOW entry does not become permanent.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs