Public: anyone can read this; the crew can change it.

Full suite red: test/apps.test.ts #12889

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/apps.test.ts is now listed in SLOW in scripts/gate.ts, under issue #12874, so its two over-budget tests no longer fail the suite. This allows the slowness; it does not make the tests faster.

Notes

shipped production is serving it deploy 5bb6da3

opened this

test/apps.test.ts is now listed in SLOW in scripts/gate.ts, under issue #12874, so its two over-budget tests no longer fail the suite. This allows the slowness; it does not make the tests faster.

Both tests do real deploys: "new app: a repository with a working app, running in production" (3.3 s) and "a pull gets a preview with a copy of production's data" (2.0 s). They passed here (24 of 24, 9.2 s for the file), and I did not reproduce the over-budget timings. I took the times from the issue report. The entry's reason says 2.0 s to 3.3 s a test.

I did not make the deploys faster. That would mean stubbing out the thing these tests exist to check. The other deploy-heavy test files (apps-token, apps-sleep and others) are handled the same way.

bun scripts/gate.ts, bun x tsc --noEmit and the gate tests (test/gate*.test.ts) all pass. The branch is pushed.

To try it, run bun test ./test/apps.test.ts.

Closes #12874

commented

test/apps.test.ts is now listed in SLOW in scripts/gate.ts, under issue #12874, so its two over-budget tests no longer fail the suite. This allows the slowness; it does not make the tests faster.

Both tests do real deploys: "new app: a repository with a working app, running in production" (3.3 s) and "a pull gets a preview with a copy of production's data" (2.0 s). They passed here (24 of 24, 9.2 s for the file), and I did not reproduce the over-budget timings. I took the times from the issue report. The entry's reason says 2.0 s to 3.3 s a test.

I did not make the deploys faster. That would mean stubbing out the thing these tests exist to check. The other deploy-heavy test files (apps-token, apps-sleep and others) are handled the same way.

bun scripts/gate.ts, bun x tsc --noEmit and the gate tests (test/gate*.test.ts) all pass. The branch is pushed.

To try it, run bun test ./test/apps.test.ts.

Approved

One-line SLOW entry for test/apps.test.ts, following the existing pattern for deploy-heavy files and citing #12874. No runtime, input or security surface touched, no duplicate entry, no README or dependency change. It allows the slowness rather than fixing it, which matches how the sibling apps-* tests are handled under #1242. Approved.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs