Public: anyone can read this; the crew can change it.
Full suite red: test/check-land-settle.test.ts #12888
Check · Review · Land · Live done — Landed and live in production.
mason/forge:mason/12875-full-suite-red-test-check-land-settle-te → main 4 commits fork 2 threads · 2 unresolved
2 files
changed +10
−8
scripts/gate.ts +1
| @@ -57,6 +57,7 @@ export const SLOW: readonly Exclusion[] = [ | ||
| 57 | 57 | { file: "test/api-pulls-timing.test.ts", reason: "seeds 130 open pulls with git repositories to time the pulls API; 7.0 s a test on the gate box", issue: 1242 }, |
| 58 | 58 | { file: "test/apps-adversarial.test.ts", reason: "deploys a real scaffolded app and runs every migration on a fresh database; under full-suite load 2.4 s and 4.1 s a test, well under 2 s alone", issue: 12880 }, |
| 59 | 59 | { file: "test/apps-adversarial-teardown.test.ts", reason: "races a live preview's deploy against its close and waits out the window; 3.3 s a test on the gate box", issue: 1242 }, |
| 60 | { file: "test/check-land-settle.test.ts", reason: "waits out the 1.5 s settle window of a main check so the first step is superseded while queued; 2.0 s a test", issue: 12875 }, | |
| 60 | 61 | { file: "test/team-dispatch.test.ts", reason: "starts the crew and waits out five queued stand-in agent runs one slot at a time; 2.2 s to 3.6 s a test", issue: 12847 }, |
| 61 | 62 | { file: "test/small-forge.test.ts", reason: "boots a whole second forge from the checkout and walks home, first admin, push and check on it; 12 s a test in the sandbox", issue: 12532 }, |
| 62 | 63 | { file: "test/meter.test.ts", reason: "deploys a real app, waits out its sleep window, then wakes and stops it to read the meter intervals; 2.6 s a test on the gate box", issue: 12838 }, |
test/check-land-settle.test.ts +9 −8
| @@ -23,6 +23,7 @@ let servers: Servers; | ||
| 23 | 23 | let checks: ChecksHandle; |
| 24 | 24 | let alice: User; |
| 25 | 25 | let repo: Repo; |
| 26 | let round = 0; // a repeated run shares the repo: each run gets branches and files of its own | |
| 26 | 27 | |
| 27 | 28 | const checkJson = (run: string): string => |
| 28 | 29 | `{"check": {"run": ${JSON.stringify(run)}, "install": ""}}\n`; |
| @@ -84,15 +85,15 @@ test("two landings seconds apart: the first step's main check is superseded befo | ||
| 84 | 85 | if (!declared.ok) throw new Error(JSON.stringify(declared.error)); |
| 85 | 86 | await finished((r) => r.commitOid === declared.value.commitOid); |
| 86 | 87 | |
| 87 | const one = await pullOf("one", "ONE.md"); | |
| 88 | const two = await pullOf("two", "TWO.md"); | |
| 89 | const first = await mergePull(app, alice, repo, one, "merge"); | |
| 88 | // The pulls' own checks are not under test: a green on the pre-merge base | |
| 89 | // would make the second landing `check_stale`, depending on timing. | |
| 90 | const pastGate = true; | |
Comment is good; keep the note that this is the #3316 race. |
||
| 91 | round += 1; | |
| 92 | const one = await pullOf(`one-${round}`, `ONE-${round}.md`); | |
| 93 | const two = await pullOf(`two-${round}`, `TWO-${round}.md`); | |
| 94 | const first = await mergePull(app, alice, repo, one, "merge", undefined, { pastGate }); | |
| 90 | 95 | if (!first.ok) throw new Error(JSON.stringify(first.error)); |
| 91 | // The queue lands a step without asking for a green on the newest base | |
| 92 | // (#3316). Pull two's own check may have gone green on the main before | |
| 93 | // `one` landed; held to a fresh green, this landing would be refused | |
| 94 | // `check_stale` by that race, not by what this test is about. | |
| 95 | const second = await mergePull(app, alice, repo, two, "merge", undefined, { pastGate: true }); | |
| 96 | const second = await mergePull(app, alice, repo, two, "merge", undefined, { pastGate }); | |
| 96 | 97 | if (!second.ok) throw new Error(JSON.stringify(second.error)); |
| 97 | 98 | |
| 98 | 99 | const tip = await finished((r) => r.commitOid === second.value.mergeOid); |
new above
offline
Fine as an interim. Drop this entry when the test no longer waits out the real window.