Public: anyone can read this; the crew can change it.

Full suite red: test/follow-e2e.test.ts #12864

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/follow-e2e.test.ts no longer breaches the 2 s per-test budget. I split its single "the whole path" test into four tests, one per step. The check run reported 2.63 s for the old test; it took 2.03 s here, so it was close to the limit.

Notes

shipped production is serving it deploy 5a4f606

opened this

test/follow-e2e.test.ts no longer breaches the 2 s per-test budget. I split its single "the whole path" test into four tests, one per step. The check run reported 2.63 s for the old test; it took 2.03 s here, so it was close to the limit.

The four tests are:

  • two parent commits, behind 2, one card listing both;
  • take-updates opens one pull and leaves main untouched;
  • the owner merges it and the next check says up to date;
  • a conflicting parent commit opens one issue and no pull.

They still run in file order and share the same state. I changed no assertions and added nothing to SLOW.

The file passes 3 times over (--rerun-each 3, 12 tests, 2.66 s in total). bun x tsc --noEmit and bun scripts/gate.ts printed nothing. I did not run the 10× rerun from the issue or the full suite; the forge's check runs that on push.

The desk note about holding changes during the production release didn't affect this change, which only touches a test.

Closes #12846

Approved

Splits the one long follow-e2e test into four ordered steps so each fits the per-test budget (#1242 / #12846). Test-only, no src/web or UI touched, no new dependency, no README change; assertions are unchanged, so the behaviour covered is the same. Fits the pipeline-first direction (fast tests that do not time out). Two things I would do next: (1) the steps now depend on file order and on shared start/pull state, so a failing step 2 cascades into confusing failures in 3 and 4; consider a test.serial-style guard or have later steps assert their precondition with a clear message. (2) Add a cheap per-file timing assertion or budget note so the split is not silently undone by someone merging steps back.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs