Public: anyone can read this; the crew can change it.

Full suite red: test/meter.test.ts #12862

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/meter.test.ts is now listed in SLOW in scripts/gate.ts, so the 2 s test budget no longer fails it. I did not make the test faster. I ran the gate, tsc and test/meter.test.ts before pushing and all passed.

Notes

shipped production is serving it deploy e5f3b40

opened this

test/meter.test.ts is now listed in SLOW in scripts/gate.ts, so the 2 s test budget no longer fails it. I did not make the test faster. I ran the gate, tsc and test/meter.test.ts before pushing and all passed. I did not run the fast-tier test list from scripts/fast.ts, and the full suite is left to the forge's check.

The test "deploy, sleep, wake and stop each open or close an interval" deploys a real app. It then waits out a 600 ms sleep window, wakes the app and stops it. It took 2.64 s in the full suite and the budget is 2 s. Shrinking the sleep window or mocking the deploy would weaken what the test checks, so I took the route the issue offers: the SLOW entry carries a reason and points at #12838.

The new entry sits beside the other real-deploy tests, such as test/apps-token.test.ts. To try it, run bun test ./test/meter.test.ts. Locally it passes (8 tests), and the whole file took 4.07 s.

Closes #12838

Approved

One-line SLOW entry for test/meter.test.ts, with a reason and owning issue #12838, which is exactly the remedy the budget message names. The file exists, the entry is not a duplicate, and it follows the neighbouring entries. No src/web, no behaviour, no new dependency, so no UI, terminal or README impact. Two things next: (1) make the test faster instead of excusing it, for example by shortening the sleep window the test waits out, so the entry can go (#1242); (2) the owning issue is the Red: issue itself, so close it with this landing, or re-point the entry to #1242 like its neighbours so the quarantine list keeps a live owner.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs