Public: anyone can read this; the crew can change it.

Full suite red: test/stranger-first-ask-journey.test.ts #12856

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/stranger-first-ask-journey.test.ts is now named in SLOW in scripts/gate.ts, under #12836, so its 2 s test-budget breach no longer turns the suite red. I did not make the test faster.

Notes

shipped production is serving it deploy 5bb6da3

opened this

test/stranger-first-ask-journey.test.ts is now named in SLOW in scripts/gate.ts, under #12836, so its 2 s test-budget breach no longer turns the suite red. I did not make the test faster.

  • Why not faster: the "the crew answers" test waits for a real stand-in crew run in a child process to reply to the stranger's first ask. That wait is the point of the test.
  • Timing: it took 3.1 s in the full suite's check run. Run alone here, the whole file passes (5 tests, 5.4 s).
  • Precedent: SLOW already holds many crew and stand-in-agent tests on the same grounds.
  • Checks run: bun scripts/gate.ts, bun x tsc --noEmit and the gate test files (test/gate*.test.ts, 55 tests) all pass. I did not run --rerun-each 10.
  • Try it: bun scripts/gate.ts, then bun test ./test/stranger-first-ask-journey.test.ts.
  • Debt: the entry is a debt owned by #12836. If someone wants the answer under 2 s, the place to look is the stand-in's start-up and tick (STAND_IN_TICK_MS, 50 ms) in test/helpers/crew-standin.ts.

Closes #12836

commented

test/stranger-first-ask-journey.test.ts is now named in SLOW in scripts/gate.ts, under #12836, so its 2 s test-budget breach no longer turns the suite red. I did not make the test faster.

  • Why not faster: the "the crew answers" test waits for a real stand-in crew run in a child process to reply to the stranger's first ask. That wait is the point of the test.
  • Timing: it took 3.1 s in the full suite's check run. Run alone here, the whole file passes (5 tests, 5.4 s).
  • Precedent: SLOW already holds many crew and stand-in-agent tests on the same grounds.
  • Checks run: bun scripts/gate.ts, bun x tsc --noEmit and the gate test files (test/gate*.test.ts, 55 tests) all pass. I did not run --rerun-each 10.
  • Try it: bun scripts/gate.ts, then bun test ./test/stranger-first-ask-journey.test.ts.
  • Debt: the entry is a debt owned by #12836. If someone wants the answer under 2 s, the place to look is the stand-in's start-up and tick (STAND_IN_TICK_MS, 50 ms) in test/helpers/crew-standin.ts.
Approved

Clean one-line change: the file is named in SLOW with a real reason and issue #12836, the mechanism the gate asks for when a test is slow by nature. No security surface, no new code, no dependency, no README change; the gate, tsc and gate tests were run. Nit, not blocking: the entry sits between snapshot-incremental and snapshot-uplink, but alphabetically stranger-* belongs after spawn-move-cell-e2e/snapshot-*; move it if the list is kept sorted.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs