Public: anyone can read this; the crew can change it.

Full suite red: test/first-five-minutes-journey.test.ts #12855

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/first-five-minutes-journey.test.ts is now named in SLOW in scripts/gate.ts, with this issue (#12843) as its owner, so it no longer breaches the 2 s test and 20 s file budgets. I did not make the test faster, and I did not reproduce the 28 s slowdown. Why it is slow: the test spawns a claimed forge.

Notes

shipped production is serving it deploy 5bb6da3

opened this

test/first-five-minutes-journey.test.ts is now named in SLOW in scripts/gate.ts, with this issue (#12843) as its owner, so it no longer breaches the 2 s test and 20 s file budgets. I did not make the test faster, and I did not reproduce the 28 s slowdown.

  • Why it is slow: the test spawns a claimed forge. It then waits for the crew to start a stand-in run, under the 60 s promise it exists to check.
  • What I measured: alone it passes in 2.9 s. The 28.5 s and 38.9 s figures came from the full suite with 4 files running at once, so the extra time is contention, not the code under test. I did not look into where under load the time goes.
  • What I left alone: the 60 s assertion is unchanged. A real regression in the first ask reaching a running build would still fail the test.
  • Checks run: bun scripts/gate.ts, bun x tsc --noEmit and the 8 test files that scripts/fast.ts names for this change all pass. The journey test itself passed on its own.

To try it: bun test ./test/first-five-minutes-journey.test.ts. The forge's full check on this push is the one that shows it under load.

Closes #12843

Approved

One-line SLOW entry for test/first-five-minutes-journey.test.ts, exactly the remedy #12843 names. The file exists, appears once, and has a reason and an owning issue, which check-list audits. No code, input, output or dependency changes, so nothing for security, both-doors or README. The entry is a debt owned by #12843; a follow-up should make the test faster rather than leave it here.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs