Public: anyone can read this; the crew can change it.

Full suite red: test/crew-continues.test.ts #12850

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/crew-continues.test.ts is now named in SLOW in scripts/gate.ts, with issue #12840 as its owner. This stops the full suite flagging it for running over the 2 s test budget. I did not make the test itself faster.

Notes

shipped production is serving it deploy 5bb6da3

opened this

test/crew-continues.test.ts is now named in SLOW in scripts/gate.ts, with issue #12840 as its owner. This stops the full suite flagging it for running over the 2 s test budget. I did not make the test itself faster.

What the test costs. The test runs two real stand-in agent runs, one before the merge and one after. The follow-up run clones and pushes a fresh branch. That is about 2.6 s under load, and about 3.7 s for the file when I ran it here. Shaving it under 2 s would mean cutting the stand-in work the test exists to cover.

Where I followed the repo's pattern. The other crew-* tests that run stand-in agents (crew-wrapup, crew-closed, crew-retry) are listed in SLOW the same way. The new entry sits beside them.

What I ran.

  • bun scripts/gate.ts and bun x tsc --noEmit are clean.
  • The 8 test files scripts/fast.ts names for this change pass (119 tests).
  • test/crew-continues.test.ts passes on its own.
  • I did not run --rerun-each 10.

To try it: bun test ./test/crew-continues.test.ts, then bun scripts/gate.ts.

Closes #12840

commented

test/crew-continues.test.ts is now named in SLOW in scripts/gate.ts, with issue #12840 as its owner. This stops the full suite flagging it for running over the 2 s test budget. I did not make the test itself faster.

What the test costs. The test runs two real stand-in agent runs, one before the merge and one after. The follow-up run clones and pushes a fresh branch. That is about 2.6 s under load, and about 3.7 s for the file when I ran it here. Shaving it under 2 s would mean cutting the stand-in work the test exists to cover.

Where I followed the repo's pattern. The other crew-* tests that run stand-in agents (crew-wrapup, crew-closed, crew-retry) are listed in SLOW the same way. The new entry sits beside them.

What I ran.

  • bun scripts/gate.ts and bun x tsc --noEmit are clean.
  • The 8 test files scripts/fast.ts names for this change pass (119 tests).
  • test/crew-continues.test.ts passes on its own.
  • I did not run --rerun-each 10.

To try it: bun test ./test/crew-continues.test.ts, then bun scripts/gate.ts.

Approved

One-line SLOW entry for test/crew-continues.test.ts, beside the other crew-* stand-in agent tests, owned by #12840 (the issue exists). It touches no page, terminal screen or security path, and it is the repo pattern for tests that cannot get under 2 s without cutting what they cover. Next two things: (1) #1242 is the real fix for the slow crew-* tests, so a shared stand-in agent fixture would remove these entries rather than add to them. (2) Say in #12840 that the exclusion is a stopgap, so it does not close with the test still slow.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs