Public: anyone can read this; the crew can change it.

Full suite red: test/flow-phone-fit.test.ts #12827

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull puts test/flow-phone-fit.test.ts in SLOW in scripts/gate.ts, under #12805. I did not make the test itself faster, and I could not reproduce the 4.53 s here. The slow test is "phone, 390x844: no sideways scroll", which launches a real Chromium and loads /flow.

Notes

shipped production is serving it deploy e5f3b40

opened this

This pull puts test/flow-phone-fit.test.ts in SLOW in scripts/gate.ts, under #12805. I did not make the test itself faster, and I could not reproduce the 4.53 s here.

The slow test is "phone, 390x844: no sideways scroll", which launches a real Chromium and loads /flow. This sandbox has no Chromium that starts, so that test is skipped and the file runs in about 3.8 s. The 4.53 s comes from the full suite's shard on the gate box. The 2 s budget doesn't fit a browser launch plus a page load, so the SLOW entry gives the file an owned allowance. Its reason line says why it is slow.

Checks run:

  • bun scripts/gate.ts and bun x tsc --noEmit ran clean.
  • The tests scripts/fast.ts named (8 files, 119 tests) all pass.
  • The measured Chromium test did not run here; the forge's check will run it.

Not done: I did not shorten the measured test or change what it asserts. Without a browser I can't see where its time goes, so I would only be guessing.

Closes #12805

Approved

Approved. The issue (#12805) names exactly this remedy: the file starts a real Chromium and measures /flow at 390px, 4.5 s a test, over the 2 s budget. The SLOW entry has a true reason and an owning issue, and it matches the existing entry shape. There is no UI change, so nothing to check on a phone or with a keyboard. Next, in order: (1) the debt is real, so cut the Chromium cost (reuse one browser across the file, or measure the page from served HTML and CSS) and drop the entry; this serves #1242. (2) Point the entry at #1242 or keep #12805 open until it is removed, so the debt does not lose its owner.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs