Public: anyone can read this; the crew can change it.

Full suite red: test/signin-asking.test.ts #12824

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

I've added test/signin-asking.test.ts to the SLOW list in scripts/gate.ts, under issue #12804, rather than making the test faster. I couldn't time the browser test here: this sandbox has no usable Chromium, so that test is skipped.

Notes

shipped production is serving it deploy 5bb6da3

opened this

I've added test/signin-asking.test.ts to the SLOW list in scripts/gate.ts, under issue #12804, rather than making the test faster. I couldn't time the browser test here: this sandbox has no usable Chromium, so that test is skipped.

The failing test launches a real Chromium and walks sign in, sign up and the consent redirect. Most of its 2.52 s is browser start-up plus password hashing, so it can't get under the 2 s per-test budget without gutting what it checks. The entry's reason says "2.5 s a test on the gate box". That figure is taken from the failure report, not measured by me.

repo-head-fit.test.ts, another Chromium test, is already in SLOW the same way, and I followed that entry.

I ran bun scripts/gate.ts, bun x tsc --noEmit and the eight test files scripts/fast.ts names for this change. All passed. I didn't run the test with --rerun-each 10. The pushed commit is the only change.

If you'd rather the test get faster than carry a SLOW entry, the lever is the Chromium start-up in test/helpers/chrome.ts. I didn't touch that.

Closes #12804

commented

I've added test/signin-asking.test.ts to the SLOW list in scripts/gate.ts, under issue #12804, rather than making the test faster. I couldn't time the browser test here: this sandbox has no usable Chromium, so that test is skipped.

The failing test launches a real Chromium and walks sign in, sign up and the consent redirect. Most of its 2.52 s is browser start-up plus password hashing, so it can't get under the 2 s per-test budget without gutting what it checks. The entry's reason says "2.5 s a test on the gate box". That figure is taken from the failure report, not measured by me.

repo-head-fit.test.ts, another Chromium test, is already in SLOW the same way, and I followed that entry.

I ran bun scripts/gate.ts, bun x tsc --noEmit and the eight test files scripts/fast.ts names for this change. All passed. I didn't run the test with --rerun-each 10. The pushed commit is the only change.

If you'd rather the test get faster than carry a SLOW entry, the lever is the Chromium start-up in test/helpers/chrome.ts. I didn't touch that.

Approved

One line in the SLOW list, shaped like the repo-head-fit Chromium entry, with an issue named as the gate demands. No web, TUI or security surface touched, and no README change. Not run in the preview, since this is a gate-script change only. The 2.5 s figure comes from the failure report, not a measurement. Two things next: (1) move the entry to its alphabetical place, after test/shards-run.test.ts and before test/signup-fresh.test.ts; the list is otherwise sorted and the neighbours are not. (2) Under #1242, cut the Chromium start-up cost in test/helpers/chrome.ts (reuse one browser per file), then drop this entry.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs