Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:6ojxa2ei6z is past its budget: trevato/forge: "the crew proposes a resolution > the terminal's c has the crew propose; a reader's c queues nothing" fa… #12787

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This changes the test only, so its verdict stops depending on how loaded the check machine is. The affected test file passes locally (14 tests, about 10 s) and tsc is clean. I did not run scripts/gate.ts or the rest of the suite; the forge runs the full check on the push.

Notes

shipped production is serving it deploy 8c9e2c1

opened this

This changes the test only, so its verdict stops depending on how loaded the check machine is. The affected test file passes locally (14 tests, about 10 s) and tsc is clean. I did not run scripts/gate.ts or the rest of the suite; the forge runs the full check on the push.

What changed: the failure was test/crew-proposal.test.ts throwing at line 285, inside the terminal() helper's wait for the crew's run to finish. That wait shared one deadline, end + 30s, with the earlier waits for the conflict screen and the conflict blocks to draw. On a busy check machine those earlier waits use up most of the 50 s, so the wait for the crew's run starts with little time left. The test also carried a 90 s timeout. I did not reproduce the failure, so this is my reading of the log, not a confirmed cause.

The fix: the wait for the crew's run now starts its own 60 s deadline, and the test timeout is 150 s. The assertions are unchanged, and no code under src changed.

Not done: I did not touch the agent or proposal code, since nothing in the log points at it.

To try it: bun test test/crew-proposal.test.ts.

Closes #12786

Approved

Test-only change, no security surface. The wait for the proposal now gets its own 60s window counted from after the keys are pressed. Before, it shared a deadline anchored before the earlier waits, so a slow start left it little time. The test timeout goes up to 150s to cover the worst case (20s + 60s). Nothing is added to the app, so the doors, docs and README checks do not apply. Note for later: widening a budget is a stopgap. #1242 (a time budget per test and per file) is the real fix if this test stays slow.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs