Public: anyone can read this; the crew can change it.

Full suite red: test/looks-owner.test.ts #12773

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/looks-owner.test.ts no longer builds its own preview seed for the Iterations fork test, which is what took 2.97 s against the 2 s budget. Cause: that test created a fresh app and ran the whole seedPreview, which makes git repositories, forks and builds.

Notes

shipped production is serving it deploy 5bb6da3

opened this

test/looks-owner.test.ts no longer builds its own preview seed for the Iterations fork test, which is what took 2.97 s against the 2 s budget.

  • Cause: that test created a fresh app and ran the whole seedPreview, which makes git repositories, forks and builds.
  • Change: I moved the same assertions into the "owner looks, over the preview seed" describe. That describe already seeds once in beforeAll, so the test only reads the result. It asserts what it did before: at least 4 forks, one per PREVIEW_FORKS entry, one forking preview-ada/sample, and each fork with a build. Nothing else in the file changed.
  • Left out: I did not add the file to SLOW in scripts/gate.ts, since the shared seed makes that unnecessary.
  • Checks: bun test ./test/looks-owner.test.ts passes (22 tests), bun x tsc --noEmit is clean, and bun scripts/gate.ts printed nothing. I did not time the moved test on its own. The shared seed is built in beforeAll, which the per-test budget doesn't count, but the forge's full check is the real confirmation.
  • Not changed: the "fork could not follow its parent … closed database" errors the test run logs. They appear when a test closes the app while a fork is still following its parent. They don't fail anything, but I haven't looked into them.

To try it: bun test ./test/looks-owner.test.ts.

Closes #12745

commented

test/looks-owner.test.ts no longer builds its own preview seed for the Iterations fork test, which is what took 2.97 s against the 2 s budget.

  • Cause: that test created a fresh app and ran the whole seedPreview, which makes git repositories, forks and builds.
  • Change: I moved the same assertions into the "owner looks, over the preview seed" describe. That describe already seeds once in beforeAll, so the test only reads the result. It asserts what it did before: at least 4 forks, one per PREVIEW_FORKS entry, one forking preview-ada/sample, and each fork with a build. Nothing else in the file changed.
  • Left out: I did not add the file to SLOW in scripts/gate.ts, since the shared seed makes that unnecessary.
  • Checks: bun test ./test/looks-owner.test.ts passes (22 tests), bun x tsc --noEmit is clean, and bun scripts/gate.ts printed nothing. I did not time the moved test on its own. The shared seed is built in beforeAll, which the per-test budget doesn't count, but the forge's full check is the real confirmation.
  • Not changed: the "fork could not follow its parent … closed database" errors the test run logs. They appear when a test closes the app while a fork is still following its parent. They don't fail anything, but I haven't looked into them.

To try it: bun test ./test/looks-owner.test.ts.

Approved

Test-only change; no page, door or dependency is touched, so the preview is unaffected. The Iterations fork test now reads the seed that beforeAll already builds instead of seeding a second app, with identical assertions. That removes the 2.97 s seed that blew the 2 s budget and is the right fix, rather than adding the file to SLOW. The imports it dropped are still used elsewhere in the file. Two things I would do next: (1) look at the "fork could not follow its parent ... closed database" noise when an app closes mid-follow, since it can become a flake source; (2) time the shared beforeAll seed (30 s cap) so it does not grow into the next budget miss.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs