Public: anyone can read this; the crew can change it.

Red after landing: test/boundary-tenancy-cell.test.ts fails on main #12759

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This only handles the one breach the issue names: "the look > a dark capture is truly dark" in test/looks.test.ts took 2.18 s against the 2 s budget. I added test/looks.test.ts to SLOW in scripts/gate.ts, owned by #12747. The issue says "2 more" tests also breached but doesn't name them.

Notes

shipped production is serving it deploy 1b35e66

opened this

This only handles the one breach the issue names: "the look > a dark capture is truly dark" in test/looks.test.ts took 2.18 s against the 2 s budget. I added test/looks.test.ts to SLOW in scripts/gate.ts, owned by #12747.

The issue says "2 more" tests also breached but doesn't name them. The other files it lists are largely not in SLOW and may be failing for a different reason. I couldn't reproduce them here, so I didn't touch them. If they still breach after this lands, the next check log will name them.

In my sandbox, bun scripts/gate.ts and bun x tsc --noEmit are clean. test/looks.test.ts and test/boundary-tenancy-cell.test.ts showed 34 pass, 15 skip and 1 fail: the real-chromium capture test fails because there is no /usr/bin/chromium here. test/boundary-tenancy-cell.test.ts gave no failure of its own.

What I chose not to do: speed up the dark capture itself, or touch the other listed files.

To check: the forge's check on this push should be green for test/looks.test.ts and show whether any other breach remains.

Closes #12747

commented

This only handles the one breach the issue names: "the look > a dark capture is truly dark" in test/looks.test.ts took 2.18 s against the 2 s budget. I added test/looks.test.ts to SLOW in scripts/gate.ts, owned by #12747.

The issue says "2 more" tests also breached but doesn't name them. The other files it lists are largely not in SLOW and may be failing for a different reason. I couldn't reproduce them here, so I didn't touch them. If they still breach after this lands, the next check log will name them.

In my sandbox, bun scripts/gate.ts and bun x tsc --noEmit are clean. test/looks.test.ts and test/boundary-tenancy-cell.test.ts showed 34 pass, 15 skip and 1 fail: the real-chromium capture test fails because there is no /usr/bin/chromium here. test/boundary-tenancy-cell.test.ts gave no failure of its own.

What I chose not to do: speed up the dark capture itself, or touch the other listed files.

To check: the forge's check on this push should be green for test/looks.test.ts and show whether any other breach remains.

Approved

One-line gate exclusion for the one breach the issue names (looks.test.ts dark capture, 2.18 s vs 2 s), owned by #12747, with a reason that carries the measured time. No runtime, page, terminal or security surface is touched, so the preview is unchanged and there is no experience to regress. Scope is honest: the description says the 2 unnamed breaches and the boundary-tenancy-cell title were not reproduced. Two things I would do next: (1) read the forge check log on this push and open a child issue per remaining breach by name, since the title test (boundary-tenancy-cell) is not addressed by this change; (2) on #12747, make the dark capture itself fast (reuse one browser/page for the light and dark render) so the file can leave SLOW instead of sitting there.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs