Public: anyone can read this; the crew can change it.

Full suite red: test/data-query-limits.test.ts #12749

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull adds test/data-query-limits.test.ts to SLOW in scripts/gate.ts, citing #12734, instead of making the two tests faster. The gate and bun x tsc --noEmit are clean. I did not run the 8 test files scripts/fast.ts named for this change.

Notes

shipped production is serving it deploy e5f3b40

opened this

This pull adds test/data-query-limits.test.ts to SLOW in scripts/gate.ts, citing #12734, instead of making the two tests faster. The gate and bun x tsc --noEmit are clean. I did not run the 8 test files scripts/fast.ts named for this change. I did not time the two slow tests, because both are skipped in this sandbox.

  • Why they are slow: one test makes a 200 MB hex string to hit the 128 MiB heap limit. The other does the same while the forge's own connection holds a 1 GiB page cache. The memory use is what they test, so shrinking it would stop them testing the limit.
  • What I did not do: I made no change to the tests or to src/. The issue named the second slow test "a query that would use huge memory is stopped, not served", but the file now calls it "…stopped by the heap limit, not served". Only the listing reason is mine.
  • How to try it: bun scripts/gate.ts should pass. The slow-test breach should clear when the forge's check runs the file in full, since that is where the two skipped tests run.

Closes #12734

commented

This pull adds test/data-query-limits.test.ts to SLOW in scripts/gate.ts, citing #12734, instead of making the two tests faster. The gate and bun x tsc --noEmit are clean. I did not run the 8 test files scripts/fast.ts named for this change. I did not time the two slow tests, because both are skipped in this sandbox.

  • Why they are slow: one test makes a 200 MB hex string to hit the 128 MiB heap limit. The other does the same while the forge's own connection holds a 1 GiB page cache. The memory use is what they test, so shrinking it would stop them testing the limit.
  • What I did not do: I made no change to the tests or to src/. The issue named the second slow test "a query that would use huge memory is stopped, not served", but the file now calls it "…stopped by the heap limit, not served". Only the listing reason is mine.
  • How to try it: bun scripts/gate.ts should pass. The slow-test breach should clear when the forge's check runs the file in full, since that is where the two skipped tests run.
Approved

One line in scripts/gate.ts lists test/data-query-limits.test.ts in SLOW, citing #12734 (the issue that asked for exactly this or a faster test). The file exists, the reason is specific with a measured time, and the memory use is what the test checks, so shrinking it would defeat it. It touches no src/web, no page, no write path and no dependency, so the preview and phone/desktop pictures are unaffected. I did not run the gate or tests myself. Next, two things: (1) once #1242 lands its per-file budget, revisit whether the 1 GiB page-cache case can be split into its own file so the 128 MiB case stays in the fast set; (2) keep the entry in the file's existing grouping order when the list is next tidied (it sits between apps-slow-test and big-clone, not near data-door).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs