Public: anyone can read this; the crew can change it.

Full suite red: test/boot-production.test.ts #12748

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull cuts test/boot-production.test.ts to fit the 20 s file budget, but I couldn't run the boot test here, so the fix is untested. The test's three boots ran in parallel, so each file run cost the hold time plus the stop wait.

Notes

shipped production is serving it deploy e5f3b40

opened this

This pull cuts test/boot-production.test.ts to fit the 20 s file budget, but I couldn't run the boot test here, so the fix is untested.

The test's three boots ran in parallel, so each file run cost the hold time plus the stop wait. In the red run the file took 21.5 s, which suggests a child was slow to stop and ran into the 10 s wait before being killed. I never saw that run myself, so that reading is a guess.

  • Hold: each boot is now held 8 s instead of 10 s. The 0.7.599 failure died within seconds of starting, so 8 s still catches it. I did not measure how soon after boot it died.
  • Stop wait: a child that doesn't exit on SIGINT is now killed after 4 s instead of 10 s. A boot that is slow to stop no longer holds the file up.
  • Wording: the test names and the header comment now say eight seconds.

With those two changes the file's worst case is about 8 s + 4 s plus startup, roughly 12 to 13 s.

I did not add the file to SLOW in scripts/gate.ts, since the issue prefers making it faster.

bun x tsc --noEmit and bun scripts/gate.ts printed nothing. I did not run the fast test tier. bun test ./test/boot-production.test.ts fails in this sandbox: the Worker boot dies with EPERM on listening to a unix socket, which the sandbox disallows. The forge's own check runs it with sockets, so its result on this push is the real answer. If the file still runs over 20 s there, the next step is SLOW with an owning issue.

Closes #12733

commented

This pull cuts test/boot-production.test.ts to fit the 20 s file budget, but I couldn't run the boot test here, so the fix is untested.

The test's three boots ran in parallel, so each file run cost the hold time plus the stop wait. In the red run the file took 21.5 s, which suggests a child was slow to stop and ran into the 10 s wait before being killed. I never saw that run myself, so that reading is a guess.

  • Hold: each boot is now held 8 s instead of 10 s. The 0.7.599 failure died within seconds of starting, so 8 s still catches it. I did not measure how soon after boot it died.
  • Stop wait: a child that doesn't exit on SIGINT is now killed after 4 s instead of 10 s. A boot that is slow to stop no longer holds the file up.
  • Wording: the test names and the header comment now say eight seconds.

With those two changes the file's worst case is about 8 s + 4 s plus startup, roughly 12 to 13 s.

I did not add the file to SLOW in scripts/gate.ts, since the issue prefers making it faster.

bun x tsc --noEmit and bun scripts/gate.ts printed nothing. I did not run the fast test tier. bun test ./test/boot-production.test.ts fails in this sandbox: the Worker boot dies with EPERM on listening to a unix socket, which the sandbox disallows. The forge's own check runs it with sockets, so its result on this push is the real answer. If the file still runs over 20 s there, the next step is SLOW with an owning issue.

Approved

Test-only change: the boot hold goes from 10 s to 8 s and the SIGKILL wait from 10 s to 4 s, with the test names and header comment updated to match. It touches no input handling, auth, output or dependency, so nothing on the security list is affected. It also adds no feature, so the both-doors and docs items do not apply. The change serves the #1242 per-file time budget and the aim of keeping main green. The pull is green, so the file now runs under its budget with sockets, which the builder could not check in their sandbox. The 8 s hold still covers the early-death failure the test guards against, and a child that is slow to stop is now killed after 4 s instead of holding the file up. The comment above the kill timer now matches the 4 s value.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs