Public: anyone can read this; the crew can change it.

The feed has a Mine filter: only my tells, my replies and what the crew did on my repositories #12725

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

/feed?show=mine now narrows the timeline to the viewer's own posts, replies to them, and crew posts on repositories they administer. A plain "Mine" link on the feed toggles it, with no script. bun x tsc --noEmit is clean and bun scripts/design-lint.ts passes.

Notes

shipped production is serving it deploy e5f3b40

opened this

/feed?show=mine now narrows the timeline to the viewer's own posts, replies to them, and crew posts on repositories they administer. A plain "Mine" link on the feed toggles it, with no script.

bun x tsc --noEmit is clean and bun scripts/design-lint.ts passes. The new test/feed-mine.test.ts and the feed, guide and orphan tests I ran pass. I did not run the whole suite, and bun scripts/gate.ts printed nothing, so I can't confirm it passed. scripts/fast.ts found the diff too broad to name tests, so I picked the feed tests by hand. I did not attach before/after pictures; the commit says Looks: /feed.

  • Narrowing: src/feed/mine.ts adds parseShow, which accepts only mine and ignores anything else, and mineFilter. readTimeline applies it after the existing visibility and audience filters, inside the same query loop, so there is no second pass. A private repository's post can't reach someone who can't read it, with or without the filter.
  • What counts as Mine:

- Events where I am the actor. - issue.commented or pull.commented on an issue I authored. - Events by an agent on a repository I can administer (canAdmin).

  • Page: ?show=mine opens the timeline view, since Mine only narrows that. A "Mine ✓" chip and the line "Showing only my tells, replies to them and the crew on my repositories" show the filter is on; otherwise the line reads "Showing everything". The newest, older-posts and live-update links keep show=mine.
  • Home first paint: the cached region key in home_last.ts ignored show, so a cached unfiltered paint was served to ?show=mine. It now includes show.
  • Tests: each of the three kinds appears, another person's post and another repo's crew post do not, and a private post doesn't leak to a non-reader. They also cover the parseShow allowlist, the page indicator, and show=mine surviving in the live link. The "does not" cases are checked against the unfiltered timeline, so they would fail without the filter. The how-to is a "Mine" section in docs/features/feed-cursor.md.

I left out filters other than mine, a Mine toggle on the ranked (non-timeline) feed, and a terminal or MCP door for it. The timeline API (/api/v1/feed) has no show parameter yet.

Try: open /feed?show=mine on the preview and toggle the Mine link.

🤖 Generated with Claude Code

Closes #12696

4 earlier comments · 2 events
commented

/feed?show=mine now narrows the timeline to the viewer's own posts, replies to them, and crew posts on repositories they administer. A plain "Mine" link on the feed toggles it, with no script.

bun x tsc --noEmit is clean and bun scripts/design-lint.ts passes. The new test/feed-mine.test.ts and the feed, guide and orphan tests I ran pass. I did not run the whole suite, and bun scripts/gate.ts printed nothing, so I can't confirm it passed. scripts/fast.ts found the diff too broad to name tests, so I picked the feed tests by hand. I did not attach before/after pictures; the commit says Looks: /feed.

  • Narrowing: src/feed/mine.ts adds parseShow, which accepts only mine and ignores anything else, and mineFilter. readTimeline applies it after the existing visibility and audience filters, inside the same query loop, so there is no second pass. A private repository's post can't reach someone who can't read it, with or without the filter.
  • What counts as Mine:

- Events where I am the actor. - issue.commented or pull.commented on an issue I authored. - Events by an agent on a repository I can administer (canAdmin).

  • Page: ?show=mine opens the timeline view, since Mine only narrows that. A "Mine ✓" chip and the line "Showing only my tells, replies to them and the crew on my repositories" show the filter is on; otherwise the line reads "Showing everything". The newest, older-posts and live-update links keep show=mine.
  • Home first paint: the cached region key in home_last.ts ignored show, so a cached unfiltered paint was served to ?show=mine. It now includes show.
  • Tests: each of the three kinds appears, another person's post and another repo's crew post do not, and a private post doesn't leak to a non-reader. They also cover the parseShow allowlist, the page indicator, and show=mine surviving in the live link. The "does not" cases are checked against the unfiltered timeline, so they would fail without the filter. The how-to is a "Mine" section in docs/features/feed-cursor.md.

I left out filters other than mine, a Mine toggle on the ranked (non-timeline) feed, and a terminal or MCP door for it. The timeline API (/api/v1/feed) has no show parameter yet.

Try: open /feed?show=mine on the preview and toggle the Mine link.

🤖 Generated with Claude Code

commented

The feed now has a Mine filter. ?show=mine narrows the timeline to my posts, replies to them, and the crew on my repositories, and the filter is carried through home's cursor and variant query.

This push: the earlier push failed the gate's rule that comment lines wrap at 100 columns. I rewrapped two comments, one in src/feed/mine.ts and one in src/web/studio/home_last.ts. bun scripts/gate.ts and bun x tsc --noEmit are now clean, and test/feed-mine.test.ts passes (4 tests).

Not run: the full fast test selection. scripts/fast.ts named 1905 of 3238 files, with an estimated run of about 160 minutes, so I ran only test/feed-mine.test.ts. The forge's own check runs the rest on this push.

Deploy log: the refused cross-origin mutation lines for POST /_measure come from a measurement beacon posting with an :8080 origin against the https origin the app expects. I didn't touch that path and left it alone. The deploy status also said "no tests declared, none run".

Not done: Mine has no new UI beyond the query parameter and the filter control the feed already uses. Nothing is cached per viewer.

Try it: open /feed?show=mine while signed in.

Changes requested — before the latest push

The filter works server-side, is allowlisted, narrows after the visibility filters (no private leak), and the live/older links keep it. Two things to fix: (1) Both doors: there is no terminal screen. The pull says it leaves out the terminal; the rule says what a person can do on the page they can do in src/tui/. Add the Mine toggle to the feed screen in src/tui/ (entry per AGENTS.md), reading through the same readTimeline mine option, with a test. (2) Design principle 1: the chip bar says the filter twice (Mine ✓ and a long sentence, and Showing everything when off). Keep the chip with aria-current and drop the explaining sentence, or reduce it to one short phrase shown only when on. Also add a test for pull.commented replies (the code handles them, only issue.commented is tested). Direction note: this is a feature while the pipeline-first list is open; the change is small and single-purpose, so I do not block on that.

commented

The terminal feed now has Mine, the web chip bar says it once, and pull.commented has a test. The gate is clean after the final push, tsc is clean and design-lint is clean. I ran only test/feed-mine.test.ts and test/tui-feed-mine.test.ts (both pass), not the full fast selection (about 160 minutes here); the forge's check runs the rest.

  • Terminal: in the feed screen in src/tui/screens/feed.ts, m toggles "only mine". It reads readTimeline({ mine: true }), the same option as ?show=mine, so it uses the timeline view as the page does. t still toggles ranked and newest-first, and pressing it while Mine is on drops back to the ranked feed. test/tui-feed-mine.test.ts presses m as alice and checks bob's post disappears and returns on a second m.
  • Page: I removed the "Showing…" sentence from src/web/studio/feed.ts. The Mine / Mine ✓ chip with aria-current is the only signal. The page test now asserts no "Showing" text in either state.
  • pull.commented test: a new test in test/feed-mine.test.ts shows a comment on my conversation is kept and one on someone else's is dropped. The two conversations are created with no issue.opened event, so the comment is the only post naming each. A pull is an issue row in this repo, so the test uses a bare issue rather than a real pull.

I added no palette entry for the terminal door. Mine is a key inside the existing Feed screen rather than a new screen, so ENTRIES is unchanged.

To try it, open /feed?show=mine signed in, or open Feed in the terminal and press m.

commented

The feed has a Mine filter: ?show=mine narrows the timeline to my posts, replies to them and the crew on my repositories. In the terminal feed, m does the same.

The failing check was one over-long header comment in src/tui/screens/feed.ts. Line 11 was past the 160-column limit that test/header-width.test.ts enforces. I wrapped the comment and changed no code. That test and bun x tsc --noEmit both pass locally.

The other 11 failures are not from this pull. The check log says they were already red on main at 870e51b:

  • test/release-handover-keepalive.test.ts
  • test/apps-open-host.test.ts
  • test/ask-to-reach.test.ts
  • test/check-install.test.ts

I did not touch them.

To try it, open the feed with ?show=mine, or press m on the terminal feed's all-posts view (t).

Changes requested — before the latest push

Works and is clean: allowlisted ?show=, narrowing after the visibility filters, one chip with aria-current, no script, terminal key m, pull.commented tested. One miss: the how-to in docs/features/feed-cursor.md describes only the page; the terminal door (m on the Feed screen, and that t drops Mine) is undocumented, and both doors need their how-to. Add one sentence. Not blocking: add a test where the filter itself, not only the audience filter, is shown not to leak. Direction note: a feature ahead of the pipeline list, but small and single-purpose.

commented

The feed has a Mine filter. /feed?show=mine narrows the timeline to the viewer's own: their posts, replies to their posts, and what the crew did on repositories they administer (src/feed/mine.ts). It only narrows events the viewer can already read. Unknown show values are ignored, and one "Mine" chip toggles the filter.

In the terminal, m on the Feed screen toggles only-mine. It uses the same mine option of readTimeline, and t from there returns to the ranked feed.

Changes after review:

  • Docs: docs/features/feed-cursor.md now explains the terminal side as well as the page (the m and t behaviour above), and links its code and test.
  • New test: test/feed-mine.test.ts now calls mineFilter directly, with no audience filter in front of it. The events are on Bob's private repository: someone else's reply, the crew's pull and someone else's post. Alice gets false for all three, and Bob gets true for the same events. So the predicate does not leak on its own, not just because the visibility filters run first.

bun scripts/gate.ts, bun x tsc --noEmit, test/feed-mine.test.ts and test/tui-feed-mine.test.ts all pass locally.

To try it, open /feed?show=mine signed in, or press m on the terminal's Feed screen.

🤖 Generated with Claude Code

Approved

Earlier asks: (1) terminal door is met: m on the Feed screen toggles only-mine through the same mine option of readTimeline, with a headless test; (2) design principle 1 is met: the "Showing…" sentence is gone and the Mine / Mine ✓ chip with aria-current is the single signal, asserted absent in the test; (3) a pull.commented test exists. The how-to is in docs/features/feed-cursor.md, not README. Phone-wise the chip is a plain link, keyboard-reachable, and works with JS off.

Next, non-blocking: Non-blocking: give the chip a visible focus/tap target of at least 44px on a 360px phone. Non-blocking: add show to the JSON feed API and MCP so the third door matches.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs