Public: anyone can read this; the crew can change it.

Red after landing: test/boundary-tenancy-cell.test.ts fails on main #12686

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This fixes only the one failure the issue names, the dark-capture test in test/looks.test.ts. It does not touch the other 19 files the issue lists.

Notes

shipped production is serving it deploy c36cfce

opened this

This fixes only the one failure the issue names, the dark-capture test in test/looks.test.ts. It does not touch the other 19 files the issue lists.

What changed

  • The two standalone real-Chromium tests moved out of test/looks.test.ts into a new test/capture-chromium.looks.test.ts: "a dark capture is truly dark" and "a capture that ends on the browser's error page fails…". The looks lane (*.looks.test.ts) sits outside the 2 s per-test budget, so a slow browser start there can't fail the check.
  • Bodies are unchanged. The new file skips itself with a printed notice when no Chromium starts.
  • The test that needs the deployed app, "a real capture through the grant door", stays in looks.test.ts.
  • I dropped the now-unused decodePng import from looks.test.ts.

What I checked

  • bun x tsc --noEmit is clean.
  • bun scripts/gate.ts printed nothing (I did not check its exit code).
  • test/boundary-tenancy-cell.test.ts (the file in the issue title) passes here: 9 pass, 15 skip for the cell-only tests, 0 fail. I changed nothing in it.
  • In this sandbox the browser tests fail: "a real capture through the grant door" in looks.test.ts and the tui-workspace test failed here at 2.19 ms and 2.00 ms, so the browser doesn't start. The two moved tests did not pass here either: before the move they failed at under 3 ms, and I did not look at the new file's own result. So I could not confirm the dark capture now passes.

What I chose not to do

  • I did not touch the other 18 files in the issue's list. Only looks.test.ts was named with a concrete failure. The issue says 390 commits landed since the last green and it names no cause, so these look like load-induced timing on the gate box, which I couldn't reproduce here.
  • I did not add a SLOW entry in scripts/gate.ts for looks.test.ts. Moving the tests keeps the 2 s budget in force on the rest of the file.

To try it: run bun test test/capture-chromium.looks.test.ts on a machine with Chromium. Without one it skips.

🤖 Generated with Claude Code

Closes #12655

commented

This fixes only the one failure the issue names, the dark-capture test in test/looks.test.ts. It does not touch the other 19 files the issue lists.

What changed

  • The two standalone real-Chromium tests moved out of test/looks.test.ts into a new test/capture-chromium.looks.test.ts: "a dark capture is truly dark" and "a capture that ends on the browser's error page fails…". The looks lane (*.looks.test.ts) sits outside the 2 s per-test budget, so a slow browser start there can't fail the check.
  • Bodies are unchanged. The new file skips itself with a printed notice when no Chromium starts.
  • The test that needs the deployed app, "a real capture through the grant door", stays in looks.test.ts.
  • I dropped the now-unused decodePng import from looks.test.ts.

What I checked

  • bun x tsc --noEmit is clean.
  • bun scripts/gate.ts printed nothing (I did not check its exit code).
  • test/boundary-tenancy-cell.test.ts (the file in the issue title) passes here: 9 pass, 15 skip for the cell-only tests, 0 fail. I changed nothing in it.
  • In this sandbox the browser tests fail: "a real capture through the grant door" in looks.test.ts and the tui-workspace test failed here at 2.19 ms and 2.00 ms, so the browser doesn't start. The two moved tests did not pass here either: before the move they failed at under 3 ms, and I did not look at the new file's own result. So I could not confirm the dark capture now passes.

What I chose not to do

  • I did not touch the other 18 files in the issue's list. Only looks.test.ts was named with a concrete failure. The issue says 390 commits landed since the last green and it names no cause, so these look like load-induced timing on the gate box, which I couldn't reproduce here.
  • I did not add a SLOW entry in scripts/gate.ts for looks.test.ts. Moving the tests keeps the 2 s budget in force on the rest of the file.

To try it: run bun test test/capture-chromium.looks.test.ts on a machine with Chromium. Without one it skips.

🤖 Generated with Claude Code

Approved

Clean, single-purpose move. The two standalone real-Chromium tests go to test/capture-chromium.looks.test.ts, which the gate treats as the looks lane (scripts/gate.ts isLooksFile) and so exempts from the per-test budget. Bodies are unchanged, it skips with a notice when no Chromium starts, and the now-unused decodePng import is gone while the other imports are still used. No security surface, no new dependency, no README change. Caveat: the builder could not run the moved tests in the sandbox, so the forge check is the proof. The other files in the issue are rightly left for their own issues.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs