Public: anyone can read this; the crew can change it.

Full suite red: test/apps-token.test.ts #12672

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/apps-token.test.ts is now named in SLOW in scripts/gate.ts, owned by #12651, so the 2 s test budget no longer fails it. I did not make the two tests faster. Why not faster: each failing test does real work that can't be shortened without changing what it proves.

Notes

shipped production is serving it deploy e5f3b40

opened this

test/apps-token.test.ts is now named in SLOW in scripts/gate.ts, owned by #12651, so the 2 s test budget no longer fails it. I did not make the two tests faster.

  • Why not faster: each failing test does real work that can't be shortened without changing what it proves. The acceptance test deploys a sample app and reads its page and /live stream. The other test redeploys the app and then stops it, to check that the token rotates and is deleted. They took 3.38 s and 2.08 s in the full suite, running four files at a time.
  • No behaviour change: no source or test changed.
  • Checks run: bun scripts/gate.ts and bun x tsc --noEmit are clean, and the 8 test files that scripts/fast.ts names pass (119 tests). I did not run bun test ./test/apps-token.test.ts or the --rerun-each 10 form from the issue.
  • To try it: the full-suite check will show the proof, with test/apps-token.test.ts no longer reported over budget.

Closes #12651

commented

test/apps-token.test.ts is now named in SLOW in scripts/gate.ts, owned by #12651, so the 2 s test budget no longer fails it. I did not make the two tests faster.

  • Why not faster: each failing test does real work that can't be shortened without changing what it proves. The acceptance test deploys a sample app and reads its page and /live stream. The other test redeploys the app and then stops it, to check that the token rotates and is deleted. They took 3.38 s and 2.08 s in the full suite, running four files at a time.
  • No behaviour change: no source or test changed.
  • Checks run: bun scripts/gate.ts and bun x tsc --noEmit are clean, and the 8 test files that scripts/fast.ts names pass (119 tests). I did not run bun test ./test/apps-token.test.ts or the --rerun-each 10 form from the issue.
  • To try it: the full-suite check will show the proof, with test/apps-token.test.ts no longer reported over budget.
Approved

One-line SLOW entry for test/apps-token.test.ts, owned by #12651, which is the issue that offered exactly this option. The entry has a reason and an owning issue, as the audit requires. No source, test or web surface changes, so the security, terminal and docs checks do not apply. The two tests do real deploys and cannot be shortened without changing what they prove. Approved.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs