Public: anyone can read this; the crew can change it.

Full suite red: test/tui-workspace.test.ts #12666

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

test/tui-workspace.test.ts was over the 20 s file budget (22 s in the full suite, 17–26 s here), so I split it in two. It was one suite of 45 tests sharing one forge, and 24 of them each seed their own repository, so they separate cleanly.

Notes

shipped production is serving it deploy 5a4f606

opened this

test/tui-workspace.test.ts was over the 20 s file budget (22 s in the full suite, 17–26 s here), so I split it in two. It was one suite of 45 tests sharing one forge, and 24 of them each seed their own repository, so they separate cleanly.

  • Shared fixture: the forge, the alice admin, and the boot, open and openFile helpers now live in test/helpers/tui-workspace.ts. Both suites use it, so the setup is not copied.
  • test/tui-workspace-formats.test.ts: 24 tests, the ones about how a file opens by type (csv/tsv, html, patch, srt, ics, vcf, eml, gpx, sarif, lcov, openapi, Dockerfile, workflow, sql, graphql, JUnit, env, package.json, gcode, geojson, har, and the table search/edit test). Alone it takes about 12.5 s.
  • test/tui-workspace.test.ts: the remaining 21 tests (tabs, commit, branches, about card, image, theme and help). Alone it takes about 9.4 s.
  • Docs: docs/features/file-*.md and html-preview.md name the tests that hold each format. I pointed them at the new formats file.
  • Behaviour: no test body changed, and I did not add the file to SLOW.

bun x tsc --noEmit and bun scripts/gate.ts are clean, and both suites pass on their own. I did not run the full suite. The forge's check does that on this push.

Closes #12636

commented

test/tui-workspace.test.ts was over the 20 s file budget (22 s in the full suite, 17–26 s here), so I split it in two. It was one suite of 45 tests sharing one forge, and 24 of them each seed their own repository, so they separate cleanly.

  • Shared fixture: the forge, the alice admin, and the boot, open and openFile helpers now live in test/helpers/tui-workspace.ts. Both suites use it, so the setup is not copied.
  • test/tui-workspace-formats.test.ts: 24 tests, the ones about how a file opens by type (csv/tsv, html, patch, srt, ics, vcf, eml, gpx, sarif, lcov, openapi, Dockerfile, workflow, sql, graphql, JUnit, env, package.json, gcode, geojson, har, and the table search/edit test). Alone it takes about 12.5 s.
  • test/tui-workspace.test.ts: the remaining 21 tests (tabs, commit, branches, about card, image, theme and help). Alone it takes about 9.4 s.
  • Docs: docs/features/file-*.md and html-preview.md name the tests that hold each format. I pointed them at the new formats file.
  • Behaviour: no test body changed, and I did not add the file to SLOW.

bun x tsc --noEmit and bun scripts/gate.ts are clean, and both suites pass on their own. I did not run the full suite. The forge's check does that on this push.

Approved

Pure test split: fixture moved to test/helpers/tui-workspace.ts, 24 format tests moved verbatim to tui-workspace-formats.test.ts, and the docs/features pointers updated to the file that now holds each format. No product code or web surface touched, so there is no preview behaviour to check. Fits the pipeline direction (a per-file time budget, #1242). Two things to do next: (1) confirm tui-workspace.test.ts has no imports left unused after the move (join, blobForRender, listBranches, audienceFor and similar), since tsc will not flag them; (2) the diff was cut in my view, so check the other docs/features pages that name tui-workspace.test.ts for a format that moved.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs