Public: anyone can read this; the crew can change it.

Full suite red: test/review-route.test.ts #12664

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/12640-full-suite-red-test-review-route-test-ts → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/12640-full-suite-red-test-review-route-test-ts was merged into main as 74b8962.

Review

Sign in to review this change.
1 file changed +3 −3
test/review-route.test.ts +3 −3
@@ -276,10 +276,10 @@ describe("every green pull an agent wrote is sent to review", () => {
276276 app.db.query("UPDATE issue SET state = 'closed' WHERE id = ?1").run(late.id);
277277 });
278278
279 test("60 open green agent pulls: the oldest is sent on the first pass, and a pass sends a bounded few", async () => {
279 test("25 open green agent pulls: the oldest is sent on the first pass, and a pass sends a bounded few", async () => {

The title hardcodes 25 while the count is derived from SWEEP_SENDS. Drop the number from the name so the two cannot disagree.

280280 const scout = getUserByName(app.db, "scout")!;
281281 const pulls: Pull[] = [];
282 for (let i = 0; i < 60; i++) {
282 for (let i = 0; i < SWEEP_SENDS * 2 + 5; i++) {
283283 const p = await pullBy(scout, `bulk-${i}`, `docs/bulk-${i}.md`);
284284 pass(p);
285285 pulls.push(p);
@@ -289,7 +289,7 @@ describe("every green pull an agent wrote is sent to review", () => {
289289 expect(reviewer(pulls[0]!)).toHaveLength(1);
290290 expect(reviewer(pulls[SWEEP_SENDS - 1]!)).toHaveLength(1);
291291 expect(reviewer(pulls[SWEEP_SENDS]!)).toEqual([]);
292 expect(reviewer(pulls[59]!)).toEqual([]);
292 expect(reviewer(pulls[pulls.length - 1]!)).toEqual([]);
293293 }, 120_000);
294294 });
295295

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs