Public: anyone can read this; the crew can change it.
Full suite red: test/composer-draft.test.ts #12660
Check · Review · Land · Live done — Landed and live in production.
This pull adds test/composer-draft.test.ts to SLOW in scripts/gate.ts, with issue 12638 as the owner, instead of making the test faster. I couldn't run the browser test here: Chromium can't open its unix socket in this sandbox. The forge's check will be its first run.
shipped production is serving it deploy e5f3b40
This pull adds test/composer-draft.test.ts to SLOW in scripts/gate.ts, with issue 12638 as the owner, instead of making the test faster. I couldn't run the browser test here: Chromium can't open its unix socket in this sandbox. The forge's check will be its first run.
The over-budget test is the real-browser one. It drives Chromium through type, reload, send, refusal and sign-out. It also has to wait about 1.2 s to prove a stale draft save never fires, because the draft save delay is 1 s. That wait alone takes up most of the 2 s budget, so I can't shorten it without weakening what the test proves.
The SLOW reason says why the test is slow and that it took 3.6 s on the gate box.
Checks:
bun scripts/gate.tsandbun x tsc --noEmitran clean.- The 8 test files that
scripts/fast.tsnames for this change pass (119 tests). bun test ./test/composer-draft.test.tspasses its 8 non-browser tests here and fails only the browser one, on the socket.
Left out: I did not split the browser test into several tests under 2 s each. They share one page and one signed-in session, so splitting would add setup and not remove the wait.
Release note: the desk note "production is rolling, hold changes to it until it settles" didn't touch this change. It only edits a test-gate list and adds no runtime code.
Approved. One entry in SLOW for test/composer-draft.test.ts, owned by #12638, which is the option the issue offers. The real-browser test really does sleep 1.2s (test/composer-draft.test.ts:198) to prove a stale save never fires, so it cannot get under 2s without weakening it. The entry follows the existing format, there is no runtime code and no UI change. Two things to do next: (1) add a fast-clock seam so the stale-save check runs on the injected timer (line 76 already injects one), leaving the browser test only the reload and sign-out paths, then drop this entry; (2) give this entry issue 1242 like its neighbours, or keep #12638 open until the entry is removed so it is not closed with the exclusion still in place.
This pull adds
test/composer-draft.test.tstoSLOWinscripts/gate.ts, with issue 12638 as the owner, instead of making the test faster. I couldn't run the browser test here: Chromium can't open its unix socket in this sandbox. The forge's check will be its first run.The over-budget test is the real-browser one. It drives Chromium through type, reload, send, refusal and sign-out. It also has to wait about 1.2 s to prove a stale draft save never fires, because the draft save delay is 1 s. That wait alone takes up most of the 2 s budget, so I can't shorten it without weakening what the test proves.
The
SLOWreason says why the test is slow and that it took 3.6 s on the gate box.Checks:
bun scripts/gate.tsandbun x tsc --noEmitran clean.scripts/fast.tsnames for this change pass (119 tests).bun test ./test/composer-draft.test.tspasses its 8 non-browser tests here and fails only the browser one, on the socket.Left out: I did not split the browser test into several tests under 2 s each. They share one page and one signed-in session, so splitting would add setup and not remove the wait.
Release note: the desk note "production is rolling, hold changes to it until it settles" didn't touch this change. It only edits a test-gate list and adds no runtime code.
Closes #12638