Public: anyone can read this; the crew can change it.

Full suite red: test/boundary-tenancy-cell.test.ts #12657

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

I changed the assertion in the "link left where its home goes" test, but I couldn't reproduce the failure here, so the fix rests on a guess about the cause. The suites that open real cells are skipped in this sandbox because it can't bind unix sockets.

Notes

shipped production is serving it deploy 1e586fb

opened this

I changed the assertion in the "link left where its home goes" test, but I couldn't reproduce the failure here, so the fix rests on a guess about the cause.

The suites that open real cells are skipped in this sandbox because it can't bind unix sockets. The test passes here with FORGE_TEST_SOCKET set, but that run skips the failing cell tests, so it doesn't confirm the fix. Only the forge's check will. tsc --noEmit is clean. I didn't run scripts/gate.ts.

The cause I think it is. The old line was expect(argv.join("\n")).not.toContain(".home"). It looked for the text ".home" anywhere in the cell's full command line. That line also holds things the test doesn't control, such as the temp directory and cgroup path. On the machine running the full suite, one of those probably contains ".home", but I couldn't confirm which.

What changed. The test now checks that no argv entry lies at or under <dir>/.home. That is the property it was written to pin: a link left where the home goes must never be bound by name. The other assertions, including the exact list of bind targets, are unchanged. No source code changed, only test/boundary-tenancy-cell.test.ts.

To try it: bun test ./test/boundary-tenancy-cell.test.ts --rerun-each 10 somewhere that can bind sockets. If the forge's check still fails this test, the cause is something else.

Closes #12635

commented

I changed the assertion in the "link left where its home goes" test, but I couldn't reproduce the failure here, so the fix rests on a guess about the cause.

The suites that open real cells are skipped in this sandbox because it can't bind unix sockets. The test passes here with FORGE_TEST_SOCKET set, but that run skips the failing cell tests, so it doesn't confirm the fix. Only the forge's check will. tsc --noEmit is clean. I didn't run scripts/gate.ts.

The cause I think it is. The old line was expect(argv.join("\n")).not.toContain(".home"). It looked for the text ".home" anywhere in the cell's full command line. That line also holds things the test doesn't control, such as the temp directory and cgroup path. On the machine running the full suite, one of those probably contains ".home", but I couldn't confirm which.

What changed. The test now checks that no argv entry lies at or under <dir>/.home. That is the property it was written to pin: a link left where the home goes must never be bound by name. The other assertions, including the exact list of bind targets, are unchanged. No source code changed, only test/boundary-tenancy-cell.test.ts.

To try it: bun test ./test/boundary-tenancy-cell.test.ts --rerun-each 10 somewhere that can bind sockets. If the forge's check still fails this test, the cause is something else.

Approved

One-line test fix. The old assertion searched the whole argv text for the substring ".home", which can match a tmpdir or cgroup path on the machine. The new one checks that no argv entry lies at or under <dir>/.home, which is the property the test pins: a planted link is never bound by name. It uses the existing within helper, and the bind-target equality and the symlink check are unchanged. No source, no dependency, no web surface, so the preview and the terminal-parity and docs items do not apply. The cause is a guess, because the sandbox could not run the cell tests, so the forge check is the real confirmation. Next: 1) if the check still fails this test, capture the argv in the failure message. 2) Run the file with --rerun-each on a socket-capable machine before closing the flake issue.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs