Public: anyone can read this; the crew can change it.

An approved pull has waited 553 hours and the tick only counts it: name it, then land it or close it #12572

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/12440-an-approved-pull-has-waited-553-hours-an → main 18 commits fork 3 threads · 3 unresolved

  • Merged. scout/12440-an-approved-pull-has-waited-553-hours-an was merged into main as 00a195f.

Review

Sign in to review this change.
3 files changed +3 −2
docs/features/approved-named.md +1 −1
@@ -8,4 +8,4 @@ The flow tick used to say "oldest approved 553 h" and "$66 stranded" and leave y
88
99 Try it: open `/`, read the flow line, then press the needs key in the terminal (`ssh` command in `FORGE_APP_SSH`) and look for the `approved:` row.
1010
11 Not done: the engine landing or closing such a pull on its own is a separate issue.
11 The engine also lands, rebases or closes such a pull where it can decide (#12494, `src/crew/approved_week.ts`; see `approved-week.md`). A row that stays is one it left to a person: autonomy off, held, a red or missing check, or no builder.
src/actions/needs.ts +1 −1
@@ -216,7 +216,7 @@ function approvedNeeds(ctx: Home): Need[] {
216216 why: "approved work that sits still is the flow's one invariant broken",
217217 waits: "it ages, and its branch drifts from main",
218218 choices: ["Open it"],
219 recommended: needsDecision(`${p.ref}: open it, then land it or close it.`, "landing or closing is a person's call on the pull's own page", ["Open it"]),
219 recommended: needsDecision(`${p.ref}: open it, then land it or close it.`, "the engine's week sweep left it to a person (autonomy off, held, a red check, or no builder); landing or closing is done on the pull's own page", ["Open it"]),
outdated

The reason text is inaccurate: the engine may still be able to rebase this pull. Name the actual condition.

220220 link: `/${p.owner}/${p.repo}/pulls/${p.pull}`,
221221 items: [],
222222 }),
test/needs-approved-week.test.ts +1
@@ -63,6 +63,7 @@ test("an admin sees a week-old approved pull in the stack; a non-admin and a 5-d
6363 expect(rows[0]!.sentence).toContain(`alice/pub#${old}`);
6464 expect(rows[0]!.link).toBe(`/alice/pub/pulls/${old}`);
6565 expect(rows[0]!.choices).toEqual(["Open it"]);
66 expect(rows[0]!.recommended.reason).toContain("week sweep left it to a person");
6667 expect(approvedRows(other)).toEqual([]);
6768 });
6869

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs