Public: anyone can read this; the crew can change it.

An unclaimed one-click start is reachable by its link but not listed on /explore, the explore API or llms.txt until it is claimed #12562

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

An app made by the anonymous one-click start (actions/start.ts) is now left off /explore, /api/v1/explore, /explore.atom, the app list in /llms.txt and /sitemap.xml while its owner is an unclaimed start. It still answers at its own URL. A claim lists it again with no further step.

Notes

shipped production is serving it deploy d73d768

opened this

An app made by the anonymous one-click start (actions/start.ts) is now left off /explore, /api/v1/explore, /explore.atom, the app list in /llms.txt and /sitemap.xml while its owner is an unclaimed start. It still answers at its own URL. A claim lists it again with no further step.

What changed

  • The filter: listReposVisibleTo in src/core/repos.ts takes a new option, withoutUnclaimed. It drops a repository when its owner has a start_account row with claimed_at IS NULL. As the issue's risk note asked, it filters on the start's state and not on visibility, so the link a starter shares keeps working.
  • Where it is used: explore's ranking (src/actions/explore.ts) passes the option, and so do the sitemap and llms.txt lists (src/core/listings.ts). That covers all five outputs, because the page, the API, the MCP tool and the atom feed all read explore's ranking. The unclaimed owner's "person" row goes too, since people are only listed as owners of apps shown.
  • The claim: after a successful claim, claimStart in src/actions/claim.ts calls forgetListings. The one-minute llms.txt and sitemap caches then don't keep hiding the app. Explore's cache already resets on any database write.
  • The test: test/start-unlisted.test.ts starts an anonymous forge and checks that its page answers but none of the five outputs names it. It then claims it and checks that all five name it. With the source change taken out, the test fails on /explore.

Not done

  • Nothing is deleted, and the sleep/archive sweep is unchanged.
  • An unclaimed start is hidden from every viewer, admins included.
  • The keep_plan and estimate tools were not available in this run, so there is no plan on the issue and no time estimate.

Checks

  • bun scripts/gate.ts and bun x tsc --noEmit both pass.
  • scripts/fast.ts said the change was too broad to pick tests for, because core/repos.ts reaches most of the suite. I ran the 49 files that cover it instead: the new test, start/claim, explore*, llms-*, the MCP and TUI explore tests, sitemap and listings. 327 passed, 0 failed.

To try it Start a forge with POST /api/v1/start {"name":"x"}. Its owner/x page answers, but /explore and /llms.txt don't name it. Open the returned claim link while signed in, and both name it. After release, the issue's production check is curl -s $PROD/explore | grep -c admin-ada0, which should print 0.

🤖 Generated with Claude Code

Closes #12559

2 earlier comments · 1 event
commented

An app made by the anonymous one-click start (actions/start.ts) is now left off /explore, /api/v1/explore, /explore.atom, the app list in /llms.txt and /sitemap.xml while its owner is an unclaimed start. It still answers at its own URL. A claim lists it again with no further step.

What changed

  • The filter: listReposVisibleTo in src/core/repos.ts takes a new option, withoutUnclaimed. It drops a repository when its owner has a start_account row with claimed_at IS NULL. As the issue's risk note asked, it filters on the start's state and not on visibility, so the link a starter shares keeps working.
  • Where it is used: explore's ranking (src/actions/explore.ts) passes the option, and so do the sitemap and llms.txt lists (src/core/listings.ts). That covers all five outputs, because the page, the API, the MCP tool and the atom feed all read explore's ranking. The unclaimed owner's "person" row goes too, since people are only listed as owners of apps shown.
  • The claim: after a successful claim, claimStart in src/actions/claim.ts calls forgetListings. The one-minute llms.txt and sitemap caches then don't keep hiding the app. Explore's cache already resets on any database write.
  • The test: test/start-unlisted.test.ts starts an anonymous forge and checks that its page answers but none of the five outputs names it. It then claims it and checks that all five name it. With the source change taken out, the test fails on /explore.

Not done

  • Nothing is deleted, and the sleep/archive sweep is unchanged.
  • An unclaimed start is hidden from every viewer, admins included.
  • The keep_plan and estimate tools were not available in this run, so there is no plan on the issue and no time estimate.

Checks

  • bun scripts/gate.ts and bun x tsc --noEmit both pass.
  • scripts/fast.ts said the change was too broad to pick tests for, because core/repos.ts reaches most of the suite. I ran the 49 files that cover it instead: the new test, start/claim, explore*, llms-*, the MCP and TUI explore tests, sitemap and listings. 327 passed, 0 failed.

To try it Start a forge with POST /api/v1/start {"name":"x"}. Its owner/x page answers, but /explore and /llms.txt don't name it. Open the returned claim link while signed in, and both name it. After release, the issue's production check is curl -s $PROD/explore | grep -c admin-ada0, which should print 0.

🤖 Generated with Claude Code

commented

An anonymous start is the forge someone launches without signing in, through POST /api/v1/start. Until it is claimed, it is kept off /explore, /llms.txt and the sitemap. src/core/repos.ts and src/core/listings.ts decide what is hidden, and src/actions/explore.ts applies that. Once someone claims the start, claimStart in src/actions/claim.ts calls forgetListings, so its repositories come back on all three without any other step. test/start-unlisted.test.ts covers both halves: the start is missing from all three listings before the claim and appears on all of them after.

The last push failed the gate because one comment in src/actions/claim.ts was 102 columns long. It is now split across two lines, and no code changed.

Checks run here: bun scripts/gate.ts and bun x tsc --noEmit both pass. These test files pass, 51 tests in total:

  • test/start-unlisted.test.ts
  • test/claim-link.test.ts
  • test/claim-revoke.test.ts
  • test/explore-count.test.ts
  • test/explore-api-paging.test.ts

bun scripts/fast.ts named 2775 of 3203 test files for this branch, about four hours against a five-minute budget. That is too broad to run here, so the forge's check covers the rest.

To try it on the preview: start an anonymous forge with POST /api/v1/start, then open /explore and /llms.txt; the new forge is not listed. Claim it at the link the start returns, and both pages list it.

🤖 Generated with Claude Code

Approved

Approved. The filter sits in one place (visibleClause), covers explore/API/atom/llms/sitemap, claim calls forgetListings so the caches do not keep hiding it, and the test covers all five outputs before and after a claim. On the preview /explore and /llms.txt name neither admin-ada0 nor bad-name-12dd; production still lists admin-ada0 (4 matches), as expected before release. Two next things: (1) add a unit test that an admin viewer also does not see an unclaimed start, since that is a stated choice; (2) wrap the long WHERE line in repos.ts to match the file style and confirm the start_account.user_id lookup is indexed.

commented

Left #12559 open: 1 unticked item remain (On production after release: /explore no longer lists admin-ada0 or bad-name-12dd (check with curl -s $PROD/explore | grep -c admin-ada0 = 0).).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs