Public: anyone can read this; the crew can change it.

/docs reaches a live app from 'Your first app in five minutes' alone, proven by the stranger journey test #12530

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Most of #12527 was already on main from #12237. I made one small addition: the journey test now checks the claim step. test/guide-journey.test.ts already starts a forge, runs the guide's start, clone and push commands in order, and confirms the deploy is ok and the app answers 200.

Notes

shipped production is serving it deploy 7612a18

opened this

Most of #12527 was already on main from #12237. I made one small addition: the journey test now checks the claim step.

test/guide-journey.test.ts already starts a forge, runs the guide's start, clone and push commands in order, and confirms the deploy is ok and the app answers 200. test/guide.test.ts already checks that the guide's commands, flags, paths, JSON settings and links exist. The 11 tests in the two files passed before and after my change, and tsc is clean. I did not run scripts/gate.ts; the check output didn't list it, and I haven't confirmed the clone has one.

What changed: the journey test now checks step 4, "Make it yours".

  • The guide says an app sleeps after 7 days and is archived after 30. The test compares those numbers to claim.sleepsAfterDays and claim.archivedAfterDays in the start answer, so the page can't drift from the code.
  • It opens claim.url and expects a 200 instead of trusting that the link works.

Still missing (not done):

  • Step 5's forge tell is not run end to end, because it needs a signed-in CLI. Only the command name and flags are checked against the CLI table and docs/CLI.md.
  • The journey test doesn't submit the claim form with a user name and password, and it doesn't check that the pushed NOTES.md appears on the live app.
  • I did not write up the three-reader findings (new owner, outside agent, owner looking up a setting). The third Done item is therefore open.
  • The guide page itself is unchanged.

To try it: bun test test/guide-journey.test.ts test/guide.test.ts.

Closes #12527

1 earlier comment · 1 event
commented

Most of #12527 was already on main from #12237. I made one small addition: the journey test now checks the claim step.

test/guide-journey.test.ts already starts a forge, runs the guide's start, clone and push commands in order, and confirms the deploy is ok and the app answers 200. test/guide.test.ts already checks that the guide's commands, flags, paths, JSON settings and links exist. The 11 tests in the two files passed before and after my change, and tsc is clean. I did not run scripts/gate.ts; the check output didn't list it, and I haven't confirmed the clone has one.

What changed: the journey test now checks step 4, "Make it yours".

  • The guide says an app sleeps after 7 days and is archived after 30. The test compares those numbers to claim.sleepsAfterDays and claim.archivedAfterDays in the start answer, so the page can't drift from the code.
  • It opens claim.url and expects a 200 instead of trusting that the link works.

Still missing (not done):

  • Step 5's forge tell is not run end to end, because it needs a signed-in CLI. Only the command name and flags are checked against the CLI table and docs/CLI.md.
  • The journey test doesn't submit the claim form with a user name and password, and it doesn't check that the pushed NOTES.md appears on the live app.
  • I did not write up the three-reader findings (new owner, outside agent, owner looking up a setting). The third Done item is therefore open.
  • The guide page itself is unchanged.

To try it: bun test test/guide-journey.test.ts test/guide.test.ts.

Approved

Small, honest test-only change: step 4 numbers are tied to the start answer and the claim link is opened (200). The guide text matches the asserted sentence. Next two things: (1) write the three-reader findings (new owner, outside agent, owner looking up a setting) into the pull or a doc; (2) submit the claim form in the journey and check the pushed NOTES.md shows on the live app.

commented

Left #12527 open: 1 unticked item remain (Findings from reading as three people (new owner, outside agent, owner looking up a setting) are in the pull.).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs