Public: anyone can read this; the crew can change it.
A crew member's look appears in the feed with its picture's alt text and a link one step deeper #12448
Check · Review · Land · Live done — Landed and live in production.
A look card in the feed now says what its picture shows, links to the pull and to the look, and holds its size until the picture arrives. It is pushed; the forge's check has not reported yet. I did not call `keep_plan` or `estimate`, so there is no plan on the issue and no time estimate recorded.
shipped production is serving it deploy 9cda780
3 earlier comments · 1 event
A look card in the feed now says what its picture shows, links to the pull and to the look, and holds its size until the picture arrives. It is pushed; the forge's check has not reported yet. I did not call keep_plan or estimate, so there is no plan on the issue and no time estimate recorded.
- Alt text:
src/feed/items.tsgainslookAltand puts the result on the look asalt, so the card and the terminal read the same words. It reads "<app> at 390 px after pull #N", or "… in production" for a production look. The 390 px is the width the issue gave; I did not check it against the stored picture. - Web card: in
src/web/studio/feed.tsthe picture gets that alt text. The card links to the pull (or to the app, for production) and to the look. - Placeholder: a look whose picture is not ready draws a 160×100 block, the same size as the thumbnail, labelled "<alt>: picture not ready". The style is inline, so
src/web/style/components.tsis untouched. - Terminal:
src/tui/screens/feed.tsprints the alt text as the look row's note. - Test: the new
test/feed-look-card.test.tschecks alt, both links, the placeholder size and escaping. It and the other feed and look tests I ran (feed-look-post,feed-card-markup,tui-feed-fold) pass, as dobun x tsc --noEmitandbun scripts/design-lint.ts. I did not runbun scripts/gate.tsor the full suite; the forge runs the full check on push.
Not done: the repo has no HTML page for a single look, so "the look's page" is the thumbnail image URL itself (/<owner>/<app>/looks/<env>/<commit>/thumb.png). Say if you want a real look page and I'll open an issue for it.
Push hook: it refused the first push until a commit message carried a Try: line, so the branch has an extra empty commit for that.
To try it: open the feed on the preview for this pull and find a look card. Its picture should carry the alt text and sit under the links "The pull" and "The look". A look with no ready picture shows the fixed placeholder instead.
🤖 Generated with Claude Code
Both gate failures are fixed and pushed as 5eb4d249d. The gate, tsc --noEmit and test/feed-look-card.test.ts (3 tests) all pass locally; I did not run the rest of the suite.
- Comment width: the header comment on line 1 of
test/feed-look-card.test.tswas 121 columns. It is now a three-line block comment, with the wording unchanged. - Before/after looks: the check's log also listed a second failure:
src/web/studio/feed.tschanged with noLooks:line in any commit message. The new commit carriesLooks: /feed, since/feedis one of the pages listed inforge.json. I added a new commit rather than rewording the earlier ones, because that would need a force push.
The earlier commits already add alt text to a look card's picture, link it to the pull and the look, and reserve its space so the page doesn't shift when the picture arrives. Try it by opening /feed on the preview and finding a look card.
🤖 Generated with Claude Code
Fix first: the look card now has two focusable links to the same png (the image and 'The look'), and neither the card nor the terminal shows the pull link the issue asks for in the same place. Remaining items are in the line comments. Also: README untouched (good), but no docs/features how-to mention and the TUI has no test for the new note.
Most of the review is addressed and pushed as ebf97d91e; two points I did not take as asked (below). The gate, tsc --noEmit, design-lint and the tests for the feed look card, the new terminal note and tui-feed-fold pass locally.
What changed
- One tab stop: the picture is now the only link to the png, so there is no second "The look" link. I made the image the only link rather than a hidden decorative one, so its alt text is what a screen reader hears.
- Pull link: a separate text link reads "Pull #7", or "The app" for production. It sits under the picture and is also the card's only link into the pull.
- Placeholder: the inline style is gone and the size comes from
.look[data-slot="feed"]. Itsaria-labelis now just the alt text, with no "picture not ready" suffix. - Terminal: the note moved into an exported
feedNote(item)insrc/tui/screens/feed.ts, replacing the nested ternary.test/tui-feed-note.test.tsshows that a look's note is its alt text, and a test fails if that line is removed. - Tests:
test/feed-look-card.test.tsnow covers the ready and not-ready branches, each asserting the escaped<script>is present and the raw one is absent. It also covers the "The app" link text and that the card has exactly one link to the png. - Docs: added
docs/features/feed-look.md.
What I chose not to do
- No look page: the picture still links to the png itself, because "one step deeper" means one step to the png and nothing more. I did not build a look page or open an issue for one. Say so if you want that.
- Pull link in the terminal: the terminal still shows only the alt text, not the pull link. The issue's wording asks for the same words as the page's alt text, and the terminal rows have no link.
Both gate failures are fixed and pushed as 045925216. The gate, tsc --noEmit and test/tui-feed-note.test.ts pass locally; I did not run the other tests.
- Comment width: the comment above
feedNoteinsrc/tui/screens/feed.ts(107 columns) is now a three-line block comment with the same words. - "Pipeline first" rule: the new commit carries a
Direction:line saying the look in the feed is what the issue asks for and the card changes answer review feedback on it. I did not add a pipeline change. The pull is still a feature that touches none of the pipeline paths, so that justification now rests on theDirection:line, and a person may want to look at it.
The pull's behaviour is as in my last description. The picture is the only link to the png, "Pull #N" or "The app" names the other link, and the terminal note is the alt text.
Earlier asks are met: one tab stop (the picture is the only link to the png, with the alt text), a text link "Pull #N" / "The app", the placeholder sized by the existing .look[data-slot=feed] rule with no inline style, a feedNote helper with a test, escaping tested on both branches, and docs/features/feed-look.md (README untouched). Next I would do two things. 1) Non-blocking: give the look a real page, so "one step deeper" is more than the png. 2) Non-blocking: make sure the pending span is display:block or inline-block in .look, so the 160x100 size holds. The Direction: line is a stretch for a pipeline-first repo, but this is the issue as filed.
A look card in the feed now says what its picture shows, links to the pull and to the look, and holds its size until the picture arrives. It is pushed; the forge's check has not reported yet. I did not call
keep_planorestimate, so there is no plan on the issue and no time estimate recorded.src/feed/items.tsgainslookAltand puts the result on the look asalt, so the card and the terminal read the same words. It reads "<app> at 390 px after pull #N", or "… in production" for a production look. The 390 px is the width the issue gave; I did not check it against the stored picture.src/web/studio/feed.tsthe picture gets that alt text. The card links to the pull (or to the app, for production) and to the look.src/web/style/components.tsis untouched.src/tui/screens/feed.tsprints the alt text as the look row's note.test/feed-look-card.test.tschecks alt, both links, the placeholder size and escaping. It and the other feed and look tests I ran (feed-look-post,feed-card-markup,tui-feed-fold) pass, as dobun x tsc --noEmitandbun scripts/design-lint.ts. I did not runbun scripts/gate.tsor the full suite; the forge runs the full check on push.Not done: the repo has no HTML page for a single look, so "the look's page" is the thumbnail image URL itself (
/<owner>/<app>/looks/<env>/<commit>/thumb.png). Say if you want a real look page and I'll open an issue for it.Push hook: it refused the first push until a commit message carried a
Try:line, so the branch has an extra empty commit for that.To try it: open the feed on the preview for this pull and find a look card. Its picture should carry the alt text and sit under the links "The pull" and "The look". A look with no ready picture shows the fixed placeholder instead.
🤖 Generated with Claude Code
Closes #12422