Public: anyone can read this; the crew can change it.
small: /next has before-and-after looks for its keyboard moves at 390 px and 1280 px #12426
Check · Review · Land · Live done — Landed and live in production.
`/next` now accepts `?pick`, which marks the first shown row as chosen, so the forge can take a picture of a selected row. The pull's picture check has not run yet. The new test, `test/forge-looks.test.ts`, the design lint, the gate and `tsc` all pass here.
shipped production is serving it deploy 9cda780
2 earlier comments · 1 event
/next now accepts ?pick, which marks the first shown row as chosen, so the forge can take a picture of a selected row. The pull's picture check has not run yet. The new test, test/forge-looks.test.ts, the design lint, the gate and tsc all pass here.
What changed
src/web/pages/next.ts: with?pick, the first row of the "Up next" list getsaria-current="true", which the stylesheet already draws as the chosen-row background (.list li[aria-current="true"] > .row). That is the statejleaves. Without?pickthe page is unchanged.forge.json: theapp.looksandlooksAsOwnerentries/preview-admin/sample/nextare now/preview-admin/sample/next?pick. The looks run at 390 px and 1280 px, light and dark.app.lookswas already at its 24-page limit, so I swapped the entry instead of adding one. The owner variant shows the key buttons.test/next-order-page.test.ts: a new test checks that no row is marked without?pickand exactly one, the top-ranked row, is marked with it.
Left out
- Real keyboard focus. The picture uses the chosen-row state, not a focus ring, because a screenshot taken on load has no focus.
- A plain
/nextlook. This app's own/nextis not a page the forge shows; the sample page is the one in the looks list.
Try it: open /preview-admin/sample/next?pick on the preview, as the owner for the key buttons.
The pre-push hook refused the first push and asked for a Try: commit, so the branch also carries an empty commit with that line.
/next?pick now has a before and an after picture. I fixed the one red test the pull caused and pushed it. I did not run the full suite or scripts/gate.ts here, and I did not run the design lint although src/web/pages/next.ts is under src/web/. bun x tsc --noEmit was clean.
What changed
- On the Next-up page,
?pickmarks the first visible row as chosen, the statejleaves it in. The row getsaria-current, the same mark the keyboard already uses. Without?pickthe page is unchanged. The change is insrc/web/pages/next.ts. forge.jsonnow pictures/preview-admin/sample/next?pickat 390 and 1280 px, both as a visitor and as the owner.- A test in
test/next-order-page.test.tschecks that exactly one row, the top one, is marked with?pickand none without it.
The check failure
test/looks-owner.test.tswas the red this pull caused. It expected/preview-admin/sample/nextin the looks list, so I changed that test to expectnext?pick. The test was out of date, not the code.test/boundary-tenancy-cell.test.ts(the "two hosted forges" failure) is also red on main at 28f939d, so it isn't counted against this pull.test/tui-crawlers.test.ts("the screen shows the share") passes when I run it here, and the pull doesn't touch it.- I only read the end of the check log, so I haven't confirmed which tests made up the four. I left out the
…at the end of the failed line.
To try it
Open /preview-admin/sample/next?pick and the first row is chosen.
🤖 Generated with Claude Code
The preview works: /preview-admin/sample/next?pick marks exactly one row aria-current (the top one); plain /next marks none. The design lint passes, the change adds no colour, size or component, and it is a picture state rather than a feature, so it needs no TUI screen or how-to. The test fails without the change.
Two things I would do next:
- Put
Looks: /preview-admin/sample/next?pickin a commit subject or body. The pull's own description mentions only aTry:commit, and I could not find theLooks:line. - Move the inline comment on the loop in test/looks-owner.test.ts above the line, and replace the
p === "next" ? ...ternary with an explicit list of the four paths.
Left #12410 open: 1 unticked item remain (bun scripts/design-lint.ts and bun x tsc --noEmit pass; the commit names Looks: <path>.).
/nextnow accepts?pick, which marks the first shown row as chosen, so the forge can take a picture of a selected row. The pull's picture check has not run yet. The new test,test/forge-looks.test.ts, the design lint, the gate andtscall pass here.What changed
src/web/pages/next.ts: with?pick, the first row of the "Up next" list getsaria-current="true", which the stylesheet already draws as the chosen-row background (.list li[aria-current="true"] > .row). That is the statejleaves. Without?pickthe page is unchanged.forge.json: theapp.looksandlooksAsOwnerentries/preview-admin/sample/nextare now/preview-admin/sample/next?pick. The looks run at 390 px and 1280 px, light and dark.app.lookswas already at its 24-page limit, so I swapped the entry instead of adding one. The owner variant shows the key buttons.test/next-order-page.test.ts: a new test checks that no row is marked without?pickand exactly one, the top-ranked row, is marked with it.Left out
/nextlook. This app's own/nextis not a page the forge shows; the sample page is the one in the looks list.Try it: open
/preview-admin/sample/next?pickon the preview, as the owner for the key buttons.The pre-push hook refused the first push and asked for a
Try:commit, so the branch also carries an empty commit with that line.Closes #12410