Public: anyone can read this; the crew can change it.

/next has no script-size ceiling in docs/design/size-budget.json #12383

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

mason/forge:mason/12380-next-has-no-script-size-ceiling-in-docs → main 1 commit fork

  • Merged. mason/12380-next-has-no-script-size-ceiling-in-docs was merged into main as 5f89d5b.

Review

Sign in to review this change.
3 files changed +7 −2
docs/design/size-budget.json +4
@@ -19,6 +19,10 @@
1919 "js": 26112,
2020 "css": 43520
2121 },
22 "/:owner/:name/next": {
23 "js": 23040,
24 "css": 44032
25 },
2226 "/pricing": {
2327 "js": 21248,
2428 "css": 43520
src/perf/page_budget.ts +1
@@ -31,6 +31,7 @@ export const PAGE_BUDGETS: readonly PageBudget[] = [
3131 { page: "map", pattern: "/map", medianMs: 50, statements: 21 },
3232 { page: "an app page", pattern: "/:owner/:name", medianMs: 50, statements: 49 },
3333 { page: "changelog", pattern: "/changelog", medianMs: 50, statements: 20 },
34 { page: "next up", pattern: "/:owner/:name/next", medianMs: 50, statements: 64 },
3435 // A stranger's way to a forge (#11410): walked signed out. `/claim` is
3536 // measured on a spawned forge with a live link, as the child's owner sees it.
3637 { page: "pricing", pattern: "/pricing", medianMs: 50, statements: 10, signedOut: true },
test/page-budget.test.ts +2 −2
@@ -139,9 +139,9 @@ async function time(b: PageBudget): Promise<{ samples: number[]; phases: PageMea
139139 return { samples, phases: parsePhases(header) };
140140 }
141141
142 test("the budget table names eight pages, each once, with a median and a statement limit", () => {
142 test("the budget table names nine pages, each once, with a median and a statement limit", () => {
143143 expect(PAGE_BUDGETS.map((b) => b.pattern)).toEqual([
144 "/", "/explore", "/map", "/:owner/:name", "/changelog", "/pricing", "/forges/new", "/claim",
144 "/", "/explore", "/map", "/:owner/:name", "/changelog", "/:owner/:name/next", "/pricing", "/forges/new", "/claim",
145145 ]);
146146 for (const b of PAGE_BUDGETS) {
147147 expect(b.medianMs).toBeLessThanOrEqual(50);

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs