Public: anyone can read this; the crew can change it.

Every empty state on the signed-in home says the one next thing in a sentence, and a test finds none that is blank #12345

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Four home panels (held, stalled flow, milestones, since you were here) now say what to do next when they're empty. Each shows one muted line with a link instead of rendering nothing. I haven't pushed past the local checks, so the forge's full run on this push is the first time the whole suite sees it.

shipped production is serving it deploy 9cda780

opened this

Four home panels (held, stalled flow, milestones, since you were here) now say what to do next when they're empty. Each shows one muted line with a link instead of rendering nothing. I haven't pushed past the local checks, so the forge's full run on this push is the first time the whole suite sees it.

What changed

  • New src/web/studio/home_empty.ts holds the four lines and an emptyLine(panel) helper. Each line renders as <p class="small muted panel-empty" data-empty="…"> with one link.
  • held.ts, flow_card.ts, since.ts and milestone_lines.ts return that line where they used to return nothing. Milestones show it only to a signed-in viewer, so the visitor door is unchanged.
  • The home's milestones panel now renders on the signed-in /feed, under "since you were here". It was previously only on the visitor door, and the issue lists it as a home panel.
  • .panel-empty reserves 40px, about one filled row, so nothing shifts when work arrives. It's documented in docs/design/areas/home.md.

Tests

  • New test/home-empty-states.test.ts seeds a fresh forge and signs in. It asserts every panel's empty line is present, non-blank and has an href: held on /, the other three on /feed.
  • test/home-since.test.ts asserted that the Since panel is absent when nothing moved. That test is out of date now, so I changed it to assert the empty line. It also stays clear of the phrase "Since you were here", so I gave the empty section the label "Since your last visit".
  • I worded the held line without "Later gate" because home-flow.test.ts forbids that phrase on /.

Checks I ran

  • gate.ts, tsc and design-lint pass.
  • I ran 1,071 home-, feed- and flow-related test files by name. Four failed on the first run. Two came from the empty-state wording; I fixed those and re-ran, and home-since and home-flow pass. The other two (flow-clog-page) passed on a re-run. I couldn't tell flaky from fixed, so the forge's full run is the one to check.
  • I did not run the full suite, because fast.ts named 2,058 test files.

Not done

  • The held line links to /apps, not to a specific app's gate settings.
  • The pre-push hook wanted a commit saying how to try the change, so there is an empty "Try:" commit on the branch.

To try Sign in to a fresh forge and open / for the held line, then /feed for the flow, milestones and since lines.

Closes #12328

10 earlier comments · 3 events
commented

Four home panels (held, stalled flow, milestones, since you were here) now say what to do next when they're empty. Each shows one muted line with a link instead of rendering nothing. I haven't pushed past the local checks, so the forge's full run on this push is the first time the whole suite sees it.

What changed

  • New src/web/studio/home_empty.ts holds the four lines and an emptyLine(panel) helper. Each line renders as <p class="small muted panel-empty" data-empty="…"> with one link.
  • held.ts, flow_card.ts, since.ts and milestone_lines.ts return that line where they used to return nothing. Milestones show it only to a signed-in viewer, so the visitor door is unchanged.
  • The home's milestones panel now renders on the signed-in /feed, under "since you were here". It was previously only on the visitor door, and the issue lists it as a home panel.
  • .panel-empty reserves 40px, about one filled row, so nothing shifts when work arrives. It's documented in docs/design/areas/home.md.

Tests

  • New test/home-empty-states.test.ts seeds a fresh forge and signs in. It asserts every panel's empty line is present, non-blank and has an href: held on /, the other three on /feed.
  • test/home-since.test.ts asserted that the Since panel is absent when nothing moved. That test is out of date now, so I changed it to assert the empty line. It also stays clear of the phrase "Since you were here", so I gave the empty section the label "Since your last visit".
  • I worded the held line without "Later gate" because home-flow.test.ts forbids that phrase on /.

Checks I ran

  • gate.ts, tsc and design-lint pass.
  • I ran 1,071 home-, feed- and flow-related test files by name. Four failed on the first run. Two came from the empty-state wording; I fixed those and re-ran, and home-since and home-flow pass. The other two (flow-clog-page) passed on a re-run. I couldn't tell flaky from fixed, so the forge's full run is the one to check.
  • I did not run the full suite, because fast.ts named 2,058 test files.

Not done

  • The held line links to /apps, not to a specific app's gate settings.
  • The pre-push hook wanted a commit saying how to try the change, so there is an empty "Try:" commit on the branch.

To try Sign in to a fresh forge and open / for the held line, then /feed for the flow, milestones and since lines.

commented

This push fixes the failure: scripts/gate.ts rejected two comment lines over 100 columns, both added by this pull. Both are now rewrapped.

  • src/web/studio/held.ts:35, the heldLine doc comment.
  • src/web/style/components.ts:1020, the .panel-empty comment.

The deploy message you quoted, "no tests declared, none run", only says forge.json has no test command under app. It isn't an error, and the log you pasted shows no failure. I took the gate failure as the likely cause because it was the only red check I found. I did not check the forge's own verdict on this push.

bun x tsc --noEmit is clean and bun scripts/design-lint.ts passes. test/home-empty-states.test.ts and test/home-since.test.ts pass, 13 tests. The gate reads committed state, so it only went green after the commit. Final run: exit 0, no output.

No behaviour changed in this fix, only comment text. The pull still does what it did: the held, stalled-flow, milestones and since-you-were-here panels on the signed-in home each show one line with a next action when empty. To try it, sign in to a fresh forge and open / and /feed.

commented

Every empty panel on the signed-in home now says what it holds and where to go next. The two failures this pull caused are fixed. I pushed again but have not seen the forge's check run on the new commit. Locally, test/attention.test.ts and test/later-gate.test.ts pass, as do home-empty-states.test.ts, tsc --noEmit, scripts/gate.ts and scripts/design-lint.ts.

What changed

  • Panels: the held, stalled-flow, milestones and since-you-were-here panels each show one line with a link when empty. They share src/web/studio/home_empty.ts and the .panel-empty style, which holds the height of a filled row so nothing shifts when work arrives.
  • test/later-gate.test.ts: "a gate that holds nothing says nothing on home" asserted the old behaviour, so the test was wrong, not the code. It now expects data-empty="held" when no gate holds anything.
  • docs/design/attention-budget.json: home's first-view budget rises from 286 to 298 words and from 49 to 50 blocks, at both widths. That is the cost of the four lines. I regenerated the file with FORGE_ATTENTION_WRITE=1, which also lowered the crew page's ceiling from 742 to 737 words.

The other 10 failures in the check log are red on main at 93e874d too: did-you-mean, mcp-table, spawn-pipes, first-screen-line and spawn-sites. I did not touch them.

To try it, sign in to a fresh forge and open /. Each empty panel shows its line and link.

🤖 Generated with Claude Code

commented

The forge's gate failed this pull because no commit message had a Looks: line. I added an empty commit with Looks: /, since home is the page that shows the changed panels. bun scripts/gate.ts now prints nothing here, and I pushed. The forge's check has not run on the new commit yet, so I haven't seen it pass.

Nothing in the code changed from the last push. The pull's description is unchanged: the four empty home panels (held, stalled flow, milestones, since-you-were-here) each say their next action. The attention budget moved for home and the Later-gate test now expects the empty line.

To try it, sign in to a fresh forge and open /.

🤖 Generated with Claude Code

Changes requested — before the latest push

Three things to fix. (1) Flow and Since empty lines link to "/", which is the page the reader is already on, so the 'next action' is a dead link. (2) No terminal door: the terminal home/flow screen (src/tui/screens/flow.ts) still shows nothing for these empty panels, so a terminal user gets no next-step line. Add the same lines there and a test; put the how-to in docs/features/, not README. (3) Tests are weak: the third test only checks constants, and the milestones/since/flow tests only check an href exists, not that it goes somewhere other than the current page. Also: this adds ~12 words and a block to the first view of every signed-in home permanently, against the direction (pipeline first, one confident sentence, nothing explains itself twice). Four always-on 'nothing here' lines is noise; prefer collapsing empty panels into one line when all are empty.

commented

The four per-panel empty lines are gone, replaced by one quiet line on /feed that links to /talk. The terminal dashboard now says the same line. I ran the new tests, the attention budget, and the home, milestone, Later-gate, stalled and TUI tests. All pass, as do tsc, scripts/gate.ts and the design lint. The full check has not run on this push yet.

What changed

  • One line, not four: when nothing is stalled, no milestone moved this week and nothing landed since the last visit, the feed shows a single line: "Nothing is stuck and nothing is new. Tell the crew what to build next". It never appears beside a filled panel. The text is in src/web/studio/home_empty.ts; feedPage reads the stalled cards, the moving milestones and the since-you-were-here digest once.
  • Real destination: the link goes to /talk instead of /. The test asserts the href is not /feed or /, and that /talk answers.
  • Terminal: the dashboard in src/tui/screens/dashboard.ts shows the same words, ending in the path /talk, when its digest is empty and nothing is stalled. test/tui-quiet-line.test.ts covers it. I put this in dashboard.ts, not flow.ts: flow.ts is the admin's Flow dialog, which has no since-you-were-here digest, stalled-card list or milestone strip to be empty, so that's where the since-you-were-here digest lives in the terminal.
  • Tests: the tautological constants test is replaced by one that checks the rendered line's href.
  • Docs and budget: the how-to is in docs/features/quiet-feed.md, not the README, and the design note is rewritten. The home first-view budget goes back to 286 words and 49 blocks, so the earlier raise is undone.

What I chose not to do

  • Held-panel line: I dropped it. Held shows on the / home, not on /feed, so it can't be part of a combined line, and an always-on "nothing is held" line is the noise the review objected to. This leaves that part of the issue unfulfilled, so say if you want a line there anyway. held.ts and test/later-gate.test.ts are back to their main versions.
  • Four panel lines: not kept, per the review. The feed can't say anything about a filled panel's neighbours.

To try it, sign in to a fresh forge and open /feed, or open the terminal dashboard.

🤖 Generated with Claude Code

commented

The signed-in feed now shows one quiet line in place of four panel lines, and the line links to /talk. The terminal dashboard says the same line. This push only fixes the gate failures that blocked the pull.

What changed in this push

  • I rewrapped four comment lines to the gate's 100-column limit. They are in src/tui/screens/dashboard.ts, src/web/studio/milestone_lines.ts, test/home-empty-states.test.ts and test/tui-quiet-line.test.ts. Only comments changed, so behaviour is the same.
  • The "pipeline first" rule also failed, because the pull adds a feature (docs/features/quiet-feed.md) with no pipeline change. I added a Direction: line to the commit message saying the issue asks for the empty states and the pipeline items don't block a one-line feed change. I did not touch the pipeline.

Checks run before pushing

  • bun scripts/gate.ts and bun x tsc --noEmit passed.
  • bun test test/home-empty-states.test.ts test/tui-quiet-line.test.ts passed (5 tests, 0 failures).
  • I did not run the wider suite. scripts/fast.ts named 2065 of 3084 files, so I left that to the forge's check.

How to try it Sign in to a fresh forge and open / and /feed. Each empty panel should show its line and link.

🤖 Generated with Claude Code

commented

I couldn't reproduce the 9 failures, and I changed no code. I merged current main into the branch and pushed, so the forge re-runs the check on a branch that includes it.

  • What I ran: the two failing tests I could identify (release-journey and traffic-history), plus the home, feed, milestone, TUI-dashboard, design and attention suites. All 535 pass, and bun x tsc --noEmit, bun scripts/gate.ts and bun scripts/design-lint.ts are clean.
  • What I couldn't identify: the log cut off before naming the other seven failing tests. Neither identified test touches the quiet-line change (src/web/studio/home.ts, milestone_lines.ts, home_empty.ts and the terminal dashboard).
  • What fast.ts said: it reached 2065 of the 3084 test files, so I didn't run it that broadly.
  • My guess: the failures were load or timing flakes, since the log shows many multi-second tests, or they were already fixed on main. That is unconfirmed.
  • Rebase refused: a rebase onto main would have needed a force push, which is refused. I merged instead, so the push was a plain fast-forward.
  • If it's red again: send the full list of failing tests, because that is the only way to tell a flake from a real cause.

What the pull does (unchanged):

  • When nothing is stuck, no milestone moved this week and nothing landed since the last visit, the signed-in home shows one quiet line instead of blank panels. It reads "Nothing is stuck and nothing is new." and links to /talk.
  • The terminal dashboard prints the same words.
  • The line is as tall as a filled row, so nothing shifts when work arrives.
  • The shared words live in src/web/studio/home_empty.ts.
  • home-empty-states.test.ts and tui-quiet-line.test.ts cover it.

To try it, sign in on the preview and open / on a forge with no stalled work and no recent activity.

🤖 Generated with Claude Code

commented

The signed-in home now says "Nothing is stuck and nothing is new" once, with a link to /talk, instead of three empty panels. The terminal dashboard shows the same line. The check's red on stranger-pull came from this pull, and I've fixed it. I can't confirm the other three failures from here.

The fix. The terminal's quiet line used to end "Tell the crew what to build next: /talk". The stranger-pull test waits for the text next: to appear on the pull screen. It matched the dashboard's quiet line first and read the wrong screen. The terminal line now joins the label and path with →, so it reads "Tell the crew what to build next → /talk". I updated the matching assertion in test/home-empty-states.test.ts and the sentence in docs/features/quiet-feed.md. The web line and its link are unchanged.

What ran. test/stranger-pull.test.ts, test/tui-quiet-line.test.ts, test/home-empty-states.test.ts and test/migrate.test.ts pass locally. bun x tsc --noEmit and bun scripts/gate.ts are clean.

Not confirmed.

  • migrate failures: the two migrate tests that failed in the check pass here, so I made no change for them. I suspect the private-address test's DNS lookup behaves differently on the check machine.
  • Fork-landing failure: I did not run or look at a landed pull moves the forks…, and the push does not touch that area. I'm treating it as unrelated until the next check says otherwise.

To try it. Sign in as a user with nothing stalled and nothing new since their last visit. / shows the one quiet line, and the terminal dashboard shows the same words.

🤖 Generated with Claude Code

Changes requested — before the latest push

Changes requested. Fix first: the quiet line renders in a flex box, which drops the space between its sentence and its link, and the link is far under a 44px target. The rest, in order:

  1. The terminal and the web disagree on what 'quiet' means. The web also counts moving milestones; the dashboard does not. A terminal user with a moved milestone is told 'nothing is new'.
  2. The quiet line is outside the live milestones region, so it stays on screen after a milestone moves live. Its 'nothing shifts' claim is also false: the line is one row, and what replaces it is several.
  3. The issue asks for four panels. The pull handles one combined line and drops held with no issue opened for it. Open one, or say so in the issue.
  4. The pull adds the milestones panel to every signed-in /feed, which the issue did not ask for, and it is not tested. It is a feature added while the direction is pipeline first.
  5. The fourth test does not test what its name says. No test shows the line is absent when something is stuck, moved or landed, and that is the behaviour the pull promises.
  6. attention-budget.json changes for the crew page, which this pull does not touch. Revert it.

I could not sign in on the preview from here, so I judged the served markup from the source.

commented

The signed-in /feed now shows one line, "Tell the crew what to build next", linking to /talk, when the feed has nothing to show. The terminal dashboard decides when to show it by the same rule.

What "quiet" means. Nothing is stalled, no milestone in your apps has open work, and nothing has landed since your last visit. The rule is one function, isQuiet, in src/web/studio/home_empty.ts. The feed passes it what it has already read. The dashboard calls quietFor there, which reads the same three things itself, so a moved milestone now removes the line in the terminal too.

The line. It is a single link with the .home-doors class, so it gets that class's 44px tap area. Because the whole line is the link, there is no gap between a sentence and a link that flex layout could drop. The "Nothing is stuck and nothing is new" sentence, the .panel-empty class and its claim that nothing shifts are gone. In the terminal it reads "Tell the crew what to build next → /talk".

Scope.

  • /feed no longer draws the milestones panel. Milestones only count towards the quiet rule, so there is no live milestones region left to sit beside the line.
  • src/web/studio/milestone_lines.ts, src/web/style/components.ts and docs/design/attention-budget.json are back to main.
  • sinceYouWere now returns null when it has nothing, like flowCards.
  • The issue asked for four empty states. This pull covers three of them with one combined line. The held panel is left to new issue #12462, and #12328 has a comment saying so.

Tests.

  • test/home-empty-states.test.ts:

- A fresh forge shows exactly one quiet line, its only link goes to /talk, and there is no milestones panel. - On separate fresh forges, seeding a stalled pull, a milestone with open work, or a pull merged a minute ago each removes the line. - isQuiet is checked for each of the three on its own.

  • test/tui-quiet-line.test.ts: the dashboard shows the line on a fresh forge, and hides it once a milestone or a stalled pull is seeded.
  • Shared seeding is in test/helpers/quiet-feed.ts.
  • I checked that the milestone tests fail when milestones are left out of the rule, on both the feed and the dashboard.

Checks run.

  • bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts are clean.
  • scripts/fast.ts named 2062 files, about three hours, so I picked the feed, home, since, dashboard, flow-card, milestone, design-lint and stranger-pull tests: 999 tests, 998 passed.
  • The one failure was the real-browser composer-draft test. The sandbox refused its connection to localhost:80, so I couldn't run it here. It doesn't touch this change, and the forge's check runs it.

To try it. Sign in to a fresh forge and open /feed, or open the terminal dashboard. Then open a pull and leave it without a check for a few hours, and the line goes away.

🤖 Generated with Claude Code

commented

The feed's quiet line ("nothing stalled, no milestone, nothing landed") now follows one rule on both doors, the web home and the terminal dashboard. src/web/studio/home_empty.ts holds that rule as QuietFacts, isQuiet and quietFor, and the web home and src/tui/screens/dashboard.ts both call it. The web home shows the line as a single 44px link with no extra panel, and its arrow means it can't be mistaken for a pull's "next: " line. test/tui-quiet-line.test.ts checks that the terminal shows the line by the same rule.

The last push fixes the gate failure: four doc comments over 100 columns are rewrapped, in src/tui/screens/dashboard.ts, src/web/studio/home_empty.ts (two) and test/tui-quiet-line.test.ts. Only comments changed, so behaviour is the same. The gate, bun x tsc --noEmit and the two test files that cover this change pass (11 tests).

No new dependencies.

To try it: sign in as someone with nothing stalled, no milestone with open work and nothing landed since their last visit. The home page, and the dashboard in the terminal (FORGE_APP_SSH), both show the quiet line.

🤖 Generated with Claude Code

Approved

Earlier asks, checked against the head: (1) the flex line that dropped the space between sentence and link is gone; the line is now one link inside .home-doors, so it has the 44px hit area and no space to lose. (2) The "nothing is new" sentence is gone; one phrase names the next action. (3) The link goes to /talk, not to the page the reader is on, and the test asserts that. (4) The terminal door exists in dashboard.ts with a test, and the how-to is in docs/features/quiet-feed.md, not the README. (5) Four always-on lines became one line shown only when the feed is quiet, which removes the first-view cost. No new class, no new dependency. The preview answers 200. I read the diff, not a screenshot of the quiet state.

Next, both Non-blocking: (a) land the held-panel line (#12462) so box 1 can close. (b) Assert in the feed test that the quiet line sits after the composer region in source order, so a later reorder cannot push it above the real rows.

commented

Left #12328 open: 1 unticked item remain (Home panels (held, flow, milestones, since you were here) each render a one-line empty state naming the next action with a link).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs